From 207e3e6410598b82f2369791eead3a14a86a0036 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Thu, 8 Jan 2009 18:51:11 +0000 Subject: [PATCH] Reverted r45517 " * (bug 16921) Add a maxlength for the reason field of the page move form. Changed from 'textarea' to 'text' because 'textarea' does not support maxlength. Makes it consistent with all other reason fields." This field is deliberately not a single-line text input field because it caused confusion when it was. --- RELEASE-NOTES | 1 - includes/specials/SpecialMovepage.php | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 70d2e66fbc..b281efc483 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -32,7 +32,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN === Bug fixes in 1.15 === -* (bug 16921) Add a maxlength for the reason field of the page move form === Languages updated in 1.15 === diff --git a/includes/specials/SpecialMovepage.php b/includes/specials/SpecialMovepage.php index 1c7fcbcd45..acc27625dc 100644 --- a/includes/specials/SpecialMovepage.php +++ b/includes/specials/SpecialMovepage.php @@ -184,7 +184,7 @@ class MovePageForm { Xml::label( wfMsg( 'newtitle' ), 'wpNewTitle' ) . " " . - Xml::input( 'wpNewTitle', 60, $newTitle->getPrefixedText(), array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) . + Xml::input( 'wpNewTitle', 40, $newTitle->getPrefixedText(), array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) . Xml::hidden( 'wpOldTitle', $this->oldTitle->getPrefixedText() ) . " @@ -193,8 +193,7 @@ class MovePageForm { Xml::label( wfMsg( 'movereason' ), 'wpReason' ) . " " . - Xml::input( 'wpReason', 60, $this->reason, array( 'type' => 'text', - 'id' => 'wpReason', 'maxlength' => 200 ) ) . + Xml::tags( 'textarea', array( 'name' => 'wpReason', 'id' => 'wpReason', 'cols' => 60, 'rows' => 2 ), htmlspecialchars( $this->reason ) ) . " " ); -- 2.20.1