C. Scott Ananian [Tue, 24 Jun 2014 18:15:25 +0000 (14:15 -0400)]
Allow HTML5 <rtc> tag (ruby support for East Asian typography).
We currently allow <ruby>, <rt>, <rb>, and <rp> but not the W3C HTML5
<rtc> element. Fix that.
(Note that <rb> and <rtc> are new additions to HTML5 which currently
appear in the W3C but not the WHATWG version of the HTML5 spec.
Support for these has already been merged in gecko and webkit and
the editor plans to update the WHATWG spec.)
Bug: 67042
Change-Id: I8c0e65d782b6d23057a9723b87323b28e8bf8852
jenkins-bot [Wed, 2 Jul 2014 22:18:04 +0000 (22:18 +0000)]
Merge "Don't use rclimit preference on Special:Search"
jenkins-bot [Wed, 2 Jul 2014 22:01:17 +0000 (22:01 +0000)]
Merge "Reword security reminder at the top of the release notes"
jenkins-bot [Wed, 2 Jul 2014 21:08:03 +0000 (21:08 +0000)]
Merge "chunky_png Ruby gem is not used"
withoutaname [Sat, 28 Jun 2014 18:30:57 +0000 (11:30 -0700)]
Reword security reminder at the top of the release notes
Change-Id: Ia33f6eb9b2188c8a1624fc06c3830cf916f24264
Translation updater bot [Wed, 2 Jul 2014 19:34:42 +0000 (19:34 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib189d947865ccc4b15cb617ed5db6045250e3106
jenkins-bot [Wed, 2 Jul 2014 18:50:43 +0000 (18:50 +0000)]
Merge "Fixed EmptyPass error message"
jenkins-bot [Wed, 2 Jul 2014 18:28:15 +0000 (18:28 +0000)]
Merge "De-duplicate pages in replaceInternal"
James D. Forrester [Wed, 2 Jul 2014 16:19:00 +0000 (09:19 -0700)]
Update OOjs UI to v0.1.0-pre (
432a76f7d4)
New changes:
ebfa365 Generate RTL stylesheets with CSSJanus
da83ad2 Set tabindex on button <div> instead of <a>
e2a6bb1 Add tabindex=0 and role=button to tool links
432a76f Run node-svgo to crush all SVGs whilst retaining readibility
Change-Id: Ieb775472b05acf42aada190a49f9f768ddcd5084
Cmcmahon [Wed, 2 Jul 2014 15:37:10 +0000 (08:37 -0700)]
QA: need login tags for Jenkins build
Change-Id: I6663c6f6f59d692a9825ff8b462b30e1b2214ae0
jenkins-bot [Wed, 2 Jul 2014 14:07:28 +0000 (14:07 +0000)]
Merge "Make the URL input on Special:LinkSearch ltr by default"
jenkins-bot [Wed, 2 Jul 2014 13:58:28 +0000 (13:58 +0000)]
Merge "Workaround image magick issue with greyscale xcf files"
Željko Filipin [Wed, 2 Jul 2014 13:55:58 +0000 (15:55 +0200)]
chunky_png Ruby gem is not used
Also fixed the order of gems in env.rb and updated Ruby gems in
Gemfile.lock.
Change-Id: I1ff294a50f37373bfdd3d04404c498e94b6f79ba
Željko Filipin [Wed, 2 Jul 2014 13:50:58 +0000 (15:50 +0200)]
Fixed EmptyPass error message
mediawiki_api Ruby gem needs user password, but it is only set if the
scenario has @login Cucumber tag.
The entire error message: EmptyPass (MediawikiApi::LoginError)
For the entire stack trace see
1:
https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-
Core-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/14/consoleFull
Change-Id: Ib5c297d9bfc1ca953d3aec27208fb99143fec011
Max Semenik [Fri, 13 Jun 2014 23:08:52 +0000 (16:08 -0700)]
New hook, AfterParserFetchFileAndTitle
It is needed for PageImages to collect information about galleries, improving results
for Commons mainspace.
Bug: 66510
Change-Id: I3136d648ef2c1841767db0ab33855cd168e3de3e
jenkins-bot [Wed, 2 Jul 2014 00:04:55 +0000 (00:04 +0000)]
Merge "SpecialSearch: Fix pagination"
jenkins-bot [Tue, 1 Jul 2014 21:38:39 +0000 (21:38 +0000)]
Merge "Database: Generalise SQL before writing to debug log"
Translation updater bot [Tue, 1 Jul 2014 20:21:26 +0000 (20:21 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I39205dcbe72128c4d2978282309d208f059395fd
Brad Jorsch [Tue, 1 Jul 2014 19:53:59 +0000 (15:53 -0400)]
Properly count actions in Special:ActiveUsers
The cache of active users maintained by Special:ActiveUsers filters out
certain actions, but the displayed action count does not. Fix this.
Change-Id: Ifb9035a08328587c43c46520c5062602b9b9c6f5
Timo Tijhof [Tue, 1 Jul 2014 19:38:53 +0000 (21:38 +0200)]
Database: Generalise SQL before writing to debug log
The log often contains stuff like the following, where the trimmed
snippet can span many many lines:
* DatabaseBase::query: Writes done: INSERT IGNORE INTO `msg_resource`
(mr_lang,mr_resource,mr_blob,mr_timestamp) VALUES ('۶?2x?ptt?`0<snip>?`0??O?')
* DatabaseBase::query: Writes done: REPLACE INTO `objectcache`
(keyname,value,exptime) VALUES ('۶?2x?ptt?`0<snip>?`0??O ?`???`0??O ?`???`0?')
Bug: 67382
Change-Id: I76ca042f166fed56d86df15f788702384d48064c
Chad Horohoe [Tue, 1 Jul 2014 19:28:53 +0000 (12:28 -0700)]
SpecialSearch: Fix pagination
This basically reverts
f4357b6 but fixes it while we're here. Requesting
one extra result causes extra load and weird queries against the search
backend...all to be thrown away. Plus it's showing "Results 1-21 of N"
when we're only showing 20 which is a regression.
All search backends implement getTotalHits() so use that count instead
to figure out if we're on the last page.
Change-Id: Ib38b1e124bea7133f48209ef8af1b1e26b4dba75
jenkins-bot [Tue, 1 Jul 2014 19:14:54 +0000 (19:14 +0000)]
Merge "API: Fix queries for list=allusers&auactiveusers"
jenkins-bot [Tue, 1 Jul 2014 19:03:25 +0000 (19:03 +0000)]
Merge "vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible"
rillke [Tue, 1 Jul 2014 16:08:19 +0000 (18:08 +0200)]
vector/jquery.ui.core.css: Update rule for .ui-helper-hidden-accessible
A Blink rendering bug causes dialogs to vanish in Chrome and Opera Next
with current CSS (bug 67243).
The file resources/lib/jquery.ui/themes/smoothness/jquery.ui.core.css
(from the default jquery.ui theme, 'smoothness') was used as a template.
Upstream commits:
* https://github.com/jquery/jquery-ui/commit/
a9d854967f0
* https://github.com/jquery/jquery-ui/commit/
48e0aa0fd27
Bug: 67243
Change-Id: Ib099282484bb29f5d33208be843686bf3ca11366
jenkins-bot [Tue, 1 Jul 2014 17:44:34 +0000 (17:44 +0000)]
Merge "API: Fix setnotificationtimestamp with no pages given"
jenkins-bot [Tue, 1 Jul 2014 17:26:52 +0000 (17:26 +0000)]
Merge "ApiOptionsTest: Simplify hook restoration"
jenkins-bot [Tue, 1 Jul 2014 17:24:26 +0000 (17:24 +0000)]
Merge "UserTest: Cover User::isIP and User::isValidUserName better"
Kartik Mistry [Tue, 1 Jul 2014 15:56:13 +0000 (15:56 +0000)]
Fixed typo
unkown -> unknown
Change-Id: Ibbe73853258fd476d4e6f1b28dce27a20233f58f
Timo Tijhof [Tue, 1 Jul 2014 16:32:05 +0000 (18:32 +0200)]
ApiOptionsTest: Simplify hook restoration
Change-Id: I2afc35b45caf9ddfd34fb0bba0839987b7fb2ed4
Timo Tijhof [Tue, 1 Jul 2014 16:31:07 +0000 (18:31 +0200)]
UserTest: Cover User::isIP and User::isValidUserName better
Change-Id: I4663c37871492c1415152b2af0fda4f6de4f212f
Brad Jorsch [Sat, 4 May 2013 12:34:41 +0000 (08:34 -0400)]
API: Fix setnotificationtimestamp with no pages given
When newerthanrevid or torevid is used and no pages are given, do not
throw a fatal PHP error.
When no pages are given in other modes, do not return a database error.
Bug: 48071
Change-Id: I5abcdf0fa20486f1198d1cc111461b3088a311df
jenkins-bot [Tue, 1 Jul 2014 15:00:45 +0000 (15:00 +0000)]
Merge "Removes 'languageshtml' property in mediawiki API's 'parse' action"
paladox [Tue, 1 Jul 2014 13:53:22 +0000 (13:53 +0000)]
mediawiki.searchSuggest: Enable for iPhone and iPod touch
* This removes iPhone and iPod touch from browser blacklist.
* Similar to
f64a3c26c6 in WikiEditor.
* it requires iOS 6 or later to work.
Change-Id: I46913bb6d360d6b0994b0585c0064f16f1ed460b
Rohan [Tue, 1 Jul 2014 13:34:33 +0000 (19:04 +0530)]
Removes 'languageshtml' property in mediawiki API's 'parse' action
Bug: 67149
Change-Id: Ib1dfa0d04380839bbe474cbb5c0a9b6af09b8371
jenkins-bot [Tue, 1 Jul 2014 13:53:22 +0000 (13:53 +0000)]
Merge "Setup.php: Move hacky skin requires higher up"
jenkins-bot [Tue, 1 Jul 2014 13:53:18 +0000 (13:53 +0000)]
Merge "Function type hints for LinkHolderArray.php"
Bartosz Dziewoński [Tue, 1 Jul 2014 13:39:46 +0000 (15:39 +0200)]
Setup.php: Move hacky skin requires higher up
Some of the setup code in some of the configurations apparently depends
on all extensions and skins being already required by the point
Setup.php is being loaded. We ran into issues with LocalisationCache.
Bug: 67318
Change-Id: Idde13c2e835a9969593a4716a62b392d4c1388d6
jenkins-bot [Tue, 1 Jul 2014 11:20:08 +0000 (11:20 +0000)]
Merge "Improve Database related documentation a bit"
jenkins-bot [Tue, 1 Jul 2014 11:18:05 +0000 (11:18 +0000)]
Merge "Make the global objects documentation consistent in Setup.php"
jenkins-bot [Tue, 1 Jul 2014 11:16:22 +0000 (11:16 +0000)]
Merge "Documentation improvements in ChangeTags.php"
jenkins-bot [Tue, 1 Jul 2014 11:16:07 +0000 (11:16 +0000)]
Merge "Don't use isset() to check for null"
Alexandre Emsenhuber [Sat, 10 May 2014 09:26:15 +0000 (11:26 +0200)]
Improve Database related documentation a bit
- $wgDBport is also for MSSQL
- "type" key of $wgDBservers is not only "mysql" and "postgres"
- Note that $wgDBssl, $wgDBcompress and $wgDebugDumpSql only
work in certain cases and mention how to emulate them otherwise
Change-Id: Id863da8c87308d06e0070877ac0af26d03be4faf
Reedy [Tue, 1 Jul 2014 00:44:04 +0000 (01:44 +0100)]
De-duplicate pages in replaceInternal
Change-Id: If534308040201f0c4f9d315fae508c7dd3f53ee9
Reedy [Tue, 1 Jul 2014 00:40:19 +0000 (01:40 +0100)]
Function type hints for LinkHolderArray.php
Change-Id: I5e429baab774a790b3558732f9c87637adfbe4ce
Aaron Schulz [Tue, 10 Jun 2014 22:13:41 +0000 (15:13 -0700)]
Improved DB handling in LCStoreDB
* Only do the DB inserts in finishWrite(). Previously this would
COMMIT there but would spread out queries throughout the set()
calls. This pushes all the contention down to the last step.
Change-Id: Ia8afb79a8328c18a7d8a386bcd15a5074007d52e
jenkins-bot [Mon, 30 Jun 2014 22:02:22 +0000 (22:02 +0000)]
Merge "mediawiki.feedback: Don't use deprecated calling convention for mw.Api#newSection"
Bartosz Dziewoński [Mon, 30 Jun 2014 21:43:00 +0000 (23:43 +0200)]
mediawiki.feedback: Don't use deprecated calling convention for mw.Api#newSection
Change-Id: I82e69a19f1d4416d456521c1233d13a349fe457e
umherirrender [Fri, 13 Jun 2014 19:16:37 +0000 (21:16 +0200)]
Add SpecialPagesWithProp::prefixSearchSubpages
This shows the existing props as subpages on search suggestion
Change-Id: I3d35474bcf840a6feede8079642d83074874c6f3
Translation updater bot [Mon, 30 Jun 2014 20:40:58 +0000 (20:40 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Mon, 30 Jun 2014 20:36:36 +0000 (20:36 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I77bfdae2686c736fbd1b9bd44cfc690d9e4bad13
jenkins-bot [Mon, 30 Jun 2014 20:30:52 +0000 (20:30 +0000)]
Merge "qunit.completenessTest: Ignore mw.loader.moduleRegistry"
jenkins-bot [Mon, 30 Jun 2014 20:30:39 +0000 (20:30 +0000)]
Merge "qunit.completenessTest: Suppress mw.log.warn in walkTheObject"
jenkins-bot [Mon, 30 Jun 2014 20:30:10 +0000 (20:30 +0000)]
Merge "qunit.completenessTest: Unbreak regular functions with static methods"
Alexandre Emsenhuber [Mon, 30 Jun 2014 19:51:29 +0000 (21:51 +0200)]
Don't use isset() to check for null
$wgLocalTZoffset is defined in DefaultSettings.php so it is always set.
Change-Id: I86518176b30da4e13f6dbfde8f1c77c8ced58d9f
JuneHyeon Bae [Fri, 30 May 2014 12:34:42 +0000 (21:34 +0900)]
Do not show user blocked warning on included Special:Contributions page
When user included {{Special:Contributions}} page of blocked user,
do not show "this user is blocked" box.
Bug: 65781
Change-Id: I13b80f829dd26bf960b16efea588618c36898a5d
jenkins-bot [Mon, 30 Jun 2014 19:27:58 +0000 (19:27 +0000)]
Merge "Salt the "nsToken" used for Special:Search namespace remembering"
jenkins-bot [Mon, 30 Jun 2014 18:50:15 +0000 (18:50 +0000)]
Merge "Fix CSSMin url() remapping when comments in CSS contain curly braces"
jenkins-bot [Mon, 30 Jun 2014 17:43:13 +0000 (17:43 +0000)]
Merge "Remove 'webkit-backface-visibility' rule which made iPads super blurry"
jenkins-bot [Mon, 30 Jun 2014 17:26:58 +0000 (17:26 +0000)]
Merge "chmod 644"
Reedy [Mon, 30 Jun 2014 17:16:42 +0000 (18:16 +0100)]
chmod 644
Change-Id: I31dddeb4e6373f5817fdfaeba3ff95699aec86b6
jenkins-bot [Mon, 30 Jun 2014 17:17:06 +0000 (17:17 +0000)]
Merge "Fix file permissions from Ic7fc3bd836241dce8f296237bbd80ed3e4d1ee0d"
jenkins-bot [Mon, 30 Jun 2014 17:12:24 +0000 (17:12 +0000)]
Merge "Make Preferences tests language-agnostic"
Cmcmahon [Fri, 27 Jun 2014 20:57:45 +0000 (13:57 -0700)]
Make Preferences tests language-agnostic
Change-Id: I2a0bd6e4306de11a8b3f13505bc3e65439211e23
Brad Jorsch [Mon, 28 Apr 2014 16:03:02 +0000 (12:03 -0400)]
API: Fix queries for list=allusers&auactiveusers
The query introduced to support the auactiveusers is itself broken (it
counts every edit multiple times when combined with the group filters or
auprop=groups or auprop=rights, or for users with multiple rows in
ipblocks) and it breaks auprop=groups and auprop=rights.
Instead, let's filter using the same cached data used by
Special:ActiveUsers and do the actual counting of recent "edits" in a
subquery. And for parity with Special:ActiveUsers, let's skip
RC_EXTERNAL when doing the count.
Also, it turns out the "recenteditcount" property in the result is
really more like "recentactions" since it counts any action that shows
up in recentchanges; the discrepancy between that and "editcount" can be
confusing if someone is doing a lot of logged actions that don't create
dummy revisions. Let's rename that, but we'll have to keep the old
property around for a while for BC.
Bug: 64505
Bug: 64507
Bug: 67301
Change-Id: I461e92819188c311cbb3853bc6bfad45962c8d7b
Reedy [Mon, 30 Jun 2014 14:31:47 +0000 (15:31 +0100)]
Fix file permissions from Ic7fc3bd836241dce8f296237bbd80ed3e4d1ee0d
Change-Id: I5d147c6baa034057f95e69b78811b9011cc4355e
jenkins-bot [Mon, 30 Jun 2014 14:23:16 +0000 (14:23 +0000)]
Merge "Added missing Cucumber tags to Selenium tests"
Stephan Gambke [Thu, 12 Jun 2014 21:55:33 +0000 (23:55 +0200)]
Fix CSSMin url() remapping when comments in CSS contain curly braces
Remapping of url()s was thrown off if the CSS contained comments
with curly braces. To fix, replace all block comments (except @embed
directives) with placeholders before url() processing and swap them
back in afterwards. Patch also includes tests.
Bug: 60077
Change-Id: If18a93c17ea9bcd529f6a664aa2dcc51d4a37f38
Bartosz Dziewoński [Sun, 29 Jun 2014 19:49:12 +0000 (21:49 +0200)]
Vector: Remove translations for non-existent message 'vector-desc'
Follow-up to Id7bde76b.
It seems that l10n-bot will only remove them if anything else changes
in any of the messages (see e.g. change Id40eee57), and this message
key is conflicting with the one used by the old Vector extension.
Letting it stay here is at best confusing and at worst problematic.
Change-Id: I649e305a5eaa019b9afeb4fd9aa1cbe06259db66
rillke [Tue, 27 May 2014 20:36:51 +0000 (22:36 +0200)]
Name implicitly created CHECK constraints
to ease future maintenance work. The pattern for catching the right
CHECK constraint is admittedly vague but the order in which auto-created
CHECK constraints of a table is removed doesn't really matter assuming
the update is always completed before another update is applied. If
updates are run through Update.php, that should be always the case.
Furthermore eliminating a bug causing application of several patches each
time when running Update.php
Bug: 65757
Bug: 65813
Change-Id: Ic7fc3bd836241dce8f296237bbd80ed3e4d1ee0d
jenkins-bot [Sun, 29 Jun 2014 23:40:20 +0000 (23:40 +0000)]
Merge "Less false positives for MEDIATYPE_VIDEO"
Marco [Thu, 1 May 2014 20:42:59 +0000 (22:42 +0200)]
Less false positives for MEDIATYPE_VIDEO
Remove the ffmpeg2theora String to suppress false positives
when doing type detection on ogg files
(Importing pull 23 from github)
Bug: 63584
Change-Id: Ib39ed06f895624b55d15a001cb0a2cd3129f4bb0
Brion Vibber [Sun, 29 Jun 2014 22:14:09 +0000 (15:14 -0700)]
Remove 'webkit-backface-visibility' rule which made iPads super blurry
An extra CSS rule was snuck into the .transition mixin in I895679ff
which caused the entire content area in Vector skin to render blurry
on iPads, especially visible on non-Retina devices.
There was no mention of it in the commit message, but a comment in
the mixin source said something about a 'Chrome 1px movement bug'.
With no source for said Chrome bug and a definite Safari bug, let's
try removing it for now.
Bug: 67286
Change-Id: If6e88d2b5fa7adaa3cd8198686422a65689fa68b
Timo Tijhof [Thu, 19 Jun 2014 06:10:16 +0000 (08:10 +0200)]
qunit.completenessTest: Ignore mw.loader.moduleRegistry
It was iterating over it and considering its 'script' properties
to be methods that had to be tested.
The CompletnessTest before this change is filled with stuff like:
- loader.moduleRegistry.skins.vector.js.script
- loader.moduleRegistry.mediawiki.api.script
- loader.moduleRegistry.mediawiki.Title.script
- ..
And was actually causing it to hit hard limit and thus actual
lots of actual methods were no longer inspected by the test.
Change-Id: I13fbf1224b48aa34a7bb01fdc0543023e502bb4f
Timo Tijhof [Mon, 23 Jun 2014 23:28:43 +0000 (01:28 +0200)]
qunit.completenessTest: Suppress mw.log.warn in walkTheObject
Lots of false positives where triggered for deprecation notices
while iterating over the object.
Change-Id: I710946062edd38b8d72ced6d67bd4bb7613246e3
Timo Tijhof [Thu, 19 Jun 2014 06:06:45 +0000 (08:06 +0200)]
qunit.completenessTest: Unbreak regular functions with static methods
While it already skipped constructor functions during the injection
phase (and thus didn't affect their properties), regular functions
can have properties, too.
Due to the QUnit CompletenessTest injecting a spy in mw.log,
things like mw.log.warn became undefined and causing exceptions
to be thrown sometimes.
Fix breaking of mw.log methods (and potentially other things) by
giving letting the spy function object inherit from the original
function object.
Also reduced and simplified logic further to accomodate this new
approach.
* Give injectCheck obj/key instead of masterValue/currPath.
* Pass around obj/key instead of value/key.
* Remove 'action' parameter, only ACTION_INJECT was ever used.
* Remove logic for 'prototype', this is now included in the type function/object case.
* Remove logic for 'prototype.constructor', this exclusion works naturally
due to constructor functions being filtered out.
Change-Id: If16db9337a99865ada0fe1c482dd62a572239030
Translation updater bot [Sun, 29 Jun 2014 18:28:21 +0000 (18:28 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: Id40eee5754cd13f0573f841c8ea42cb1ad67d4f4
umherirrender [Sun, 29 Jun 2014 14:13:09 +0000 (16:13 +0200)]
Remove comment about externaledit from EditAction
The ExternalEdit class was removed in
Ic3791d188688f556753ab5556a4d9733bbf2e85e
Change-Id: I3cec96c0fe2a597ba5360c08d6bde55397fc9204
umherirrender [Sun, 29 Jun 2014 14:05:18 +0000 (16:05 +0200)]
Remove internaledit, externaledit, mode params from My* special pages
The corresponding code was removed with
Ic3791d188688f556753ab5556a4d9733bbf2e85e, so there is no need to allow
these params on such redirects.
The redirect will not break, only the param is removed from request.
Change-Id: Ibb85bf3b23c9d17336f0a8b37a7315da8dcb7eef
umherirrender [Sun, 29 Jun 2014 12:46:49 +0000 (14:46 +0200)]
Fix return doc for UploadBase::isAllowed
Method can return bool or string
Change-Id: Ib290843ce97926bfc529d510b1898f35c7e3f6c6
umherirrender [Sun, 27 Apr 2014 13:39:33 +0000 (15:39 +0200)]
Use Database methods in RevisionDeleteUser::setUsernameBitfields
The bit handling in RevisionDeleteUser::setUsernameBitfields was not
using Database::bitAnd, bitOr or bitNot.
Also changed one condition to use Database::addQuotes
Change-Id: I898ab5afcb628bb7ebe81bae1522153434c7fe98
jenkins-bot [Sun, 29 Jun 2014 12:02:09 +0000 (12:02 +0000)]
Merge "Replace hardcoded square brackets by message brackets"
jenkins-bot [Sun, 29 Jun 2014 12:01:43 +0000 (12:01 +0000)]
Merge "Fix uncaught ApiFormatXml exception with api debuginfo"
Fomafix [Thu, 12 Jun 2014 05:58:44 +0000 (05:58 +0000)]
Replace hardcoded square brackets by message brackets
* Rename $temp into $attribs
Change-Id: Id8792f9e6d0de6460a5c6a4ae34b8a745fe2409e
umherirrender [Thu, 10 Apr 2014 15:31:25 +0000 (17:31 +0200)]
HTMLSelectOtherFields: Have 'other' always as first element
The other field is in most case the default item selected in the drop
down box when a page is loaded. But when the last item is selected you
have to scroll to the top to select one of the first item, which are
often the common or most used items.
So adding the 'other' always as first item to the list.
For the HTMLSelectAndOtherField this was before
If4175332405d26c7ff2e8fbe100bcad61762ce6f, so that is fixing a
regression. In my opinion it should be the same for both types.
Follow-Up: If4175332405d26c7ff2e8fbe100bcad61762ce6f
Change-Id: I82f31e260d63bfaa6a4a94908e019feb9e0f2421
Amir E. Aharoni [Sun, 29 Jun 2014 09:31:19 +0000 (12:31 +0300)]
Make the URL input on Special:LinkSearch ltr by default
Change-Id: I77d74367375fc72e21bf16007cd6a48a2b7cd3e3
umherirrender [Wed, 28 May 2014 19:51:54 +0000 (21:51 +0200)]
Add comment to TableDiffFormatter::blockHeader
magic strings should have a comment
Change-Id: I23fc7a4de31e22383f0a6ffd1db56717615cfa0c
jenkins-bot [Sun, 29 Jun 2014 00:37:42 +0000 (00:37 +0000)]
Merge "Combine SpecialPageBeforeFormDisplay set of hooks into one"
jenkins-bot [Sun, 29 Jun 2014 00:34:39 +0000 (00:34 +0000)]
Merge "Move QueryPage and abstract subclasses to specialpage folder"
Kevin Israel [Sun, 22 Jun 2014 11:50:10 +0000 (07:50 -0400)]
Combine SpecialPageBeforeFormDisplay set of hooks into one
Hooks with dynamically generated names cannot be documented in the normal
manner, and indeed this set, added in r86482 /
10d93c34cb17, was not.
In contrast, every other hook in core has a name that is a fixed string
and thus is easy to grep for, create a manual page title for, and so on.
Conceptually, each hook's name should correspond to one or more locations
at which code can be inserted.
So I changed the code to use hook name "SpecialPageBeforeFormDisplay"
for all FormSpecialPages and added the special page name as a parameter,
which is consistent with existing hook "ActionBeforeFormDisplay".
From extensions in Gerrit, the only use I found was in StopForumSpam,
which is updated to use the new hook in Id474915a. So I chose to break
backward compatibility instead of using a hack to hide the old hooks
from maintenance/findHooks.php.
After three years, the script again reports, "Looks good!"
Change-Id: I7ea6521b47fb034bc367a1d06d477a7654035a5f
This, that and the other [Tue, 27 May 2014 08:09:24 +0000 (18:09 +1000)]
Fix initSiteStats.php maintenance script
It appears not to have worked for some time, as it either calls a protected
function ($counter->refresh()) or an undefined function
($counter->update()) depending on the parameters specified.
Bug: 65214
Change-Id: Ia7d867792b84c98714ec6dbbfef09745e875c8bc
jenkins-bot [Sat, 28 Jun 2014 22:56:05 +0000 (22:56 +0000)]
Merge "Tweaks to Parsoid CSS styles for citations."
jenkins-bot [Sat, 28 Jun 2014 21:17:45 +0000 (21:17 +0000)]
Merge "installer: Remove unnecessary param to outputCss()"
Sergio Santoro [Fri, 27 Jun 2014 19:03:37 +0000 (21:03 +0200)]
installer: Remove unnecessary param to outputCss()
WebInstaller::outputCss no longer requires an argument
as of I717cb299b3639024.
Change-Id: I85c1624eb99affd5df809a041cfc9f22fc46945a
Alexandre Emsenhuber [Sat, 28 Jun 2014 19:59:35 +0000 (21:59 +0200)]
Remove unneeded else brach from SpecialAllMessages::execute()
Spotted while reviewing I49cf4f294a (
8b4c170)
Change-Id: I5b18106bbd892a22c0d48aefecc1ae246b577480
aude [Sat, 28 Jun 2014 18:35:52 +0000 (20:35 +0200)]
Fix uncaught ApiFormatXml exception with api debuginfo
Also added tests to cover this.
Bug: 67246
Change-Id: Ifb2e392d3277a4702832727f70c77b170d4b2bf5
Željko Filipin [Sat, 28 Jun 2014 14:09:21 +0000 (16:09 +0200)]
Added missing Cucumber tags to Selenium tests
Also:
- updated Ruby to version 2.1.2
- added missing ruby-gemset section to Gemfile
Change-Id: I2e6e7213ce51e8a15ecea34f76dd265d9d2f8594
Reedy [Mon, 16 Jun 2014 17:39:07 +0000 (18:39 +0100)]
De-globali[sz]e AllPages and Prefixindex
Change-Id: I2ea969b3bf2573448562fd98b9306997bcfcfea4
Reedy [Mon, 16 Jun 2014 17:30:26 +0000 (18:30 +0100)]
De-globali[sz]e Special:Allmessages
Change-Id: I49cf4f294a6543c7ee9ca56d9d6e9635996de30d
paladox [Wed, 18 Jun 2014 00:27:39 +0000 (00:27 +0000)]
Update Moment.js from 2.6.0 to 2.7.0
Project site
* http://momentjs.com/ and https://github.com/moment/moment/
File source
* https://github.com/moment/moment/blob/2.7.0/moment.js
README
* https://github.com/moment/moment/blob/2.7.0/readme.md
Changelog
https://gist.github.com/ichernev/
b0a3d456d5a84c9901d7
difference between 2.6.0 and 2.7.0
new languages
• #1678 Bengali (bn)
• #1628 Azerbaijani (az)
• #1633 Arabic, Saudi Arabia (ar-sa)
• #1648 Austrian German (de-at)
features
• #1663 configurable relative time thresholds
• #1554 support anchor time in moment.calendar
• #1693 support moment.ISO_8601 as parsing format
• #1637 add moment.min and moment.max and deprecate min/max instance methods
• #1704 support string value in add/subtract
• #1647 add spm support (package manager)
bugfixes
• #1651 fixes #1627 fix timezone parsing in some edge cases
• #1641 fixes #1626 fix creation from week/weekday/weekyear for weeks starting monday
• #1616 fix language code of cyrillic Serbian (sr-cyrl) and latin Tamazight (tzm-latn)
language bugfixes
• #1699 fixes #1326 use lowercase months in Italian
• #1650 partly fixes #1640 implement meridiem parsing for Russian
• #1673 fix lithuanian weekday names for weeks not starting Monday
• #1433 Better "time ago" expression for European Portuguese
• #1671 Improve welsh past expressions
• #1449 Use dot after the day number in Danish
• #1559 Update arabic numbers, meridiem and short weekdays
• #1622 Fix previous Saturday in Greek
tests
• #1687 fixed flaky test in Russian timezone
Change-Id: If8e065bf9e0962059697e6f08100e7bc966cd32f
jenkins-bot [Sat, 28 Jun 2014 07:45:04 +0000 (07:45 +0000)]
Merge "Replace deprecated Title::escapeCanonicalURL call"