Tim Starling [Wed, 17 Dec 2008 07:42:46 +0000 (07:42 +0000)]
Is this needed? Probably not, but it doesn't hurt. The connection is only used for reading, so the commitMasterChanges() is technically unnecessary but harmless. Without closeAll(), the connection will be held open until the script terminates, but that's probably pretty soon in this case.
Aaron Schulz [Wed, 17 Dec 2008 07:17:59 +0000 (07:17 +0000)]
Use more thorough Title->userCan('patrol')
David McCabe [Wed, 17 Dec 2008 07:08:16 +0000 (07:08 +0000)]
UserMailer bigtime refactor. Please test.
David McCabe [Wed, 17 Dec 2008 07:05:42 +0000 (07:05 +0000)]
wfInvoke documentation fix
David McCabe [Wed, 17 Dec 2008 07:00:18 +0000 (07:00 +0000)]
Factored wfInvoke out of wfRunHooks. This time without breakage. (I think.)
Aaron Schulz [Wed, 17 Dec 2008 01:35:40 +0000 (01:35 +0000)]
Add fragment to nav links to set location
Danny B [Wed, 17 Dec 2008 01:18:47 +0000 (01:18 +0000)]
* footer separator fix per tools.ietf.org/html/rfc3676#section-4.3
Brion Vibber [Wed, 17 Dec 2008 00:05:55 +0000 (00:05 +0000)]
Reverting r44681 "Throw in quick hack $wgRateLimitsExcludedIPs so we don't have to do a live hack every time somebody runs an exciting event where they're going to register a lot of accounts."
r44592 (bug 7492) seems to cover this case with an extension to autopromote settings. Future on-wiki stuff still would be nice...
Andrew Garrett [Wed, 17 Dec 2008 00:00:55 +0000 (00:00 +0000)]
Fix broken and double escaping in r44657.
Brion Vibber [Tue, 16 Dec 2008 23:57:21 +0000 (23:57 +0000)]
Cleanup r44683 -- fix E_NOTICE bug in MWNamespace::getCanonicalName() instead of replicating the function. :)
(Also note -- using MWNamespace instead of Namespace for PHP 5.3 compat.)
Siebrand Mazeland [Tue, 16 Dec 2008 22:56:38 +0000 (22:56 +0000)]
Localisation updates from Betawiki
Siebrand Mazeland [Tue, 16 Dec 2008 22:06:25 +0000 (22:06 +0000)]
Localisation updates for core messages from Betawiki (2008-12-16 22:56 CET)
Brion Vibber [Tue, 16 Dec 2008 21:56:44 +0000 (21:56 +0000)]
Update $wgSVGConverters default command lines to send both width and height to ImageMagick convert
Aaron Schulz [Tue, 16 Dec 2008 20:45:03 +0000 (20:45 +0000)]
(bug 16648) 'FlaggedRevs #mw-data-after-content overflows quickbar w/ standard classic skin'
Alex Z [Tue, 16 Dec 2008 19:59:37 +0000 (19:59 +0000)]
Fix for r44676, fix E_NOTICE from having no canonical name associated with a namespace (ns 0), move RELEASE-NOTES entry to API section and clarify.
Aaron Schulz [Tue, 16 Dec 2008 19:20:35 +0000 (19:20 +0000)]
*Add missing 'reblock' check and message setting
*Move right checks to typeAction to make the code prettier
Brion Vibber [Tue, 16 Dec 2008 18:43:42 +0000 (18:43 +0000)]
Throw in quick hack $wgRateLimitsExcludedIPs so we don't have to do a live hack
every time somebody runs an exciting event where they're going to register
a lot of accounts.
Should be killed and replaced with an on-wiki system for approvals or temporary lifting of limits as a sort of anti-block.
Alexandre Emsenhuber [Tue, 16 Dec 2008 17:26:36 +0000 (17:26 +0000)]
und -> and ;)
Alexandre Emsenhuber [Tue, 16 Dec 2008 17:21:42 +0000 (17:21 +0000)]
Use wfGetLangObj()
X! [Tue, 16 Dec 2008 17:19:05 +0000 (17:19 +0000)]
* (bug 16672) Add canonical parameter to meta=siteinfo&siprop=namespaces|namespacealiases.
Chad Horohoe [Tue, 16 Dec 2008 14:07:58 +0000 (14:07 +0000)]
Add two new XML methods for building tables (buildTable and buildTableRow). Accepts associative arrays where the key is the row/cell id and the value is its value. Non-string keys are skipped.
Raimond Spekking [Tue, 16 Dec 2008 13:03:19 +0000 (13:03 +0000)]
Follow up for r44669: simplfy code. Thanks to IAlex and Nikerabbit
Raimond Spekking [Tue, 16 Dec 2008 12:42:53 +0000 (12:42 +0000)]
* Add PLURAL support for 'undeletepagetext'
* Remove commented out line
* Add a space between input field and submit button
Alexandre Emsenhuber [Tue, 16 Dec 2008 11:41:51 +0000 (11:41 +0000)]
Fix for r44657: correct usage of SpecialPage::getTitleFor()
Siebrand Mazeland [Tue, 16 Dec 2008 08:54:42 +0000 (08:54 +0000)]
Fix syntax errors in r44658.
Siebrand Mazeland [Tue, 16 Dec 2008 08:53:41 +0000 (08:53 +0000)]
(bug 16663) Update namespace aliases for 'mg'. Adding them was omitted in r43599. Namespace aliases have been added based on r43633 of MessagesFr.php.
Raimond Spekking [Tue, 16 Dec 2008 08:51:56 +0000 (08:51 +0000)]
* Add a 'change block' link to Special:IPBlockList und Special:Log
Aaron Schulz [Tue, 16 Dec 2008 06:26:14 +0000 (06:26 +0000)]
Typo
Brion Vibber [Tue, 16 Dec 2008 05:45:28 +0000 (05:45 +0000)]
Follow-up to r44651 -- stay in floats until we finish the SVG size, so aspect ratios in silly tiny units are preserved better.
Brion Vibber [Tue, 16 Dec 2008 05:39:11 +0000 (05:39 +0000)]
* (bug 3691) Aspect ratio from viewBox attribute is now preserved for SVG
images which do not specify width and height attributes.
Examples from bugs:
http://commons.wikimedia.org/wiki/Image:Gcj.svg
http://commons.wikimedia.org/wiki/File:Providence_Metro_Area.svg
Ilmari Karonen [Tue, 16 Dec 2008 04:25:22 +0000 (04:25 +0000)]
(bug 16632) Make updateArticleCount.inc.php use COUNT instead of numRows(), as suggested by Sean Colombo.
Ilmari Karonen [Tue, 16 Dec 2008 02:33:38 +0000 (02:33 +0000)]
Followup to r44641: Only skip file pages that actually have a corresponding file.
Ilmari Karonen [Tue, 16 Dec 2008 00:34:38 +0000 (00:34 +0000)]
Make cleanupTitles.php skip file pages (a bit late to fix that now, but oh well...)
Aaron Schulz [Mon, 15 Dec 2008 23:51:28 +0000 (23:51 +0000)]
Fix bug where new image uploads would be reviewed but had "changes needing review" tag
Brion Vibber [Mon, 15 Dec 2008 23:37:36 +0000 (23:37 +0000)]
* (bug 16656) cleanupTitles and friends should now work in load-balanced DB environments when $wgDBserver isn't set.
Lots of cleanup scripts are based on the FiveUpgrade class created for the 1.5 schema upgrade -- this provides a utility class designed around pulling data from a second, unbuffered connection, processing it, and stuffing it into a master connection.
Originally, both connections were created by manually instantiating the Database class. This worked as long as $wgDBserver was set, but at some point we apparently stopped setting it in our fancy-ass load-balanced environment where we're exclusively using the $wgDBservers array.
As a result, the connections used the default $wgDBserver of 'localhost' which inconveniently fails on Wikimedia's servers. ;)
Now uses the Tim-approved method of getting a new database connection -- creates a new LoadBalancer via wfGetLBFactory()->newMainLB(), then asks it for a fresh connection.
Raimond Spekking [Mon, 15 Dec 2008 22:26:50 +0000 (22:26 +0000)]
Add a descriptive message for rows/cols of Special:Preferences#Editing
Aaron Schulz [Mon, 15 Dec 2008 22:22:21 +0000 (22:22 +0000)]
Add getGeneralShortDesc() and the like to avoid E_STRICT instead
Aaron Schulz [Mon, 15 Dec 2008 22:02:01 +0000 (22:02 +0000)]
use ImagePage, break line
Aaron Schulz [Mon, 15 Dec 2008 21:38:04 +0000 (21:38 +0000)]
E_STRICT
Brion Vibber [Mon, 15 Dec 2008 19:48:54 +0000 (19:48 +0000)]
* (bug 16638) 8-bit URL fallback encoding now set on additional languages using
Arabic script (Persian, Urdu, Sindhi, Punjabi)
Aaron Schulz [Mon, 15 Dec 2008 19:43:47 +0000 (19:43 +0000)]
*Fix XHTML
*Document some arguments
*Minor code style cleanup
Rotem Liss [Mon, 15 Dec 2008 16:11:53 +0000 (16:11 +0000)]
Localization update for he + whitespace fixes.
Chad Horohoe [Mon, 15 Dec 2008 15:47:42 +0000 (15:47 +0000)]
Tweak the wording in 'immobile-target-namespace-iw'. Still feels a bit weird, but it's better :) Also dropped now unnecessary $1 for interwiki prefix.
Chad Horohoe [Mon, 15 Dec 2008 14:48:46 +0000 (14:48 +0000)]
bug 15849 - Trying to move a page onto an interwiki page produces an inappropriate error.
Purodha B Blissenbach [Mon, 15 Dec 2008 14:32:28 +0000 (14:32 +0000)]
Ridiculous message amended.
"ISBN number" meant "international standard book number number" :-D
Andrew Garrett [Mon, 15 Dec 2008 12:10:41 +0000 (12:10 +0000)]
Do initialiseRange into Block::insert.
Fix related fatal in Abuse Filter.
Siebrand Mazeland [Mon, 15 Dec 2008 09:07:25 +0000 (09:07 +0000)]
Localisation updates for core messages from Betawiki (2008-15-10 09:48 CET)
Chad Horohoe [Sun, 14 Dec 2008 22:06:32 +0000 (22:06 +0000)]
Support extension information in meta=siteinfo.
Aaron Schulz [Sun, 14 Dec 2008 21:47:59 +0000 (21:47 +0000)]
* Rewrite query the new way. Should make bug 16636 easier.
* Remove commented out code
* Break long lines
Chad Horohoe [Sun, 14 Dec 2008 20:49:19 +0000 (20:49 +0000)]
(bug 7492) Allow assignment of rights to specific IPs/ranges
Roan Kattouw [Sun, 14 Dec 2008 20:24:23 +0000 (20:24 +0000)]
API: (bug 16647) list=allcategories, prop=categories don't return "hidden" property for hidden categories. Patch by Brad Jorsch
Chad Horohoe [Sun, 14 Dec 2008 19:14:21 +0000 (19:14 +0000)]
War on wfElement() and friends. Call the Xml members directly, rather than using old wrappers.
Alexandre Emsenhuber [Sun, 14 Dec 2008 18:41:30 +0000 (18:41 +0000)]
* removed useless check for $wgAllowUserSkin since we're already checked for it 18 lines above
* wfHidden() -> Xml::hidden()
Roan Kattouw [Sun, 14 Dec 2008 17:44:13 +0000 (17:44 +0000)]
Follow-up to r44584: finishing comment.
Roan Kattouw [Sun, 14 Dec 2008 17:39:50 +0000 (17:39 +0000)]
API: (bug 15579) clshow considers all categories !hidden. Modified patch by Brad Jorsch
Roan Kattouw [Sun, 14 Dec 2008 17:04:24 +0000 (17:04 +0000)]
API: (bug 16549) Kill a filesort in list=allpages&apfilterlanglinks=withlanglinks by replacing DISTINCT with GROUP BY. Of course GROUP BY page_namespace, page_title would suffice on MySQL, but Postgres will reportedly whine about that being against the SQL standard. Using GROUP BY on all selected fields instead (should please pgsql) and taking care that page_namespace, page_title is on front, which shouldn't cause a filesort is MySQL is smart enough (5.0 is, let's just hope 4.1 is too)
Roan Kattouw [Sun, 14 Dec 2008 15:50:40 +0000 (15:50 +0000)]
API: Fix broken block expiry calculation in list=recentchanges
Rotem Liss [Sun, 14 Dec 2008 15:14:38 +0000 (15:14 +0000)]
Localization fix.
Ilmari Karonen [Sun, 14 Dec 2008 10:11:53 +0000 (10:11 +0000)]
better parser test coverage of {{ns:}}
Siebrand Mazeland [Sun, 14 Dec 2008 09:45:33 +0000 (09:45 +0000)]
Localisation updates for core messages from Betawiki (2008-14-10 10:36 CET)
Ilmari Karonen [Sun, 14 Dec 2008 07:38:16 +0000 (07:38 +0000)]
Fix regression in parserTests.inc caused by r44560.
Aaron Schulz [Sun, 14 Dec 2008 07:12:03 +0000 (07:12 +0000)]
Remove comment
Aaron Schulz [Sun, 14 Dec 2008 07:10:42 +0000 (07:10 +0000)]
(bug 12645) File histories should be paged
Chad Horohoe [Sun, 14 Dec 2008 07:02:44 +0000 (07:02 +0000)]
Add some sanity checking. Return nicely if Http::get fails (in general) on fetchImageQuery(), and also if our query returns poorly in findBySha1(), similar to queryImage().
Aaron Schulz [Sun, 14 Dec 2008 07:02:38 +0000 (07:02 +0000)]
Expand ASC condition as it should be
Chad Horohoe [Sun, 14 Dec 2008 06:55:21 +0000 (06:55 +0000)]
FindBySha1 now works in ForeignApiRepo :)
Ilmari Karonen [Sun, 14 Dec 2008 05:47:48 +0000 (05:47 +0000)]
Add a new FileCache class to wrap RepoGroup::findFile() and findFiles(), and make wfFindFile() use it by default. This should improve performance for pages that refer to the same image several times, but the real benefit is that it allows batch file existence checks, à la LinkBatch, by collecting a set of titles (or DB keys) and calling FileCache::findFiles() on them to prefill the cache.
XXX: The code seems to more or less work, but it obviously needs more testing, regarding both stability and memory usage. In particular, I have not tested file uploads yet -- there may be consistency issues there.
Aaron Schulz [Sun, 14 Dec 2008 03:53:05 +0000 (03:53 +0000)]
Make boundary inclusion optional in getHistory()
Ilmari Karonen [Sun, 14 Dec 2008 03:43:10 +0000 (03:43 +0000)]
Followup to r44525: remove the broken $flags parameter from RepoGroup::findFiles() too.
Aaron Schulz [Sun, 14 Dec 2008 00:13:16 +0000 (00:13 +0000)]
Tweak comment
Ilmari Karonen [Sat, 13 Dec 2008 22:45:18 +0000 (22:45 +0000)]
(bug 16635) Add TOC to Special:Watchlist/edit
Chad Horohoe [Sat, 13 Dec 2008 21:36:28 +0000 (21:36 +0000)]
Add a bit in RELEASE-NOTES about what prompted me to play with the installer: bug 16293, change the PD URL to point at Creative Commons.
Chad Horohoe [Sat, 13 Dec 2008 21:34:11 +0000 (21:34 +0000)]
GFDL 1.3 is out, need to update the installer appropriately.
* GFDL 1.2 now links to 1.2, instead of 1.3
* 1.3 has been added as an option, 1.2 still Wikipedia-compatible
* The rights codes were tweaked a bit (see RELEASE-NOTES)
Ilmari Karonen [Sat, 13 Dec 2008 21:21:40 +0000 (21:21 +0000)]
(Actually, we can simplify that a bit more.)
Ilmari Karonen [Sat, 13 Dec 2008 21:14:50 +0000 (21:14 +0000)]
Fix interwiki link regression from r44524.
Alex Z [Sat, 13 Dec 2008 21:07:18 +0000 (21:07 +0000)]
* (bug 16626) action=delete now correctly handles empty "reason" param
Aaron Schulz [Sat, 13 Dec 2008 19:38:34 +0000 (19:38 +0000)]
Make getHistory() a bit more paging friendly
Aaron Schulz [Sat, 13 Dec 2008 19:03:15 +0000 (19:03 +0000)]
*sigh* Forgot db->timestamp
Aaron Schulz [Sat, 13 Dec 2008 15:26:19 +0000 (15:26 +0000)]
Tweak r44534: simplify this
Aaron Schulz [Sat, 13 Dec 2008 14:59:08 +0000 (14:59 +0000)]
Tweak timestamp handling to allow no lower limit
Rotem Liss [Sat, 13 Dec 2008 14:44:44 +0000 (14:44 +0000)]
Localization update for he, and whitespace fixes.
Raimond Spekking [Sat, 13 Dec 2008 13:00:10 +0000 (13:00 +0000)]
Follow up r44528: Bump $wgStyleVersion
Raimond Spekking [Sat, 13 Dec 2008 12:43:21 +0000 (12:43 +0000)]
Follow up r44514: Add new message to messages.inc
Ilmari Karonen [Sat, 13 Dec 2008 08:49:16 +0000 (08:49 +0000)]
(bug 1941) Add textarea { font-family: monospace; } to shared.css for Safari
Ryan Schmidt [Sat, 13 Dec 2008 05:02:26 +0000 (05:02 +0000)]
* (bug 16623) Add missing </p> tag in Special:LockDB -- patch by Nakon
Ilmari Karonen [Sat, 13 Dec 2008 04:40:25 +0000 (04:40 +0000)]
Remove it from the comments too. (Who reads those, anyway?)
Ilmari Karonen [Sat, 13 Dec 2008 04:35:48 +0000 (04:35 +0000)]
Remove parameter from FileRepo::findFiles(), it was fubar and nobody was using it anyway. (What we really need is some way to pass timestamps to that function, which probably requires further rethinking of the interface.)
Ilmari Karonen [Sat, 13 Dec 2008 04:14:40 +0000 (04:14 +0000)]
followup to r44520: simplify various bits by removing checks now made redundant
Ilmari Karonen [Sat, 13 Dec 2008 02:40:53 +0000 (02:40 +0000)]
(bug 5506) Make Title::isAlwaysKnown() return true for known special pages and files in foreign repos.
Besides fixing the display of the latter in logs, edit summaries and other places relying on Linker::link(),
the change should allow considerable simplification (not included in this commit) of that function, as
well as of several related functions e.g. in the Parser and Skin classes. To that end, I've also introduced
a new function Title::isKnown() to wrap the common condition "$title->exists() || $title->isAlwaysKnown()",
and have clarified the roles of the three methods.
Chad Horohoe [Sat, 13 Dec 2008 01:53:18 +0000 (01:53 +0000)]
Need to define $text
Chad Horohoe [Sat, 13 Dec 2008 01:45:49 +0000 (01:45 +0000)]
Complete rewrite of Special:Statistics:
* Now subclasses SpecialPage like it should
* All of the individual sections were split off into their own methods for readability
* Fixed Brion's comments on code review (r44509): not using <small> in the message, breaking to a new line, and keeping the description message separate
* Since -tooltip is a misleading name for the message, I renamed them to -desc, all message files and messages.inc have been updated
Brion Vibber [Fri, 12 Dec 2008 23:59:15 +0000 (23:59 +0000)]
* (bug 2391) A warning is now shown for invalid ISBN numbers on Special:Booksources.
This could be called from the parser as well, but I'm a little hesitant just yet.
Parser tests currently contain some bogus ISBN numbers which need to be replaced with
legit ones... there's also the possibility that some books really are published with
bad ISBNs... on the other hand, Amazon won't let you search for them. :)
Plus the feedback as you're hitting preview might be nice... but it's also not clear
what's wrong -- that is, that it's an invalid number rather than that you just didn't
do something right. Do we want better feedback?
Brion Vibber [Fri, 12 Dec 2008 23:57:18 +0000 (23:57 +0000)]
remove no longer needed line for Parser_OldPP (now banished!)
Chad Horohoe [Fri, 12 Dec 2008 18:29:33 +0000 (18:29 +0000)]
Remove these tooltips in favor of actually putting the information inline.
Alexandre Emsenhuber [Fri, 12 Dec 2008 18:21:35 +0000 (18:21 +0000)]
Manual exporting namespaces aliases from Betawiki (bug 44: renaming of Image namespace to File)
Only added alias for "Discussion Image" (Image talk) since the name of the "Image" namespace is the same in English and French and the alias is already present
Alexandre Emsenhuber [Fri, 12 Dec 2008 17:31:06 +0000 (17:31 +0000)]
svn:eol-style native
Tim Starling [Fri, 12 Dec 2008 15:06:35 +0000 (15:06 +0000)]
Moved the IE content type checks to their own class. Disassembled IE 5 and 6 and added the results to the class. The entry points now return an array giving MIME types for all versions. The most important version difference is the introduction of an early check for PNG headers in IE 7. Added application/x-msdownload to disallowed types, haven't been able to reproduce any vulnerability, but it's better to be on the safe side.
Rotem Liss [Fri, 12 Dec 2008 14:10:03 +0000 (14:10 +0000)]
Localization update.
Rotem Liss [Fri, 12 Dec 2008 14:07:23 +0000 (14:07 +0000)]
Localization update.
Raimond Spekking [Fri, 12 Dec 2008 14:06:30 +0000 (14:06 +0000)]
Quick hack to disable import for non privileged users. Prolly a regression from r43963