Brion Vibber [Tue, 23 Aug 2011 17:58:18 +0000 (17:58 +0000)]
Followup r95262 - remove bogus test cases that seemed to be trying to test the browser's HTML fragment parser. :)
These test cases attempted, I think, to be bogus forced-fail cases, but the fail-forcing doesn't work because HTML 5 parsing in modern browsers parses the text into... the same as the actual expected text! :)
Resolves bug 30520.
Thomas Gries [Tue, 23 Aug 2011 07:28:57 +0000 (07:28 +0000)]
jquery.highlightText.js : test cases for French added
Ariel Glenn [Tue, 23 Aug 2011 00:36:15 +0000 (00:36 +0000)]
fix timestamp stuff, more fallout from bad merge attempt
Ariel Glenn [Tue, 23 Aug 2011 00:04:45 +0000 (00:04 +0000)]
fix a couple bad lines in previous commit from bad merge attempt
Ariel Glenn [Mon, 22 Aug 2011 22:45:22 +0000 (22:45 +0000)]
add support for writing out checkpoint files of xml dump at regular intervals (close and rename file based on filename pattern which includes first and last page id written)
Thomas Gries [Mon, 22 Aug 2011 22:15:43 +0000 (22:15 +0000)]
follow up to r94807 : more test cases incl. hebrew RTL and Japanese, the test cases 100 and 101 have been intentionally added with wrong expected result. It shows that the current qunit software may have problems with wrong double closing span tags. test cases 100 and 101 fail *correctly* on internet explorer 8.0, but with Firefox 6.0 and Chrome no errors are detected --- false negative with Firefox and Chrome and maybe other browsers
Ariel Glenn [Mon, 22 Aug 2011 22:01:32 +0000 (22:01 +0000)]
add functions that support close and rename of output files as they are being written, used to write out checkpoint files at regular intervals during XML dump production
Raimond Spekking [Mon, 22 Aug 2011 19:04:31 +0000 (19:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Mon, 22 Aug 2011 18:32:48 +0000 (18:32 +0000)]
Use local context instead of global variables
Niklas Laxström [Mon, 22 Aug 2011 08:12:10 +0000 (08:12 +0000)]
Make the language recaching non-recursive and load the data directly.
This might be a bit slower, but avoids problems with cyclic language fallbacks.
Followup r94907
Raimond Spekking [Sun, 21 Aug 2011 19:37:43 +0000 (19:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Brian Wolff [Sun, 21 Aug 2011 19:28:35 +0000 (19:28 +0000)]
follow-up r95171 - add unit test for tracking categories.
Brian Wolff [Sun, 21 Aug 2011 18:46:01 +0000 (18:46 +0000)]
Follow-up r86534 - Do not add tracking categories if we're looking at a special page.
Thank you Nikerabbit for suggesting how to fix.
Daniel Friesen [Sun, 21 Aug 2011 18:23:59 +0000 (18:23 +0000)]
Remove the * {{msg}} syntax introduced to MediaWiki:Sidebar in r66974. This syntax is in the way of projects attempting to use a more flexible sidebar-like message parser, or fixing the dependence on MediaWiki:Sidebar for sidebar config. Eliminating it before people end up using it in production (from my tests it never actually worked in 1.17).
Raimond Spekking [Sun, 21 Aug 2011 18:15:37 +0000 (18:15 +0000)]
fu r95152: remove debug line.
Brian Wolff [Sun, 21 Aug 2011 18:05:34 +0000 (18:05 +0000)]
(follow-up r86169) Moar unit-tests!! (sorry for uttetly huge commit)
This should be my last commit of unit tests for the media metadata stuff (hopefully).
Brian Wolff [Sun, 21 Aug 2011 17:16:57 +0000 (17:16 +0000)]
follow-up r86169 - 2 minor issues found while writing unit tests
# Some really obscure Exif properties did not have the Exif byte order taken into account
and were being extracted with the bytes reversed (for example user comment when encoded as utf-16).
Not a major issue as these properties are very rare in practise, but certainly not a good thing.
( One would think php's exif support would take care of that, but no it does not...)
# Change the fallback encoding for Gif comments to be windows-1252 instead of iso 8859-1. More
to be consitent with jpg and iptc then anything else.
Raimond Spekking [Sun, 21 Aug 2011 16:38:02 +0000 (16:38 +0000)]
New hook point to exempt an IP address from the account creation throttle. Redo of r95041 per Niklas CR
Needed for a new extension to make (mass) account creation easier for schools/colleges etc
Sam Reed [Sun, 21 Aug 2011 15:24:44 +0000 (15:24 +0000)]
Add in \n from/to r95055 to LoadBalancer.php
Differentiate error messages from r95050 per Hashar
Raimond Spekking [Sat, 20 Aug 2011 20:54:50 +0000 (20:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sat, 20 Aug 2011 20:12:46 +0000 (20:12 +0000)]
Use local context instead of global variables
Raimond Spekking [Sat, 20 Aug 2011 18:07:48 +0000 (18:07 +0000)]
Self revert r95041 per CR. I will commit a cleaner patch.
Roan Kattouw [Sat, 20 Aug 2011 12:47:17 +0000 (12:47 +0000)]
Fix typo
Roan Kattouw [Sat, 20 Aug 2011 10:41:44 +0000 (10:41 +0000)]
Followup r95072: add tests for wfMatchesDomainList
Roan Kattouw [Sat, 20 Aug 2011 10:25:38 +0000 (10:25 +0000)]
Fix serious bug in r90849 that didn't show up in the tests until I restructured the code a bit and the tests started to actually hit it: $url is undefined, use $href
Roan Kattouw [Sat, 20 Aug 2011 10:18:09 +0000 (10:18 +0000)]
Per r90849, factor out most of the code that's duplicated between Parser::getExternalLinkAttribs() and Skin::addToSidebarPlain() into wfMatchesDomainList(). Change a loose comparison to a strict one, and add a FIXME comment about how whitelisting nl.wikipedia.org also whitelists nds-nl.wikipedia.org due to the function's simplistic substring approach.
Roan Kattouw [Sat, 20 Aug 2011 09:59:00 +0000 (09:59 +0000)]
Per CR on r90915, fix the description of one of the assertions
Roan Kattouw [Sat, 20 Aug 2011 07:19:10 +0000 (07:19 +0000)]
Revert r95058 (make letype multivalue): has been applied before in r88722 and reverted in r89348.
Sam Reed [Fri, 19 Aug 2011 23:30:12 +0000 (23:30 +0000)]
Couple more pieces of wikia upstreaming
Sam Reed [Fri, 19 Aug 2011 23:21:34 +0000 (23:21 +0000)]
Upstream wikia change
Make type multi
Sam Reed [Fri, 19 Aug 2011 23:19:26 +0000 (23:19 +0000)]
Upstream wikia changes
Sam Reed [Fri, 19 Aug 2011 23:12:46 +0000 (23:12 +0000)]
Swap from NS_MAIN to use MWNamespace::getContentNamespaces()
Sam Reed [Fri, 19 Aug 2011 23:11:12 +0000 (23:11 +0000)]
Use MWNamespace::getContentNamespaces() (instead of $wgContentNamespaces) like the rest of the Special pages seem to
Sam Reed [Fri, 19 Aug 2011 23:06:54 +0000 (23:06 +0000)]
Incorporate Wikia diff, don't duplicate debugging though, add the info to the debug call that already exists
Raimond Spekking [Fri, 19 Aug 2011 20:58:32 +0000 (20:58 +0000)]
Fix a typo
Raimond Spekking [Fri, 19 Aug 2011 20:57:41 +0000 (20:57 +0000)]
New hook point to change $wgAccountCreationThrottle
Needed for a new extension to make (mass) account creation easier for schools/colleges etc
Raimond Spekking [Fri, 19 Aug 2011 20:01:08 +0000 (20:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Max Semenik [Fri, 19 Aug 2011 18:27:35 +0000 (18:27 +0000)]
Don't check for each database's availability twice. This halves the number of ugly message boxes seen during CLI installation on Windows if Oracle is not installed, but its bindings for PHP are.
Sam Reed [Fri, 19 Aug 2011 17:54:42 +0000 (17:54 +0000)]
Remove duplicate patch contributors section from CREDITS added in r92528
Roan Kattouw [Fri, 19 Aug 2011 17:33:41 +0000 (17:33 +0000)]
Use canonical URLs in sitemaps, diff stuff and external edit stuff
Roan Kattouw [Fri, 19 Aug 2011 17:31:40 +0000 (17:31 +0000)]
Expand some more URLs: for feeds, referers and the proxy script
Roan Kattouw [Fri, 19 Aug 2011 17:20:35 +0000 (17:20 +0000)]
Use getInternalUrl() instead of getFullUrl() in purgeList.php . This was potentially a serious bug if $wgServer differed from $wgInternalServer in command-line mode (this is not the case on WMF, but might be the case on 3rd-party installs)
Roan Kattouw [Fri, 19 Aug 2011 15:56:59 +0000 (15:56 +0000)]
Use wfParseUrl() instead of parse_url() in interwiki search code: the latter can throw PHP warnings and is totally broken for protocol-relative URLs. Also remove the last usage in core of key_exists(), a deprecated alias for array_key_exists()
Roan Kattouw [Fri, 19 Aug 2011 15:46:08 +0000 (15:46 +0000)]
Make the PROTO_ parameter to wfExpandUrl() explicit in all calls. There are now no calls to wfExpandUrl() in core that rely on PROTO_CURRENT being the default. Also switch to using getCanonicalUrl() for.... rel="canonical" :D (I picked the right name, I KNEW IT)
Roan Kattouw [Fri, 19 Aug 2011 15:27:49 +0000 (15:27 +0000)]
* Introduce File::getCanonicalUrl()
* Make File::getFullUrl() use PROTO_RELATIVE for consistency with other methods named getFullUrl() and to prevent cache pollution
* Use canonical URLs in Export.php
Roan Kattouw [Fri, 19 Aug 2011 15:25:50 +0000 (15:25 +0000)]
Add a PROTO_CANONICAL mode to wfExpandUrl(), which uses $wgCanonicalServer
Roan Kattouw [Fri, 19 Aug 2011 14:46:03 +0000 (14:46 +0000)]
Use canonical URLs (introduced in r94995) for all URLs in e-mails
Roan Kattouw [Fri, 19 Aug 2011 14:41:35 +0000 (14:41 +0000)]
Make $wgVaryOnXFPForAPI apply to RSS/Atom feeds too, because they too use PROT_CURRENT. Make PROT_CURRENT usage explicit there too
Roan Kattouw [Fri, 19 Aug 2011 14:39:37 +0000 (14:39 +0000)]
Use canonical URLs (introduced in r94995) in the OpenSearch discovery thingy
Roan Kattouw [Fri, 19 Aug 2011 14:05:00 +0000 (14:05 +0000)]
Followup r94995: add hooks.txt entries for the new hooks
Roan Kattouw [Fri, 19 Aug 2011 13:25:43 +0000 (13:25 +0000)]
Reverse a bad decision in r93820, which added a comment to WebRequest::getFullRequestURL() saying it would return protocol-relative URLs if $wgServer is protocol-relative. This behavior makes no sense, though, and most callers expect fully qualified URLs. So make it return a fully qualified URL and update the one caller that expected the return value would be compatible with getFullURL()
Roan Kattouw [Fri, 19 Aug 2011 11:23:17 +0000 (11:23 +0000)]
Per CR on r44412 and my promise in the commit summary of r94990, stop abusing $wgInternalServer (intended for Squid URLs) for IRC/e-mail URLs and introduce $wgCanonicalServer for these purposes instead. This revision introduces two new hooks for WMF hacks, in exchange for making the core code saner.
* Introduce $wgCanonicalServer, which should typically be a fully qualified version of $wgServer but in practice can be anything that you'd like to be used in IRC/e-mail notifs
** Default value is $wgServer, expanded to http:// if protocol-relative
** This means you can easily set HTTPS as the 'default' protocol to use in IRC and e-mail notifs by setting $wgCanonicalServer to https://example.com
* Introduce Title::getCanonicalURL(). Similar to getInternalURL(), including a hook for WMF usage (which will be needed as long as secure.wikimedia.org is used)
** Also add escapeCanonicalURL(). Due to some ridiculous accident of history, the other escapeFooURL() functions don't have a $variant parameter; I decided not to follow that bad example
* Reinstate the spirit of r44406 and r44412: instead of calling getInternalURL() (or getCanonicalURL()) and regexing the title parameter out, obtain the path to index.php using $wgCanonicalServer . $wgScript and append params to that. Sadly, we need to add a hook here to support the secure server hack for WMF, but that's the price of saner code in this case
* Introduce the {{canonicalurl:}} and {{canonicalurle:}} parser functions, which work just like {{fullurl:}} and {{fullurle:}} except that they use getCanonicalURL() instead of getFullURL()
* Use {{canonicalurl:}} in the enotif_body message, fixing bug 29993 (protocol-relative URLs appear in e-mail notifications)
Niklas Laxström [Fri, 19 Aug 2011 09:02:35 +0000 (09:02 +0000)]
Fu r94907 - also update localisation cache, which accesses the fallback variable directly
Fixes bug 30456
Roan Kattouw [Fri, 19 Aug 2011 08:56:39 +0000 (08:56 +0000)]
Followup r94754: move protocol expansion from getIRCLine() to inside getInternalUrl(); these internal URLs should always be fully qualified. Effectively this means that if $wgServer is protocol-relative and $wgInternalServer either isn't set or is also protocol relative (but it really shouldn't be the latter!), we'll add to URLs used for Squid purging and in IRC lines. If people want those to be https:// instead, they can set $wgInternalServer accordingly.
We should really, really break the connection between internal URLs used for Squid purges and URLs used for IRC, and use the latter in e-mails as well. This was briefly discussed in the CR comments on r44412 and I'll be working on that today.
Sam Reed [Thu, 18 Aug 2011 23:37:04 +0000 (23:37 +0000)]
* (bug 30450) Clear page_props table on page deletion
Also clear them on a move over redirect
Modified delete() calls in doDeleteArticle to pass __METHOD__ for the function name
Ian Baker [Thu, 18 Aug 2011 23:36:24 +0000 (23:36 +0000)]
Two bugs:
1. When the user isn't passed to UploadFromStash::__construct(), it would break when it shouldn't.
2. When stashing files, sometimes an instance of UnregisteredLocalFile would be returned instead of UploadStashFile
Sam Reed [Thu, 18 Aug 2011 23:16:11 +0000 (23:16 +0000)]
* (bug 30451) Add page_props to RefreshLinks::deleteLinksFromNonexistent
Alexandre Emsenhuber [Thu, 18 Aug 2011 21:04:29 +0000 (21:04 +0000)]
Removed mention of AOL, no longer true since r39892
Sam Reed [Thu, 18 Aug 2011 20:56:57 +0000 (20:56 +0000)]
Fix getRequet to getRequest
Raimond Spekking [Thu, 18 Aug 2011 20:35:31 +0000 (20:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Thu, 18 Aug 2011 20:05:09 +0000 (20:05 +0000)]
Removed debugging code from r94932
Alexandre Emsenhuber [Thu, 18 Aug 2011 20:03:30 +0000 (20:03 +0000)]
Moved wfGetIP() to WebRequest::getIP():
* Changed all calls in core to the latter
* Also marked wfGetForwardedFor() as deprecated
* Moved wfGetIP() tests to WebRequestTest
Niklas Laxström [Thu, 18 Aug 2011 16:43:24 +0000 (16:43 +0000)]
* (bug 30217) Make pt-br a fallback of pt
Depends on r94907.
Niklas Laxström [Thu, 18 Aug 2011 16:41:07 +0000 (16:41 +0000)]
Attempt to fix Bug 30216 - Improve language fallback loop detection.
Made fallbacks a list per language, instead of scanning them recursively through the languages.
Marooned [Thu, 18 Aug 2011 10:33:39 +0000 (10:33 +0000)]
Relative values of the "Location" header are incorrect as stated in RFC, however they do happen and modern browsers support them.
This function loops backwards through all locations in order to build the proper absolute URI - Marooned at wikia-inc.com
Raimond Spekking [Thu, 18 Aug 2011 07:49:10 +0000 (07:49 +0000)]
fu r94541: Delete empty files
Brian Wolff [Thu, 18 Aug 2011 06:23:44 +0000 (06:23 +0000)]
Make testBug26425BlockTimestampDefaultsToTime be tolerrant of up to 2 seconds
difference.
Otherwise if the test happens to be run on a second barrier, it could
falsely fail (like it did just now when codur said some hurtful things
about my code failing unit-tests where it really didn't ;)
Some of the other block tests seem to itermitantly fail for no appearent
reason (null comes back instead of the block)... I don't know why.
Brian Wolff [Thu, 18 Aug 2011 05:45:04 +0000 (05:45 +0000)]
follow-up r86169: unit tests for extraction of JPEG comment (COM) segments.
Brian Wolff [Thu, 18 Aug 2011 03:53:53 +0000 (03:53 +0000)]
follow-up r91885 rename testTiffFile since its not about tiff files
This is probably what was referred to in CR, not what I changed in r94825
Sam Reed [Thu, 18 Aug 2011 00:54:06 +0000 (00:54 +0000)]
Upstreaming wikia change to WebRequest
Trim trailing whitespace
Tweak documentation
Brian Wolff [Wed, 17 Aug 2011 23:28:31 +0000 (23:28 +0000)]
Move the image files used in the media tests from includes/media to data/media as the includes/media
was starting to get crowded with supporting image files.
This changes the following things
*Moves the media files to a different directory
*Changes the references to the files to reference there new locations
2 semi-unrelated changes
*Modify the README file that was basically giving credit for the images where due to explain what the images are for.
*set svn:mime-type to image/svg+xml for the svg files.
Robin Pepermans [Wed, 17 Aug 2011 23:21:33 +0000 (23:21 +0000)]
Re-add release note accidentally removed in r94691.
Siebrand Mazeland [Wed, 17 Aug 2011 22:45:28 +0000 (22:45 +0000)]
Follow-up r94836: move RELEASE-NOTES from 1.19 to 1.18.
Sam Reed [Wed, 17 Aug 2011 22:42:49 +0000 (22:42 +0000)]
More wikia upstreaming
Sam Reed [Wed, 17 Aug 2011 22:38:36 +0000 (22:38 +0000)]
Stylize
+upstream Wikia changes
Robin Pepermans [Wed, 17 Aug 2011 22:35:52 +0000 (22:35 +0000)]
Follow-up r94690: correct language name for 'qug' to Kichwa. Kichwa or Northern Quechua covers several language codes including "qug", which is used as a temporary code until they got an official ISO 639 code or IETF tag.
Siebrand Mazeland [Wed, 17 Aug 2011 22:33:01 +0000 (22:33 +0000)]
Follow-up r94690: set fallback to 'qu'.
Sam Reed [Wed, 17 Aug 2011 22:28:08 +0000 (22:28 +0000)]
Upstream another minor Wikia change
Sam Reed [Wed, 17 Aug 2011 22:24:21 +0000 (22:24 +0000)]
Based on diff to wikia, set more functions consistently public rather than protected
Brian Wolff [Wed, 17 Aug 2011 22:09:57 +0000 (22:09 +0000)]
Make the testCleanSig work no matter what $wgCleanSignatures; is in LocalSettings.php . Also have a test for when sig cleaning is disabled.
Brian Wolff [Wed, 17 Aug 2011 21:53:45 +0000 (21:53 +0000)]
follow-up r91885 - address CR comments
* rename testTiffFile to something more descriptive
* unserialize the serialized results before comparing
Also follow-up r92635 - rm an extra wfDl that was outside any functions, and I'm assuming accidentally there (?)
Ian Baker [Wed, 17 Aug 2011 21:38:18 +0000 (21:38 +0000)]
listFiles() returns false when empty. Special:UplaodStash now deals with that correctly
fixes bug 30429
Raimond Spekking [Wed, 17 Aug 2011 20:43:00 +0000 (20:43 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Thomas Gries [Wed, 17 Aug 2011 20:00:44 +0000 (20:00 +0000)]
more test cases for highlighter; all pass the test of course
Sam Reed [Wed, 17 Aug 2011 17:11:49 +0000 (17:11 +0000)]
Documentation
Trim trailing whitespace
Roan Kattouw [Wed, 17 Aug 2011 14:55:06 +0000 (14:55 +0000)]
Followup r94421 which, per CR, broke in non-English content languages because of key mismatches due to localized namespace names. Now ensuring all titles go through getPrefixedDBkey() before we compare them, so they're always normalized. This also ensures we don't get underscore vs. space confusion, which is something that the previous code did right by accident.
Daniel Friesen [Wed, 17 Aug 2011 14:10:41 +0000 (14:10 +0000)]
Followup r80248; Fix inverted message exists tests in ProtectionForm.
Roan Kattouw [Wed, 17 Aug 2011 13:32:45 +0000 (13:32 +0000)]
(bug 30398) Expand any protocol-relative URLs to HTTP in RecentChange::getIRCLine(). This will prevent sending protocol-relative URLs to the IRC feed
Niklas Laxström [Wed, 17 Aug 2011 09:55:09 +0000 (09:55 +0000)]
Self-revert r79892: only got one opposition and apparently too hairy for anyone else to comment :)
Niklas Laxström [Wed, 17 Aug 2011 09:50:54 +0000 (09:50 +0000)]
Amend the documention of search profile, fu r86714
Brian Wolff [Wed, 17 Aug 2011 04:05:11 +0000 (04:05 +0000)]
follow-up r94601 - add unit tests for stripping the File: prefix from upload, and test handling illegal characters in upload title (thing that caused the issue in r94601)
(I have no idea if things like this (unit-tests) should be tagged 1.18, I assume no but am unsure)
Brian Wolff [Wed, 17 Aug 2011 00:46:58 +0000 (00:46 +0000)]
Follow-up r94680 - fix unit tests.
The way the magic variable unit tests are run looks a little sketchy to me...
Daniel Friesen [Wed, 17 Aug 2011 00:41:17 +0000 (00:41 +0000)]
Fix some bad "Implements Special:*" comments in includes/specials/ files.
Siebrand Mazeland [Wed, 17 Aug 2011 00:08:51 +0000 (00:08 +0000)]
Localisation updates from translatewiki.net.
Full rebuild of file.
Brion Vibber [Tue, 16 Aug 2011 22:42:57 +0000 (22:42 +0000)]
Fix a regression in search highlighting from r90092
Followup on r94609, r94681 test cases.
This fixes the test case with a period that was failing; problem was not the period, but the space before.
The changed regex in r90092 ended up including the preceding whitespace in the match, so the position of the match was coming up one character before the actual word -- thus offsetting the highlight by one char.
Changed from search to match, using the regex's index property (same as search returns) and adding in the length of the first match component which covers the space/whatever
Siebrand Mazeland [Tue, 16 Aug 2011 21:30:23 +0000 (21:30 +0000)]
Break lines at or before 80 and update punctuation.
Siebrand Mazeland [Tue, 16 Aug 2011 21:29:39 +0000 (21:29 +0000)]
Add new language Chimborazo Highland Quichua (qug).
Siebrand Mazeland [Tue, 16 Aug 2011 20:54:19 +0000 (20:54 +0000)]
Localisation updates from translatewiki.net.
Brion Vibber [Tue, 16 Aug 2011 19:34:47 +0000 (19:34 +0000)]
Followup r94609: fix jquery.highlightText test cases on IE, simplify test case setup so new ones can be added more trivially, uncommented the failing test case.
These tests were failing on IE 6, 7, and 8 because the innerHTML rendering of the highlighted text came out in caps and without quotes, such that the string didn't match the provided one. By re-normalizing the expected HTML form this check now works on those browsers. Switching common code to a loop and an array makes it easier to add new test cases: less duplication of code, and no need to manually update the number of test cases.
Note that the third test case was previously commented out, but looks like a serious regression. No longer commented out, so this will fail!
Robin Pepermans [Tue, 16 Aug 2011 19:29:52 +0000 (19:29 +0000)]
Magic words (time and number-formatting ones, plus DIRECTIONMARK, but not NAMESPACE) now depend on the page content language instead of the site language. In theory this sets the right magic words in system messages, although they are not used there.
Useful for multilingual wikis like Incubator, and probably for extensions like Translate.