From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sat, 29 Jun 2019 00:33:50 +0000 (-0700)
Subject: filerepo: remove pointless "foreign" flag in ForeignDBRepo::getMasterDB()
X-Git-Tag: 1.34.0-rc.0~1195^2
X-Git-Url: http://git.cyclocoop.org/%7B%7B%20url_for%28%27admin_vote_del%27%2C%20idvote=vote.voteid%29%20%7D%7D?a=commitdiff_plain;h=8f9d373adcae39d85b9530681bb1b6e365e2448f;p=lhc%2Fweb%2Fwiklou.git

filerepo: remove pointless "foreign" flag in ForeignDBRepo::getMasterDB()

This connection handle is not managed by any LoadBalancer, so nothing checks that

Change-Id: Ie60859aacbcccd8439bc58d816c6b94769a4331f
---

diff --git a/includes/filerepo/ForeignDBRepo.php b/includes/filerepo/ForeignDBRepo.php
index 4b331389b7..a44d3edcc1 100644
--- a/includes/filerepo/ForeignDBRepo.php
+++ b/includes/filerepo/ForeignDBRepo.php
@@ -107,8 +107,7 @@ class ForeignDBRepo extends LocalRepo {
 			'password' => $this->dbPassword,
 			'dbname' => $this->dbName,
 			'flags' => $this->dbFlags,
-			'tablePrefix' => $this->tablePrefix,
-			'foreign' => true,
+			'tablePrefix' => $this->tablePrefix
 		];
 
 		return function ( $index ) use ( $type, $params ) {