From: James D. Forrester <jforrester@wikimedia.org>
Date: Fri, 21 Jun 2019 20:56:34 +0000 (-0700)
Subject: Linker::link: Drop support for string query param, deprecated in 1.20
X-Git-Tag: 1.34.0-rc.0~1287^2~6
X-Git-Url: http://git.cyclocoop.org/%7B%7B%20url_for%28%27admin_vote_del%27%2C%20idvote=vote.voteid%29%20%7D%7D?a=commitdiff_plain;h=6b2c6fdf6a284d59476340db100347d7584ef0f0;p=lhc%2Fweb%2Fwiklou.git

Linker::link: Drop support for string query param, deprecated in 1.20

Change-Id: I910cead2c32a3525772ee0640c8ed3b90ad40a84
---

diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34
index 5c0b57e8b7..87068d8ea1 100644
--- a/RELEASE-NOTES-1.34
+++ b/RELEASE-NOTES-1.34
@@ -230,6 +230,8 @@ because of Phabricator reports.
 * OutputPage::wrapWikiMsg() no longer accepts an options parameter. This was
   deprecated since 1.20.
 * Skin::outputPage() no longer accepts a context. This was deprecated in 1.20.
+* Linker::link() no longer accepts a string for the query array, as was
+  deprecated in 1.20.
 * …
 
 === Deprecations in 1.34 ===
diff --git a/includes/Linker.php b/includes/Linker.php
index 39f43946d2..198015466f 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -89,12 +89,6 @@ class Linker {
 			return "<!-- ERROR -->$html";
 		}
 
-		if ( is_string( $query ) ) {
-			// some functions withing core using this still hand over query strings
-			wfDeprecated( __METHOD__ . ' with parameter $query as string (should be array)', '1.20' );
-			$query = wfCgiToArray( $query );
-		}
-
 		$services = MediaWikiServices::getInstance();
 		$options = (array)$options;
 		if ( $options ) {