algorithm very similar to IE's content detection algorithm.
* Cascading protection no longer requires that both edit and move are restricted
to sysop, just edit=sysop is enough
+* (bug 2391) A warning is now shown for invalid ISBN numbers on Special:Booksources.
=== Bug fixes in 1.14 ===
public function execute( $isbn ) {
global $wgOut, $wgRequest;
$this->setHeaders();
- $this->isbn = $this->cleanIsbn( $isbn ? $isbn : $wgRequest->getText( 'isbn' ) );
+ $this->isbn = self::cleanIsbn( $isbn ? $isbn : $wgRequest->getText( 'isbn' ) );
$wgOut->addWikiMsg( 'booksources-summary' );
$wgOut->addHTML( $this->makeForm() );
- if( strlen( $this->isbn ) > 0 )
+ if( strlen( $this->isbn ) > 0 ) {
+ if( !$this->isValidIsbn( $this->isbn ) ) {
+ $wgOut->wrapWikiMsg( '<div class="error">$1</div>', 'booksources-invalid-isbn' );
+ }
$this->showList();
+ }
}
+ /**
+ * Returns whether a given ISBN (10 or 13) is valid. True indicates validity.
+ * @param isbn ISBN passed for check
+ */
+ public static function isValidISBN( $isbn ) {
+ $isbn = self::cleanIsbn( $isbn );
+ $sum = 0;
+ $check = -1;
+ if( strlen( $isbn ) == 13 ) {
+ for( $i = 0; $i < 12; $i++ ) {
+ if($i % 2 == 0) {
+ $sum += $isbn{$i};
+ } else {
+ $sum += 3 * $isbn{$i};
+ }
+ }
+
+ $check = (10 - ($sum % 10)) % 10;
+ if ($check == $isbn{12}) {
+ return true;
+ }
+ } elseif( strlen( $isbn ) == 10 ) {
+ for($i = 0; $i < 9; $i++) {
+ $sum += $isbn{$i} * ($i + 1);
+ }
+
+ $check = $sum % 11;
+ if($check == 10) {
+ $check = "X";
+ }
+ if($check == $isbn{9}) {
+ return true;
+ }
+ }
+ return false;
+ }
+
+
/**
* Trim ISBN and remove characters which aren't required
*
* @param $isbn Unclean ISBN
* @return string
*/
- private function cleanIsbn( $isbn ) {
+ private static function cleanIsbn( $isbn ) {
return trim( preg_replace( '![^0-9X]!', '', $isbn ) );
}
'booksources-isbn' => 'ISBN:', # only translate this message to other languages if you have to change it
'booksources-go' => 'Go',
'booksources-text' => 'Below is a list of links to other sites that sell new and used books, and may also have further information about books you are looking for:',
+'booksources-invalid-isbn' => 'The given ISBN number does not appear to be valid; check for errors copying from the original source.',
# Magic words
'rfcurl' => 'http://tools.ietf.org/html/rfc$1', # do not translate or duplicate this message to other languages