Merge "Use dedicated cookie for skipping CDN cache after initiating DB changes"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 13 Jan 2016 03:16:40 +0000 (03:16 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 13 Jan 2016 03:16:40 +0000 (03:16 +0000)
1  2 
includes/MediaWiki.php

diff --combined includes/MediaWiki.php
@@@ -567,7 -567,9 +567,9 @@@ class MediaWiki 
                $request = $context->getRequest();
                if ( $request->wasPosted() && $factory->hasOrMadeRecentMasterChanges() ) {
                        $expires = time() + $config->get( 'DataCenterUpdateStickTTL' );
-                       $request->response()->setCookie( 'UseDC', 'master', $expires, array( 'prefix' => '' ) );
+                       $options = array( 'prefix' => '' );
+                       $request->response()->setCookie( 'UseDC', 'master', $expires, $options );
+                       $request->response()->setCookie( 'UseCDNCache', 'false', $expires, $options );
                }
  
                // Avoid letting a few seconds of slave lag cause a month of stale data
                if (
                        $request->getProtocol() == 'http' &&
                        (
 +                              $request->getSession()->shouldForceHTTPS() ||
 +                              // Check the cookie manually, for paranoia
                                $request->getCookie( 'forceHTTPS', '' ) ||
 -                              // check for prefixed version for currently logged in users
 +                              // check for prefixed version that was used for a time in older MW versions
                                $request->getCookie( 'forceHTTPS' ) ||
                                // Avoid checking the user and groups unless it's enabled.
                                (