From a97171eaff1c42b5b5b036766b4cbe9cdb80a769 Mon Sep 17 00:00:00 2001 From: Amir Sarabadani Date: Wed, 14 Aug 2019 21:47:06 +0200 Subject: [PATCH] Add drop of mssql/oracle to RELEASE-NOTES Bug: T230418 Change-Id: Ie7771853048a27a8d8ee75764229e6e34477cd04 --- RELEASE-NOTES-1.34 | 2 ++ tests/phpunit/includes/db/LoadBalancerTest.php | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34 index 5e4f61d37a..69a64d01cb 100644 --- a/RELEASE-NOTES-1.34 +++ b/RELEASE-NOTES-1.34 @@ -340,6 +340,8 @@ because of Phabricator reports. * Database::getProperty(), deprecated in 1.28, has been removed. * IDatabase::getWikiId(), deprecated in 1.30, has been removed. Use IDatabase::getDomainID() instead. +* (T191231) Support for using Oracle or MSSQL as database backends has been + dropped. * … === Deprecations in 1.34 === diff --git a/tests/phpunit/includes/db/LoadBalancerTest.php b/tests/phpunit/includes/db/LoadBalancerTest.php index 588fe67e9f..981b4ad717 100644 --- a/tests/phpunit/includes/db/LoadBalancerTest.php +++ b/tests/phpunit/includes/db/LoadBalancerTest.php @@ -341,7 +341,7 @@ class LoadBalancerTest extends MediaWikiTestCase { private function assertWriteAllowed( Database $db ) { $table = $db->tableName( 'some_table' ); // Trigger a transaction so that rollback() will remove all the tables. - // Don't do this for MySQL as they auto-commit transactions for DDL + // Don't do this for MySQL as it auto-commits transactions for DDL // statements such as CREATE TABLE. $useAtomicSection = in_array( $db->getType(), [ 'sqlite', 'postgres' ], true ); try { -- 2.20.1