jenkins-bot [Tue, 19 Nov 2013 21:25:00 +0000 (21:25 +0000)]
Merge "move page_restrictions.pr_id to top in tables.sql"
jenkins-bot [Tue, 19 Nov 2013 21:12:59 +0000 (21:12 +0000)]
Merge "Exclude servers with zero load from lag checks"
jenkins-bot [Tue, 19 Nov 2013 21:10:16 +0000 (21:10 +0000)]
Merge "Consistently handle anonymous users on logged-in-only special pages"
jenkins-bot [Tue, 19 Nov 2013 20:55:06 +0000 (20:55 +0000)]
Merge "Make Special:PasswordReset obey returnto and returntoquery parameters"
jenkins-bot [Tue, 19 Nov 2013 20:52:35 +0000 (20:52 +0000)]
Merge "Add $counter which was defined dynamically"
jenkins-bot [Tue, 19 Nov 2013 20:29:43 +0000 (20:29 +0000)]
Merge "Update formatting"
Translation updater bot [Tue, 19 Nov 2013 20:24:39 +0000 (20:24 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Tue, 19 Nov 2013 20:14:44 +0000 (20:14 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I2ffb4e1f59ad5619ad15b7556c826ff2e206a1be
jenkins-bot [Tue, 19 Nov 2013 20:04:49 +0000 (20:04 +0000)]
Merge "Declare visibility on class properties of RCCacheEntry"
Siebrand Mazeland [Tue, 19 Nov 2013 08:37:41 +0000 (09:37 +0100)]
Add $counter which was defined dynamically
Used in SpecialRecentChanges, ChangesList and SpecialWatchlist to keep
track of line numbers for RC list entries.
Change-Id: Ib0e76a325c36a5c019db8d55c150e3bf3bf1d19b
jenkins-bot [Tue, 19 Nov 2013 19:53:15 +0000 (19:53 +0000)]
Merge "Declare visibility on class properties of RecentChange"
jenkins-bot [Tue, 19 Nov 2013 19:49:57 +0000 (19:49 +0000)]
Merge "Declare visibility on class properties of LinkBatch"
jenkins-bot [Tue, 19 Nov 2013 19:42:16 +0000 (19:42 +0000)]
Merge "Various fixes for ChangesList"
Siebrand Mazeland [Tue, 19 Nov 2013 19:40:50 +0000 (20:40 +0100)]
Update formatting
Change-Id: I5cd038afb609eb71e86b7e23839083cea2531e1a
jenkins-bot [Tue, 19 Nov 2013 19:32:09 +0000 (19:32 +0000)]
Merge "Update documentation for OldChangesList"
jenkins-bot [Tue, 19 Nov 2013 19:29:04 +0000 (19:29 +0000)]
Merge "Remove dead var"
jenkins-bot [Tue, 19 Nov 2013 19:01:58 +0000 (19:01 +0000)]
Merge "API: Add default setting for OpenSearch limit parameter"
Alex Ivanov [Mon, 18 Nov 2013 21:22:07 +0000 (23:22 +0200)]
API: Add default setting for OpenSearch limit parameter
This is done as part of a GCI 2013 task.
Bug: 30089
Change-Id: I4c1a850520976a5b8b433feee4807c5f6960e3ac
jenkins-bot [Tue, 19 Nov 2013 18:34:27 +0000 (18:34 +0000)]
Merge "Sort 'MediaWiki' resources definitions alphabetically"
jenkins-bot [Tue, 19 Nov 2013 18:03:46 +0000 (18:03 +0000)]
Merge "Various fixes for RecentChange"
jenkins-bot [Tue, 19 Nov 2013 17:54:30 +0000 (17:54 +0000)]
Merge "remove specific FORCE INDEX clauses causing trouble"
Sean Pringle [Tue, 19 Nov 2013 09:53:05 +0000 (19:53 +1000)]
remove specific FORCE INDEX clauses causing trouble
bug: 45619
Change-Id: I6b8f35bd8d709ccc8e4811836e7731bcedb5520c
jeroendedauw [Tue, 19 Nov 2013 17:04:11 +0000 (18:04 +0100)]
Remove no longer needed code for PHP 5.2 compat
Change-Id: I9c1f5f12f51274c443084da55447d12b828a9fb0
jeroendedauw [Tue, 19 Nov 2013 17:04:56 +0000 (18:04 +0100)]
Remove dead var
Change-Id: I8063140d1e5ada1487ec1509a244dd410896bbab
Alexandre Emsenhuber [Tue, 19 Nov 2013 13:37:51 +0000 (14:37 +0100)]
Make Special:PasswordReset obey returnto and returntoquery parameters
Bug: 57098
Change-Id: I27b31bfa23d94cd45a70b3c7c091938e3b83e671
Siebrand Mazeland [Tue, 19 Nov 2013 07:39:35 +0000 (08:39 +0100)]
Declare visibility on class properties of RecentChange
All are referenced directly outside inheritence; declare all public.
Removed unused $mMovedToTitle.
Change-Id: I3ba8f377e1a1082d3a2bb4b043e10bc351c0b5dd
Siebrand Mazeland [Tue, 19 Nov 2013 12:23:46 +0000 (13:23 +0100)]
Various fixes for ChangesList
* Define dynamic class properties
* Update documentation and doc formatting
* Ensure variables are defined
Change-Id: I309affea9a8e8cfa24bd8fe694a16bf79d6f2419
Siebrand Mazeland [Tue, 19 Nov 2013 12:28:18 +0000 (13:28 +0100)]
Update documentation for OldChangesList
Change-Id: Ied9ec5219ff7b458a69c6d989b813dffa1583cd3
Siebrand Mazeland [Tue, 19 Nov 2013 12:29:45 +0000 (13:29 +0100)]
Various fixes for RecentChange
* Do not return the value of a function that returns void
* Update documentation
Change-Id: I2b25bf34f578be516a19c84d45860ab6c7f93e0e
jenkins-bot [Tue, 19 Nov 2013 11:17:47 +0000 (11:17 +0000)]
Merge "Adding hlist module to mediawiki"
Bartosz Dziewoński [Sat, 12 Oct 2013 17:00:23 +0000 (19:00 +0200)]
Consistently handle anonymous users on logged-in-only special pages
Added new helper function SpecialPage#requireLogin() to check if the
current user is logged in and, if not, format an error message linking
to Special:Userlogin and throw UserNotLoggedIn exception, to be
handled by OutputPage later.
Reused old error messages. Not all use the new parameter and they're
very inconsistent, but this is a matter for another patch.
Used it on 7 special pages. I don't think there are any other ones
which specifically require having an account, instead of just some
rights usually associated with logged-in users.
* SpecialChangeEmail
* SpecialChangePassword: It allows anonymous users under specific
circumstances, but is logged-in-only in general.
* SpecialConfirmemail
* SpecialEditWatchlist
* SpecialPreferences
* SpecialResetTokens: It was missing the check, added it.
* SpecialWatchlist
Change-Id: I43ceaddb370d09784021b3fc2d5d1ff6616fef1f
Siebrand Mazeland [Tue, 19 Nov 2013 07:38:12 +0000 (08:38 +0100)]
Declare visibility on class properties of RCCacheEntry
All are referenced directly outside inheritence; declare all public.
Removed unused $secureName and $versionlink.
Change-Id: If491d0f1cbf4d53692e0ecfd0e1df1f4c3761ca6
jenkins-bot [Tue, 19 Nov 2013 08:40:16 +0000 (08:40 +0000)]
Merge "Remove unused classes Title[List]Dependency"
Siebrand Mazeland [Tue, 19 Nov 2013 08:07:59 +0000 (09:07 +0100)]
Declare visibility on class properties of LinkBatch
Set to public. Usage in for example api/ApiPageSet.php.
Change-Id: I8d6b8a0728a465544b09832b2916235628a21b8e
jenkins-bot [Tue, 19 Nov 2013 06:39:03 +0000 (06:39 +0000)]
Merge "Update formatting"
jenkins-bot [Tue, 19 Nov 2013 06:35:56 +0000 (06:35 +0000)]
Merge "Address CodeSniffer errors and warnings"
Siebrand Mazeland [Mon, 18 Nov 2013 22:07:49 +0000 (23:07 +0100)]
Update formatting
Change-Id: I7586c4d50f7332c515b8377749c4250cc9e04d83
jenkins-bot [Tue, 19 Nov 2013 06:20:43 +0000 (06:20 +0000)]
Merge "Add visibility to Status functions and variables"
aude [Thu, 24 Oct 2013 19:41:51 +0000 (19:41 +0000)]
Add visibility to Status functions and variables
Change-Id: I829a7503693318586e33605d2ac8e2ca63f3c886
jenkins-bot [Tue, 19 Nov 2013 05:32:19 +0000 (05:32 +0000)]
Merge "Move RecentChangeTest to subdirectory"
Siebrand Mazeland [Mon, 18 Nov 2013 22:03:29 +0000 (23:03 +0100)]
Address CodeSniffer errors and warnings
Change-Id: Ie119db7d6d9e9eb3c1cd9c07b8f84fd155847c62
jenkins-bot [Tue, 19 Nov 2013 05:26:56 +0000 (05:26 +0000)]
Merge "Fix indentation of comment in tables.sql"
jenkins-bot [Mon, 18 Nov 2013 23:17:51 +0000 (23:17 +0000)]
Merge "Put status handling in EditPage into private function"
jenkins-bot [Mon, 18 Nov 2013 22:52:46 +0000 (22:52 +0000)]
Merge "mediawiki.ui: Add right padding to .agora-field-styling()"
Bartosz Dziewoński [Mon, 18 Nov 2013 20:31:18 +0000 (21:31 +0100)]
Sort 'MediaWiki' resources definitions alphabetically
A few were out of order.
Change-Id: Id6dfcc3e104a58cc10e8e3452101f0c625309d74
aude [Mon, 18 Nov 2013 21:24:59 +0000 (22:24 +0100)]
Put status handling in EditPage into private function
This bit of code is isolated enough to be separated from
attemptSave and be put into a private function.
Change-Id: I84c532358ee32fec959039c62798e4de0702f14a
mayankmadan [Mon, 18 Nov 2013 19:28:36 +0000 (00:58 +0530)]
Adding hlist module to mediawiki
Bug: 40062
Change-Id: Ie4ac182ce53317654b4cc17b25cfa34596054df7
jenkins-bot [Mon, 18 Nov 2013 21:10:38 +0000 (21:10 +0000)]
Merge "Remove unused global in ForeignAPIRepo"
umherirrender [Mon, 18 Nov 2013 20:49:28 +0000 (21:49 +0100)]
Remove unused global in ForeignAPIRepo
Follow-Up: I6849107a3af773687a31155b23a2d7b4d7a60645
Change-Id: I45d405a4dca9b7928f740fcd231e95c599310689
Raimond Spekking [Mon, 18 Nov 2013 20:46:48 +0000 (20:46 +0000)]
Merge "Localisation updates from translatewiki.net."
Siebrand Mazeland [Mon, 18 Nov 2013 04:31:31 +0000 (05:31 +0100)]
Remove unused classes Title[List]Dependency
Classes TitleListDependency and TitleDependency that are currently not
used. Searched core and extensions in Gerrit.
Change-Id: I51404ce36c4ef55393588817d1673fd17c81b4a2
Translation updater bot [Mon, 18 Nov 2013 20:36:33 +0000 (20:36 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I3615ad83da760c512799749618a35cb2e366ba41
jenkins-bot [Mon, 18 Nov 2013 20:33:37 +0000 (20:33 +0000)]
Merge "Format email addresses more consistently"
Siebrand Mazeland [Sat, 16 Nov 2013 21:22:12 +0000 (22:22 +0100)]
Format email addresses more consistently
Change-Id: I1dbced804ff1e0bf8e162570c17cc537d318872f
Siebrand Mazeland [Sun, 17 Nov 2013 20:42:23 +0000 (21:42 +0100)]
Update LinkCache::addGoodLinkObj param defaults to int
Update the defaults for $revision and $model from bool to int, making it
consistent with the documented input. Also update docs and line length.
Change "inval( $x )" to preferred "(int) $x" while changing the method.
Change-Id: Ic19a408aa7c50fb03e2c3aca8df3fa7cedc2420b
jenkins-bot [Mon, 18 Nov 2013 19:23:36 +0000 (19:23 +0000)]
Merge "Add WikiFilePage::getForeignCategories() method"
jenkins-bot [Mon, 18 Nov 2013 19:18:41 +0000 (19:18 +0000)]
Merge "Tweaked WikiPage::clear() comment a bit"
tgr [Wed, 13 Nov 2013 12:35:25 +0000 (12:35 +0000)]
Add WikiFilePage::getForeignCategories() method
Unlike getCategories(), this will return the categories
on the wiki where the file is hosted (so it should work with Commons).
Bug: 56598
Change-Id: Ice972f023c676b5857707ccf58ee108585a7f021
jenkins-bot [Mon, 18 Nov 2013 19:06:45 +0000 (19:06 +0000)]
Merge "Enable module storage for 0.05% of visitors w/storage-capable browsers"
Aaron Schulz [Sun, 17 Nov 2013 19:40:42 +0000 (11:40 -0800)]
Tweaked WikiPage::clear() comment a bit
Change-Id: I9ec27b575de5547d1ab0569c4c2cdd1307f8307a
jenkins-bot [Mon, 18 Nov 2013 18:58:22 +0000 (18:58 +0000)]
Merge "Declare visibility on class properties of LCStore* classes"
jenkins-bot [Mon, 18 Nov 2013 18:56:27 +0000 (18:56 +0000)]
Merge "Declare visibility on class properties of LocalisationCache"
jenkins-bot [Mon, 18 Nov 2013 18:54:25 +0000 (18:54 +0000)]
Merge "Remove underscore from classes LCStore_*"
umherirrender [Mon, 18 Nov 2013 18:47:53 +0000 (19:47 +0100)]
move page_restrictions.pr_id to top in tables.sql
Having the primary key at the top of the column definition looks nicer
and helps by finding him.
Oracle and Postgres already have this moved up.
Change-Id: Id8afbff35e165919f55dfcf1fd1dfaf1805d6aab
jenkins-bot [Mon, 18 Nov 2013 18:46:48 +0000 (18:46 +0000)]
Merge "Set visibility on class properties for *Dependency classes"
jenkins-bot [Mon, 18 Nov 2013 18:45:10 +0000 (18:45 +0000)]
Merge "Declare visibility for class properties of LocalisationCacheBulkLoad"
jenkins-bot [Mon, 18 Nov 2013 18:43:16 +0000 (18:43 +0000)]
Merge "Remove underscore from class LocalisationCache_BulkLoad"
jenkins-bot [Mon, 18 Nov 2013 18:41:27 +0000 (18:41 +0000)]
Merge "Break long lines in includes/cache/"
jenkins-bot [Mon, 18 Nov 2013 18:39:29 +0000 (18:39 +0000)]
Merge "Update formatting"
jenkins-bot [Mon, 18 Nov 2013 18:37:37 +0000 (18:37 +0000)]
Merge "Remove unused local variables"
umherirrender [Mon, 18 Nov 2013 18:34:49 +0000 (19:34 +0100)]
Fix indentation of comment in tables.sql
Change-Id: Id879b4438f8f004549c090567ff76b64c5072824
jenkins-bot [Mon, 18 Nov 2013 18:30:05 +0000 (18:30 +0000)]
Merge "Set visibility for class properties of DependencyWrapper"
jenkins-bot [Mon, 18 Nov 2013 18:28:22 +0000 (18:28 +0000)]
Merge "Address errors and warnings in CodeSniffer in api/"
jenkins-bot [Mon, 18 Nov 2013 18:24:27 +0000 (18:24 +0000)]
Merge "Update indentation"
jenkins-bot [Mon, 18 Nov 2013 18:22:25 +0000 (18:22 +0000)]
Merge "Address CodeSniffer comments in ApiBase.php"
jenkins-bot [Mon, 18 Nov 2013 16:56:17 +0000 (16:56 +0000)]
Merge "Allow null to be passed to User::setNewPassword()"
Aaron Schulz [Sun, 17 Nov 2013 22:04:04 +0000 (14:04 -0800)]
Added fail-over support to JobQueueAggregatorRedis using "redisServers" option
* Also cleaned up various bits of documentation errors and cruft
Change-Id: Icccae5329941e4311fef02b6137a6b90f39f9046
aude [Mon, 18 Nov 2013 15:45:15 +0000 (16:45 +0100)]
Move RecentChangeTest to subdirectory
matches location of class within includes
Change-Id: I78d3212032ded3deaeef93aaca4d575a35559990
Alexandre Emsenhuber [Mon, 18 Nov 2013 15:04:09 +0000 (16:04 +0100)]
Allow null to be passed to User::setNewPassword()
This allows the temporary password to be cleared. This methods now
behaves the same as User::setInternalPassword() with that value.
Bug: 57075
Change-Id: I2c446864c7eb591dcb64e5971bc9989950715d15
jenkins-bot [Mon, 18 Nov 2013 15:01:48 +0000 (15:01 +0000)]
Merge "Add show=unpatrolled to the recentchanges API"
jenkins-bot [Mon, 18 Nov 2013 10:30:40 +0000 (10:30 +0000)]
Merge "Relicense jquery.placeholder.js to MIT"
Translation updater bot [Sun, 17 Nov 2013 20:28:06 +0000 (20:28 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I5a74c20de10a3203ff81d453de6c739a8a476081
Timo Tijhof [Fri, 25 Oct 2013 10:11:08 +0000 (12:11 +0200)]
Add show=unpatrolled to the recentchanges API
Adding it only in the API because SpecialRecentChanges only shows
"Hide patrolled edits" option if rcpatrol is enabled.
show=!patrolled returns results that include changes that can't
be patrolled which technically correct (they aren't correct)
but probably not what you're looking for when looking for
unpatrolled changes.
Change-Id: I356a8625c7126b90aa7e7a23efe3bef7d448b502
Siebrand Mazeland [Mon, 18 Nov 2013 04:25:43 +0000 (05:25 +0100)]
Set visibility on class properties for *Dependency classes
Set visibility to private for properties that are not referenced outside
of the class itself, and when the class is not currently being subclassed.
Change-Id: I427c6de5a0a29b43cff755db0eb8a750db620173
Siebrand Mazeland [Mon, 18 Nov 2013 04:14:24 +0000 (05:14 +0100)]
Set visibility for class properties of DependencyWrapper
Set to private. No subclassing and no uses outside of the class in core or
extensions.
Change-Id: If195d02b8ce853242312de7fb4bc7dc1cbe94365
Tim Starling [Mon, 18 Nov 2013 00:10:42 +0000 (11:10 +1100)]
Exclude servers with zero load from lag checks
Since r13582, servers with zero load have been isolated from the rest of
the servers in the section in terms of query flow. However, lag checks
still remained. This is not appropriate for backup/QueryPage servers
that are routinely lagged. IIRC we dealt with this once before with a
special case in the core excluding benet from master pos waits, but that
doesn't seem like a very appropriate solution today. Perhaps there is an
application for including zero-load slaves in lag checks, but I can't
think of any right now.
Related WMF conf change in I8fac5c99.
Change-Id: Id354039123f8c04febc8090eea9940fff044c5ea
Siebrand Mazeland [Sun, 17 Nov 2013 22:18:01 +0000 (23:18 +0100)]
Declare visibility on class properties of LCStore* classes
No direct references found in core or extensions outside of the classes
themselves. None of these are subclassed, so set all of them to private.
Change-Id: Id599c0830c1e6d3679c7ae55147f4444f8252987
Siebrand Mazeland [Sat, 16 Nov 2013 21:19:42 +0000 (22:19 +0100)]
Add/update/remove incomplete/incorrect documentation
Change-Id: I3c2c7f61d9a579ad794ce7b564ccc8a7cfb9b6fc
Siebrand Mazeland [Sun, 17 Nov 2013 21:49:03 +0000 (22:49 +0100)]
Declare visibility on class properties of LocalisationCache
Mark all private, except the one that's being used in subclass. Checked
core and extension for direct uses. None found.
Change-Id: If73d65ca094ff56deb19d3b6f3ef99892654726d
Siebrand Mazeland [Sat, 16 Nov 2013 21:15:17 +0000 (22:15 +0100)]
Update docs to reduce inconsistent type compatibility in api/
Change-Id: Iaf97aeb514ddb2176491c3820fe891be8e989939
jenkins-bot [Sun, 17 Nov 2013 21:36:08 +0000 (21:36 +0000)]
Merge "Add ar_id and el_id sequences for PostgreSQL"
Siebrand Mazeland [Sun, 17 Nov 2013 21:09:31 +0000 (22:09 +0100)]
Remove underscore from classes LCStore_*
iPart of program to remove underscores from class names. Checked core and
600+ extensions for occurrences. All uses are in core, and are updated in
this change.
Change-Id: I432dc249d22053728013ae7d0d56c3c398021c5e
Siebrand Mazeland [Sun, 17 Nov 2013 21:03:53 +0000 (22:03 +0100)]
Declare visibility for class properties of LocalisationCacheBulkLoad
Mark all as private. Not referenced elsewhere in core or extensions.
Change-Id: Ibe0e854f39261053e5147138309c3a4b1944e5fe
Siebrand Mazeland [Sun, 17 Nov 2013 20:59:43 +0000 (21:59 +0100)]
Remove underscore from class LocalisationCache_BulkLoad
Part of program to remove underscores from class names. Checked core and
600+ extensions for occurrences. All uses are in core, and are updated in
this change.
Change-Id: Ib157c3cf209677718ff184552cf872b1d3f4e969
Siebrand Mazeland [Sun, 17 Nov 2013 20:49:59 +0000 (21:49 +0100)]
Break long lines in includes/cache/
Change-Id: I23a6f46f89b3cdcaf2a3b982dc63e779eed5840d
Siebrand Mazeland [Sun, 17 Nov 2013 20:36:27 +0000 (21:36 +0100)]
Update formatting
Change-Id: I9aa56cbe0989d6f302ee0f47c4a6154101f73e90
Siebrand Mazeland [Sat, 16 Nov 2013 21:11:49 +0000 (22:11 +0100)]
Update some documentation in CacheTime and ParserCache
Change-Id: I31be0d4639f2a7189e15b622b34595564fad2a3d
Siebrand Mazeland [Sun, 17 Nov 2013 19:25:44 +0000 (20:25 +0100)]
Update indentation in ApiUserrights::execute()
The previous formatting was inconsistent.
Change-Id: I22d7cba00cd39df7069b47f78ca130e3e031ceb4
Siebrand Mazeland [Sun, 17 Nov 2013 19:22:39 +0000 (20:22 +0100)]
Simplify ApiUserRights::getUrUser()
Remove unneeded else and local variable assignment.
Change-Id: I166d811b220e925be11da5c49b6fe55f0d8e71c8
Siebrand Mazeland [Sun, 17 Nov 2013 19:04:13 +0000 (20:04 +0100)]
Update documentation for ApiDelete::deleteFile()
WikiPage was no longer valid given the current type hint. Added
types and documentation where missing.
Change-Id: Ie0a3a8fff3ad496b723958133867df48a695d3b7