From: C. Scott Ananian <cscott@cscott.net>
Date: Mon, 22 Apr 2019 16:40:43 +0000 (-0400)
Subject: Synchronize allowed attributes for <audio> with Parsoid/TimedMediaHandler
X-Git-Tag: 1.34.0-rc.0~1869^2
X-Git-Url: http://git.cyclocoop.org/%7B%7B%20url_for%28%27admin_vote_add%27%29%20%7D%7D?a=commitdiff_plain;h=cfc60acc5678e276c23f18ccfe4f10f6d85932f1;p=lhc%2Fweb%2Fwiklou.git

Synchronize allowed attributes for <audio> with Parsoid/TimedMediaHandler

We synchronized the allowed attributes for <video> in
4e7483ffd31dd05c11b16bf37552c25ed648bd0a but then decided to use the
<audio> tag for audio media in Parsoid commit
5f3dbdc8794f2605101609f28e679df29a0387bc and updated its Sanitizer,
but never updated core to match.

Bug: T163583
Bug: T133673
Change-Id: Iefcbead2f335949eb45e2880861fd9473b810367
---

diff --git a/includes/parser/Sanitizer.php b/includes/parser/Sanitizer.php
index 518846ce7e..35a5944711 100644
--- a/includes/parser/Sanitizer.php
+++ b/includes/parser/Sanitizer.php
@@ -1918,7 +1918,8 @@ class Sanitizer {
 			# such as <math> when it is rasterized, or if $wgAllowImageTag is
 			# true
 			'img'        => array_merge( $common, [ 'alt', 'src', 'width', 'height', 'srcset' ] ),
-
+			# Attributes for A/V tags added in T163583 / T133673
+			'audio'      => array_merge( $common, [ 'controls', 'preload', 'width', 'height' ] ),
 			'video'      => array_merge( $common, [ 'poster', 'controls', 'preload', 'width', 'height' ] ),
 			'source'     => array_merge( $common, [ 'type', 'src' ] ),
 			'track'      => array_merge( $common, [ 'type', 'src', 'srclang', 'kind', 'label' ] ),