From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Fri, 21 Nov 2008 09:55:13 +0000 (+0000)
Subject: Revert r43804 'This should probably be in Response, not Request, as we're setting... 
X-Git-Tag: 1.31.0-rc.0~44234
X-Git-Url: http://git.cyclocoop.org/%7B%7B%20url_for%28%27admin_vote_add%27%29%20%7D%7D?a=commitdiff_plain;h=c155fd4e4afe64a3c21850327ec749c0b5778850;p=lhc%2Fweb%2Fwiklou.git

Revert r43804 'This should probably be in Response, not Request, as we're setting data, not getting it. Nothing's using it yet (fairly new), so nothing to update.'

Session id is used by client request to specify its login data from cookie, so the session data, by extensions, is like a sort of request parameter. Also, WebResponse.php seems to be used for data actually sent to the client, like requested cookies.
---

diff --git a/includes/WebRequest.php b/includes/WebRequest.php
index c3c1d89dad..467471250d 100644
--- a/includes/WebRequest.php
+++ b/includes/WebRequest.php
@@ -658,6 +658,9 @@ class WebRequest {
 			return null;
 		return $_SESSION[$key];
 	}
+	function setSessionData( $key, $data ) {
+		$_SESSION[$key] = $data;
+	}
 }
 
 /**
@@ -722,5 +725,8 @@ class FauxRequest extends WebRequest {
 			return null;
 		return $this->session[$key];
 	}
+	function setSessionData( $key, $data ) {
+		$this->notImplemented( __METHOD__ );
+	}
 
 }
diff --git a/includes/WebResponse.php b/includes/WebResponse.php
index 19feadd426..09d373850f 100644
--- a/includes/WebResponse.php
+++ b/includes/WebResponse.php
@@ -57,8 +57,4 @@ class WebResponse {
 				$wgCookieSecure );
 		}
 	}
-
-	public function setSessionData( $key, $data ) {
-		$_SESSION[$key] = $data;
-	}
 }