Merge "tests: Clean up use of mt_rand()"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Sun, 6 Dec 2015 22:32:43 +0000 (22:32 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sun, 6 Dec 2015 22:32:43 +0000 (22:32 +0000)
1  2 
tests/phpunit/includes/filebackend/FileBackendTest.php

@@@ -18,7 -18,6 +18,6 @@@ class FileBackendTest extends MediaWiki
        protected function setUp() {
                global $wgFileBackends;
                parent::setUp();
-               $uniqueId = time() . '-' . mt_rand();
                $tmpDir = $this->getNewTempDirectory();
                if ( $this->getCliArg( 'use-filebackend' ) ) {
                        if ( self::$backendToUse ) {
@@@ -58,7 -57,7 +57,7 @@@
                        'name' => 'localtesting',
                        'lockManager' => LockManagerGroup::singleton()->get( 'fsLockManager' ),
                        'parallelize' => 'implicit',
-                       'wikiId' => wfWikiId() . $uniqueId,
+                       'wikiId' => wfWikiId() . wfRandomString(),
                        'backends' => array(
                                array(
                                        'name' => 'localmultitesting1',
                ) );
        }
  
 -      protected function tearDown() {
 -              parent::tearDown();
 -              DeferredUpdates::forceDeferral( false );
 -      }
 -
        private static function baseStorePath() {
                return 'mwstore://localtesting';
        }
                        ) )
                );
  
 -              DeferredUpdates::forceDeferral( true );
 +              $this->setMwGlobals( 'wgCommandLineMode', false );
  
                $p = 'container/test-cont/file.txt';
                $be->quickCreate( array(
                );
  
                DeferredUpdates::doUpdates();
 -              DeferredUpdates::forceDeferral( false );
  
                $this->assertEquals(
                        'cattitude',