RCFilters: Cleanup 'Namespaces' dropdown borders appearance
authorVolker E <volker.e@wikimedia.org>
Thu, 25 Oct 2018 22:06:56 +0000 (15:06 -0700)
committerVolker E <volker.e@wikimedia.org>
Thu, 25 Oct 2018 22:06:56 +0000 (15:06 -0700)
Cleaning-up by
- adding border only between namespace and talk options
- adding namespace border on all but the first occurrence

Change-Id: Icfc87757deda9b7655c4ea5c919b5c2f2e2ae09e

resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less

index bf855be..61872bd 100644 (file)
@@ -6,17 +6,19 @@
        padding: 0 0.5em;
        .box-sizing( border-box );
 
-       &:not( :last-child ) {
+       &:not( :last-child ):not( .mw-rcfilters-ui-itemMenuOptionWidget-identifier-talk ) {
                border-bottom: 1px solid @colorGray14;
        }
 
        &-view-namespaces {
                border-top: 4px solid @colorGray12;
+       }
 
-               &:first-child,
-               &.mw-rcfilters-ui-itemMenuOptionWidget-identifier-subject + &.mw-rcfilters-ui-itemMenuOptionWidget-identifier-talk {
-                       border-top: 0;
-               }
+       // Don't show border for first namespace
+       &-view-default + &-view-namespaces,
+       // Hide for every 'talk' option
+       &-view-namespaces&.mw-rcfilters-ui-itemMenuOptionWidget-identifier-subject + &-view-namespaces.mw-rcfilters-ui-itemMenuOptionWidget-identifier-talk {
+               border-top: 0;
        }
 
        &:hover {