Keep the feature flag for 'live update'
but enable 'view newest' by default on RC.
Bug: T163426
Change-Id: I733cf99bbeb6d90d3aa21e87507c513354b81791
mw.rcfilters.dm.ChangesListViewModel.prototype.update = function ( changesListContent, $fieldset, isInitialDOM, separateOldAndNew ) {
var from = this.nextFrom;
this.valid = true;
mw.rcfilters.dm.ChangesListViewModel.prototype.update = function ( changesListContent, $fieldset, isInitialDOM, separateOldAndNew ) {
var from = this.nextFrom;
this.valid = true;
- if ( mw.rcfilters.featureFlags.liveUpdate ) {
- this.extractNextFrom( $fieldset );
- }
+ this.extractNextFrom( $fieldset );
this.checkForUnseenWatchedChanges( changesListContent );
this.emit( 'update', changesListContent, $fieldset, isInitialDOM, separateOldAndNew ? from : null );
};
this.checkForUnseenWatchedChanges( changesListContent );
this.emit( 'update', changesListContent, $fieldset, isInitialDOM, separateOldAndNew ? from : null );
};
* @param {jQuery} $fieldset
*/
mw.rcfilters.dm.ChangesListViewModel.prototype.extractNextFrom = function ( $fieldset ) {
* @param {jQuery} $fieldset
*/
mw.rcfilters.dm.ChangesListViewModel.prototype.extractNextFrom = function ( $fieldset ) {
- this.nextFrom = $fieldset.find( '.rclistfrom > a' ).data( 'params' ).from;
+ var data = $fieldset.find( '.rclistfrom > a' ).data( 'params' );
+ this.nextFrom = data ? data.from : null;
!this.filtersModel.hasConflict() &&
!this.changesListModel.getNewChangesExist() &&
!this.updatingChangesList &&
!this.filtersModel.hasConflict() &&
!this.changesListModel.getNewChangesExist() &&
!this.updatingChangesList &&
- mw.rcfilters.featureFlags.liveUpdate;
+ this.changesListModel.getNextFrom();
// Set up highlight containers
this.setupHighlightContainers( this.$element );
// Set up highlight containers
this.setupHighlightContainers( this.$element );
- if ( mw.rcfilters.featureFlags.liveUpdate ) {
- this.setupNewChangesButtonContainer( this.$element );
- }
+ this.setupNewChangesButtonContainer( this.$element );
this.$element.find( '.cloption-submit' ).detach();
}
this.$element.find( '.cloption-submit' ).detach();
}
- if ( mw.rcfilters.featureFlags.liveUpdate ) {
- this.$element.find(
- '.rclistfrom, .rcnotefrom, .rcoptions-listfromreset'
- ).detach();
- }
+ this.$element.find(
+ '.rclistfrom, .rcnotefrom, .rcoptions-listfromreset'
+ ).detach();
if ( this.$element.text().trim() === this.$element.find( 'legend' ).text() ) {
this.$element.detach();
if ( this.$element.text().trim() === this.$element.find( 'legend' ).text() ) {
this.$element.detach();