( $var & 1 ) is either 0 or 1, which can be used as a boolean value.
The main advantage of this is that there is no confusion with the
operator precedence. In `$var & 1 !== 1` the `!==` is executed first,
effectively turning it into `$var & 0`. This always succeeds.
Change-Id: I53c81a3891d42b2660eefc311f1f0f2523104894
// value_to_add_forward: a 0 or 1 that we add to the start
// offset to make it odd/even
// value_to_add_forward: a 0 or 1 that we add to the start
// offset to make it odd/even
- if ( ( $M & 1 ) == 1 ) {
$value_to_add_forward = 1;
} else {
$value_to_add_forward = 0;
}
$value_to_add_forward = 1;
} else {
$value_to_add_forward = 0;
}
- if ( ( $N & 1 ) == 1 ) {
$value_to_add_backward = 1;
} else {
$value_to_add_backward = 0;
$value_to_add_backward = 1;
} else {
$value_to_add_backward = 0;
$V1[$limit_min_1] = $N;
$limit = min( $this->maxDifferences, ceil( ( $N + $M ) / 2 ) );
$V1[$limit_min_1] = $N;
$limit = min( $this->maxDifferences, ceil( ( $N + $M ) / 2 ) );
- if ( ( $delta & 1 ) == 1 ) {
for ( $d = 0; $d <= $limit; ++$d ) {
$start_diag = max( $value_to_add_forward + $start_forward, -$d );
$end_diag = min( $end_forward, $d );
for ( $d = 0; $d <= $limit; ++$d ) {
$start_diag = max( $value_to_add_forward + $start_forward, -$d );
$end_diag = min( $end_forward, $d );
$this->dumpForm( $file, $chunkLength, $indent + 1 );
} else {
fseek( $file, $chunkLength, SEEK_CUR );
$this->dumpForm( $file, $chunkLength, $indent + 1 );
} else {
fseek( $file, $chunkLength, SEEK_CUR );
- if ( ( $chunkLength & 1 ) == 1 ) {
+ if ( $chunkLength & 1 ) {
// Padding byte between chunks
fseek( $file, 1, SEEK_CUR );
}
// Padding byte between chunks
fseek( $file, 1, SEEK_CUR );
}
private function skipChunk( $file, $chunkLength ) {
fseek( $file, $chunkLength, SEEK_CUR );
private function skipChunk( $file, $chunkLength ) {
fseek( $file, $chunkLength, SEEK_CUR );
- if ( ( $chunkLength & 0x01 ) == 1 && !feof( $file ) ) {
+ if ( ( $chunkLength & 1 ) && !feof( $file ) ) {
// padding byte
fseek( $file, 1, SEEK_CUR );
}
// padding byte
fseek( $file, 1, SEEK_CUR );
}