jenkins-bot [Fri, 21 Apr 2017 00:36:23 +0000 (00:36 +0000)]
Merge "RCFilters UI: Change text for edit authorship group"
jenkins-bot [Thu, 20 Apr 2017 22:38:14 +0000 (22:38 +0000)]
Merge "Fix bogus variable use in RefreshLinksJob::run()"
jenkins-bot [Thu, 20 Apr 2017 22:38:11 +0000 (22:38 +0000)]
Merge "Use makeKey() in BacklinkCache"
Translation updater bot [Thu, 20 Apr 2017 20:16:29 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia8218a33495bb93bad4f4970047dde834bb61f8d
Aaron Schulz [Thu, 20 Apr 2017 19:26:23 +0000 (12:26 -0700)]
Use makeKey() in BacklinkCache
Change-Id: I23c000c8c2c77aa538fe258ea34eb764987eb52d
jenkins-bot [Thu, 20 Apr 2017 19:04:16 +0000 (19:04 +0000)]
Merge "Hold number of search results in a data attribute"
Aaron Schulz [Thu, 20 Apr 2017 18:29:25 +0000 (11:29 -0700)]
Fix bogus variable use in RefreshLinksJob::run()
Also removed two unused loop variables.
Change-Id: I9a9e0a83bdaa13c031857bc20f977161cf85baff
jenkins-bot [Thu, 20 Apr 2017 17:28:08 +0000 (17:28 +0000)]
Merge "Switch to librarized version of TestingAccessWrapper"
jenkins-bot [Thu, 20 Apr 2017 15:24:01 +0000 (15:24 +0000)]
Merge "Fix EditPage button/input accessors on PageObject"
Gergő Tisza [Wed, 19 Apr 2017 19:37:35 +0000 (19:37 +0000)]
Switch to librarized version of TestingAccessWrapper
Replaces \TestingAccessWrapper (defined in core) with
\Wikimedia\TestingAccessWrapper (defined in the composer package
wikimedia/testing-access-wrapper).
See https://gerrit.wikimedia.org/r/#/q/topic:librarize-testing-access-wrapper
for downstream patches.
The core version of the class is kept around for a while to avoid
circular dependency problems.
Bug: T163434
Change-Id: I52cc257e593da3d6c3b01a909e554a950225aec8
WMDE-Fisch [Thu, 20 Apr 2017 09:27:05 +0000 (11:27 +0200)]
Fix EditPage button/input accessors on PageObject
The DOM was changed again in https://gerrit.wikimedia.org/r/#/c/348765/
and input elements where used for the buttons.
Bug: T163193
Change-Id: I910a31a30d5569aab69dc2e5f81b377b6d867f64
Timo Tijhof [Wed, 19 Apr 2017 23:46:13 +0000 (16:46 -0700)]
benchmarks: Report more metrics (min/max/median)
Add minimum, maximum, median to the report in addition to the mean (average)
which was already there. Based on benchmarkTidy.php from I254793fc5.
Example output:
> Delete
> times: 10
> total: 7.47ms
> min: 0.53ms
> median: 0.74ms
> mean: 0.75ms
> max: 1.21ms
>
> Truncate
> times: 10
> total: 72.38ms
> min: 1.37ms
> median: 8.32ms
> mean: 7.24ms
> max: 15.73ms
Change-Id: Ifd3064a3621e07f55505490403189cb47022c6c7
Timo Tijhof [Wed, 19 Apr 2017 23:22:50 +0000 (16:22 -0700)]
benchmarks: Add setup, bench naming, and custom count default
* bench(): Add support for setup function.
Demonstrated by converting bench_delete_truncate.php to use Benchmarker.
* bench(): Allow benchmarks to be named. Default remains (fn + args).
Useful for closures.
* Benchmarker: Support overriding the default count of 100.
Demonstrated in bench_delete_truncate.php to run 10x instead of
100x (previous: 1x).
Change-Id: Iac182eaf3053f5bf0e811cd23082f530629d8a4e
Timo Tijhof [Wed, 19 Apr 2017 23:06:27 +0000 (16:06 -0700)]
benchmarks: Minor clean up
Change-Id: I446ae1a9d9cdb6b26a6bb62367a432cea082f343
Aaron Schulz [Thu, 20 Apr 2017 03:43:56 +0000 (20:43 -0700)]
Fix bogus field reference in Category::getCountMessage() callback
Follows-up
922e68f739f143. (T162121)
Bug: T162941
Change-Id: I40623203e97f7155c2af171a37b1128a59415315
This, that and the other [Thu, 20 Apr 2017 02:25:59 +0000 (12:25 +1000)]
Add different log-in tooltip for private wikis
Bug: T148006
Change-Id: I14e9a554c72222e6f67bc120941199b999740886
jenkins-bot [Thu, 20 Apr 2017 01:05:32 +0000 (01:05 +0000)]
Merge "Document which EtcdConfig parameters are optional"
jenkins-bot [Thu, 20 Apr 2017 00:13:34 +0000 (00:13 +0000)]
Merge "Remove load array indexes from LoadBalancer errors"
jenkins-bot [Thu, 20 Apr 2017 00:12:20 +0000 (00:12 +0000)]
Merge "UploadBase::getTitle can return null"
jenkins-bot [Thu, 20 Apr 2017 00:10:59 +0000 (00:10 +0000)]
Merge "Lower the amount of jobs pushed into redis at once"
Aaron Schulz [Wed, 19 Apr 2017 23:48:13 +0000 (16:48 -0700)]
Document which EtcdConfig parameters are optional
Change-Id: Ic6b56ed2f8789ae7920cdfc12f34b00db4a76c3a
Timo Tijhof [Wed, 19 Apr 2017 22:27:41 +0000 (15:27 -0700)]
ReadOnlyMode: Add a few doc blocks
Follows-up
820f46964f7968a.
Change-Id: I7866eb7c8bb9c45a24a3c567a7befe3505821873
Aaron Schulz [Wed, 19 Apr 2017 22:38:32 +0000 (15:38 -0700)]
Lower the amount of jobs pushed into redis at once
This further limits how long the server can be tied up by push().
Change-Id: I02d242578dadc19912c9fccfdcf5e15c5eb78e9e
jenkins-bot [Wed, 19 Apr 2017 22:23:28 +0000 (22:23 +0000)]
Merge "A service for read-only mode"
Moriel Schottlender [Wed, 19 Apr 2017 21:39:24 +0000 (14:39 -0700)]
RCFilters UI: Change text for edit authorship group
Bug: T149385
Change-Id: I96831b2a650eb0232013762675fb4c5bd325b6a9
Aaron Schulz [Wed, 19 Apr 2017 21:30:25 +0000 (14:30 -0700)]
Remove load array indexes from LoadBalancer errors
This are not very useful and where not using SPI interpolation either.
Change-Id: Ia3a33da3a4593fbcba59b21f5b5028860752ce09
Translation updater bot [Wed, 19 Apr 2017 20:22:15 +0000 (22:22 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6e67503e539268e66f495a594f29231e3ee4b6dd
jenkins-bot [Wed, 19 Apr 2017 20:09:03 +0000 (20:09 +0000)]
Merge "media: Remove unused private function in SVGMetadataExtractor"
Eugene Gvozdetsky [Wed, 19 Apr 2017 10:11:20 +0000 (12:11 +0200)]
media: Remove unused private function in SVGMetadataExtractor
Change-Id: I3cd00bb4f460a141966ad01e155a97b8a087a8e8
Tim Starling [Mon, 10 Apr 2017 05:34:30 +0000 (15:34 +1000)]
A service for read-only mode
Introduce a service to represent wfReadOnly() and friends.
It's necessary to have two service instances, one for wfReadOnly() and
one for wfConfiguredReadOnlyReason(), to avoid a circular dependency,
since LoadBalancer needs the configured reason during construction, but
wfReadOnly() needs to query the currently active load balancer.
Not having a cache of the configuration makes it possible to dynamically
change the configuration. Ideally things would not change the
configuration, and I removed such instances in core, but to support
extensions, I added a test ensuring that the configuration can be changed.
Change-Id: I9bbee946c10742526d3423208efd68cb3cc5a7ee
jenkins-bot [Wed, 19 Apr 2017 19:02:47 +0000 (19:02 +0000)]
Merge "Remove links list from the 'rclinks' message"
Mikhail Popov [Thu, 13 Apr 2017 21:49:20 +0000 (14:49 -0700)]
Hold number of search results in a data attribute
Current way of counting returned search results (e.g. for
Event Logging) relies on counting the appropriate elements
in the search results page's DOM, up to the limit the user
requested (e.g. 20 by default). This allows us to record
the total number and the offset, useful for event logging.
For example, if we wanted to know whether the user viewed
2nd or 3rd set of search results.
Change-Id: Ic8601e9eeddac84ba8e0d7dc6f127bf360b6f90f
James D. Forrester [Wed, 19 Apr 2017 18:25:22 +0000 (11:25 -0700)]
HACK: Temporarily patch OOjs UI locally to work around upstream problem
Applied upstream in Ic11b981e70e3.
Bug: T163358
Change-Id: If8c26ffe5095e4e8c2f206c9dda1981bccba2b62
jenkins-bot [Wed, 19 Apr 2017 06:57:43 +0000 (06:57 +0000)]
Merge "Allow editors to exclude navigation items from search indices"
jenkins-bot [Wed, 19 Apr 2017 03:20:22 +0000 (03:20 +0000)]
Merge "RC Filters: Detect filters conflicts to by-pass db query"
Stephane Bisson [Mon, 10 Apr 2017 17:23:45 +0000 (13:23 -0400)]
RC Filters: Detect filters conflicts to by-pass db query
Filters are in conflict when their combination is guaranteed
to return no results. For instance: minor and log entries
is a conflict because major/minor does not apply to
log entries and the field is set to major by default.
Letting conflicts go through result in some very slow
database queries.
Bug: T160220
Change-Id: Ia6b0125c675c4a3cc4e4be4f83d1bd10d23059ba
jenkins-bot [Wed, 19 Apr 2017 00:38:22 +0000 (00:38 +0000)]
Merge "qunit: Also clear $.timers when stopping unfinished animations"
jenkins-bot [Wed, 19 Apr 2017 00:20:59 +0000 (00:20 +0000)]
Merge "resourceloader: Move mwNow() to after isCompatible()"
jenkins-bot [Wed, 19 Apr 2017 00:08:03 +0000 (00:08 +0000)]
Merge "Update OOjs UI to v0.21.1"
Timo Tijhof [Tue, 18 Apr 2017 23:45:30 +0000 (16:45 -0700)]
qunit: Also clear $.timers when stopping unfinished animations
Stopping the animation is essentially the same as pausing, it remains in the
animation registry and will continue to fail all subsequent tests until one
of those later tests starts the animation queue again and also happens to
wait long enough for this unrelated animation to finish.
Fix the testrunner to actually fully stop the pre-existing animations, which
requires clearing $.timers as well. This matches the logic we have for
pending ajax requests.
Bug: T163211
Change-Id: Ic7d848187bc3c800e8347e0650093b2ffce6dddc
James D. Forrester [Tue, 18 Apr 2017 23:41:08 +0000 (16:41 -0700)]
Update OOjs UI to v0.21.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.1
Depends-On: I5edcf21effee760d9951965a152481f2c603b59b
Change-Id: I5edcf21effee760d9951965a152481f2c603b5b9
Timo Tijhof [Tue, 18 Apr 2017 23:31:42 +0000 (16:31 -0700)]
build: Sync qunitjs version for karma with version of Special page
Special:JavaScriptTest loads qunitjs from /resources/lib/qunitjs
which was upgraded in
99aad9397e to 1.23.1.
However, when running QUnit tests from the command-line, QUnit is
loaded by karma-qunit using the npm qunitjs dependency, which was
still at v1.22.0.
Change-Id: Ie24b2b061735fa03a8ed1527d09f65c103506c67
jenkins-bot [Tue, 18 Apr 2017 23:23:28 +0000 (23:23 +0000)]
Merge "Do an HTMLCacheUpdate of templatelinks on page creation"
jenkins-bot [Tue, 18 Apr 2017 23:03:45 +0000 (23:03 +0000)]
Merge "RCFilters UI: Select tag when filter item is selected"
Moriel Schottlender [Mon, 17 Apr 2017 23:45:54 +0000 (16:45 -0700)]
RCFilters UI: Select tag when filter item is selected
Retain the selection behavior from previous versions, and synchronize
the selection of the filter item in the menu with the tag items
in the MenuTagMultiselectWidget.
Bug: T163138
Change-Id: I548a1fca65372c697e24b77d928d56b18f4df1c5
Timo Tijhof [Tue, 18 Apr 2017 21:13:06 +0000 (14:13 -0700)]
resourceloader: Move mwNow() to after isCompatible()
Follows-up
f2fb4a21af. This is logically still the same point in time.
Only 1 function before it now, isCompatible(), which is fine since it
is small and the variable is not used anyway if it returns false.
Change-Id: I34bbe8edf6e9625f8d80f829707adafcb1b91980
Erik Bernhardson [Tue, 18 Apr 2017 21:03:23 +0000 (14:03 -0700)]
Allow editors to exclude navigation items from search indices
When you perform a particular search, the results can be polluted by
navigation elements that are not supposed to be displayed. This gives
editors the ability to mark sections of the document that should not
be indexed.
Bug: T162905
Change-Id: Iab2b83c3778cd5f7f44736c0da569fd938ae2968
Translation updater bot [Tue, 18 Apr 2017 19:57:20 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6c1534c40494dff1a9866fa5ec478c4646477688
addshore [Tue, 18 Apr 2017 19:42:54 +0000 (20:42 +0100)]
UploadBase::getTitle can return null
Change-Id: I5bd94f6233476bda43a01155f6e7d6df420412e2
Stephane Bisson [Tue, 18 Apr 2017 19:40:11 +0000 (15:40 -0400)]
Remove links list from the 'rclinks' message
In some languages, the 'rclinks' message ends
with '...<br />$3.' where $3 is a list of links.
When $3 is empty, we end up with a lonely period
on a new line.
This change removes $3 and adds it on the page
on its own. Unfortunately, it requires fixing all
the messages. Not sure if it's the proper way to
do this.
Bug: T162844
Change-Id: If17f056c135b2e51747a5a1c8aeaba785cf18ff2
jenkins-bot [Tue, 18 Apr 2017 19:03:23 +0000 (19:03 +0000)]
Merge "EditPage: Restore IE 6 compatibility for OOUI-style buttons"
Bartosz Dziewoński [Tue, 18 Apr 2017 16:32:34 +0000 (18:32 +0200)]
EditPage: Restore IE 6 compatibility for OOUI-style buttons
Follow-up to
97d7de0b84ef65094108fbcf62ffcc1c55d75345.
Bug: T163219
Change-Id: Ifb5145c631ce1a3aa7e51956fab3ec7da8b994d2
Bartosz Dziewoński [Tue, 18 Apr 2017 16:52:53 +0000 (18:52 +0200)]
EditPage: Restore ability to provide edit summary for OOUI-style input
The 'name' attribute was missing, so the field was not being submitted
with the form.
Change-Id: Ic7238b9bfe9ca254f844fb828cf09ecf44171461
Brad Jorsch [Tue, 18 Apr 2017 16:40:50 +0000 (12:40 -0400)]
Do an HTMLCacheUpdate of templatelinks on page creation
When a page is created, anything that's trying to transclude that page
needs to have an HTMLCacheUpdate run on it. But that's not currently
happening.
Normal template transclusion happens to get updates only because
transclusion of a nonexistent template is rendered as a link to that
template, which registers a pagelink, and pagelinks *are* being updated
on page creation to cause redlinks to turn blue.
Change-Id: I18b8cfdeedc53f8fdb1e758a6fca1cd23d9574f8
jenkins-bot [Tue, 18 Apr 2017 16:27:53 +0000 (16:27 +0000)]
Merge "Use more specific string[] type hint for language variants"
jenkins-bot [Tue, 18 Apr 2017 14:24:22 +0000 (14:24 +0000)]
Merge "Avoid overflowing of unbreakable words in interwiki search results"
WMDE-Fisch [Tue, 18 Apr 2017 09:13:54 +0000 (11:13 +0200)]
Fix EditPage button accessors on PageObject
This will change the accessors to the EditPage in the PageObject to
fit the new DOM when using OOUI.
Bug: T163193
Change-Id: Ic6858d458e2f781c20a101105eb03bd483d6af73
jenkins-bot [Tue, 18 Apr 2017 01:47:48 +0000 (01:47 +0000)]
Merge "Use .toc instead of #toc as selector for TOC"
Fomafix [Sat, 15 Apr 2017 06:45:25 +0000 (08:45 +0200)]
Use .toc instead of #toc as selector for TOC
Since
1bf5a652 multiple TOCs are supported.
In CSS the selector #toc is kept for backward compatibility for uses in the
content.
Change-Id: I07036c0d5782420fc127781a15c675fc7e6fafaf
jenkins-bot [Tue, 18 Apr 2017 00:31:28 +0000 (00:31 +0000)]
Merge "RCFilters UI: Don't steal focus when clicking highlight button"
jenkins-bot [Tue, 18 Apr 2017 00:26:47 +0000 (00:26 +0000)]
Merge "RCFilters UI: Prevent label from stealing focus on click"
jenkins-bot [Tue, 18 Apr 2017 00:26:08 +0000 (00:26 +0000)]
Merge "RCFilters UI: Display 'no results found' if... no results were found!"
jenkins-bot [Tue, 18 Apr 2017 00:26:04 +0000 (00:26 +0000)]
Merge "RCFilters UI: Fix scrolling to item on tag click"
Moriel Schottlender [Tue, 18 Apr 2017 00:06:47 +0000 (17:06 -0700)]
RCFilters UI: Display 'no results found' if... no results were found!
The "normal" operation of an OO.ui.MenuSelectWidget is to hide itself
if no results are found in the filtering process. However, we want
the menu to remain visible but display a 'no filters found' message
like it did before the migration to a MenuTagMultiselectWidget.
Bug: T163170
Change-Id: Iee7b07961b90ac514a4aa1f7c56019ecd7b4c3cc
jenkins-bot [Mon, 17 Apr 2017 23:48:01 +0000 (23:48 +0000)]
Merge "Split up LoadBalancer::getReaderIndex() and simplify the code a bit"
Aaron Schulz [Sun, 16 Apr 2017 03:30:43 +0000 (20:30 -0700)]
Split up LoadBalancer::getReaderIndex() and simplify the code a bit
Change-Id: I4e0b5318ad2c987b2a059c4ef2bda3de14486687
Moriel Schottlender [Mon, 17 Apr 2017 23:30:03 +0000 (16:30 -0700)]
RCFilters UI: Fix scrolling to item on tag click
Bug: T163138
Change-Id: I1f3a5b29eb3d9125faf1d4d27c84b8711fd4fdda
Moriel Schottlender [Mon, 17 Apr 2017 23:14:14 +0000 (16:14 -0700)]
RCFilters UI: Don't steal focus when clicking highlight button
Change-Id: I6c41803221fc09ae2676bd09dd734d36f284cc09
Roan Kattouw [Mon, 17 Apr 2017 22:32:58 +0000 (15:32 -0700)]
RCFilters UI: Fix input direction in RTL again
The style rule for this was in a block for &-search,
which doesn't exist any more.
Change-Id: I1d60cd42df173f7f71085c2a3e5d46bd4bf23ef1
jenkins-bot [Mon, 17 Apr 2017 22:06:42 +0000 (22:06 +0000)]
Merge "Move DB errors to Rdbms namespace"
Moriel Schottlender [Mon, 17 Apr 2017 21:19:31 +0000 (14:19 -0700)]
RCFilters UI: Prevent label from stealing focus on click
The filter options' labels are set as "label for" the checkbox
which means that by default they "give" the focus away to the
checkbox when clicked. However, we don't want that behavior so
that we can continue arrow movement through the filter option
items rather than the DOM elements. Also, the checkbox prevents
defaults on click as well as it is.
Change-Id: I9758b0dacd8cd647ec5e3e623edc66e1d7f7420a
jenkins-bot [Mon, 17 Apr 2017 20:58:17 +0000 (20:58 +0000)]
Merge "Clarify getLaggedReplicaMode()/laggedReplicaUsed() in LoadBalancer"
Thiemo Mättig [Mon, 17 Apr 2017 20:31:22 +0000 (22:31 +0200)]
Use more specific string[] type hint for language variants
This patch only touches PHPDoc documentation, nothing else.
Change-Id: Ia79d06425a3b8629c171cd68ae435c64dac86f46
Translation updater bot [Mon, 17 Apr 2017 19:54:55 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6518eb7aa39e3933714d2df77f881a0929196d71
jenkins-bot [Mon, 17 Apr 2017 18:19:02 +0000 (18:19 +0000)]
Merge "RCFilters: Remove 'overflow:hidden' from filter header"
jenkins-bot [Mon, 17 Apr 2017 16:19:57 +0000 (16:19 +0000)]
Merge "Support GENDER in the message "sp-contributions-userrights""
Amire80 [Mon, 17 Apr 2017 14:14:26 +0000 (17:14 +0300)]
Changed "modified" to "edited"
There were two messages that said "This page was last modified etc.".
They are now "This page was last edited". The word "modify" is used
elsewhere in MediaWiki messages for things other than editing a page,
like uploaded files, databases, and configuration, whereas actual
pages are edited and not modified.
Change-Id: I79b68bbec35f7747cd2a27c1a29e154139e3ab76
Translation updater bot [Mon, 17 Apr 2017 07:57:10 +0000 (09:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id03227c4e4d8963db6cd44ee0bde953dbe2128c6
jenkins-bot [Sun, 16 Apr 2017 20:06:34 +0000 (20:06 +0000)]
Merge "EditPage: Make input and button widgets infusable"
jenkins-bot [Sun, 16 Apr 2017 19:30:55 +0000 (19:30 +0000)]
Merge "Convert various FormActions to OOUI"
Translation updater bot [Sun, 16 Apr 2017 07:43:40 +0000 (09:43 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib5b863d0778647034f75e65c45e4a10986ec1a3d
Ed Sanders [Sat, 15 Apr 2017 12:56:48 +0000 (13:56 +0100)]
EditPage: Make input and button widgets infusable
This will allow gadget developers greater control, e.g. disabling.
Change-Id: I9a21cd2dd3fc7695fc09632b844cc1afd0db0355
Pikne [Wed, 12 Apr 2017 06:33:03 +0000 (06:33 +0000)]
Change File namespace name
Set File namespace name for Estonian to literal translation "Fail" ('file') and set previous name "Pilt" ('image') as a namespace alias.
Bug: T162744
Change-Id: Id9616825f8335f512ccfeca167ddeef42d0220c3
Aaron Schulz [Fri, 24 Feb 2017 16:17:16 +0000 (08:17 -0800)]
Move DB errors to Rdbms namespace
Change-Id: I463bd86123501abc68fdb78b4cda6110f7af2549
Matěj Suchánek [Sat, 15 Apr 2017 15:21:10 +0000 (15:21 +0000)]
Support GENDER in the message "sp-contributions-userrights"
Bug: T130960
Change-Id: Iab6418c6c60c94a0c77e25243e83d1a13b7ca6e0
Translation updater bot [Sat, 15 Apr 2017 07:56:12 +0000 (09:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I077d94de0c0681f31bac6aab7257151eb8b76fec
Aaron Schulz [Fri, 14 Apr 2017 01:59:39 +0000 (18:59 -0700)]
Clarify getLaggedReplicaMode()/laggedReplicaUsed() in LoadBalancer
Change-Id: I4ea9033d2d643c6758c49f34a69c9837598eea33
Antoine Musso [Fri, 14 Apr 2017 14:51:27 +0000 (16:51 +0200)]
media: Capture stderr when running 'convert --version'
At Wikimedia, $wgImageMagickConvertCommand points to a shell wrapper
that invokes ImageMagick convert with:
firejail --profile=/etc/firejail/mediawiki-converters.profile
firejail emits to stderr an information message:
Reading profile /etc/firejail/mediawiki-converters.profile
That ends up in HHVM stderr and is populated up to logstash as an error.
MediaWiki does check imagemagick version by running `convert -version`,
switch from wfShellExec() to wfShellExecWithStderr().
Bug: T158649
Change-Id: I78d1ef59533c605f59b42e10556bb595d6c2cc15
Paladox [Mon, 20 Mar 2017 19:25:36 +0000 (19:25 +0000)]
build: Update karma to 1.5.0, karma-firefox-launcher to 1.0.1
karma:
Changelog at https://github.com/karma-runner/karma/releases
https://github.com/karma-runner/karma/compare/v1.1.0...v1.5.0
karma-firefox-launcher:
Changelog at https://github.com/karma-runner/karma-firefox-launcher/blob/master/CHANGELOG.md#101-2017-03-04
https://github.com/karma-runner/karma-firefox-launcher/compare/v1.0.0...v1.0.1
Karma v1.1.1 added use of `<script crossorigin="anonymous">` for
the urls it initially loads. While most requests will be done by
MW itself directly (and served locally via the proxy at /w/) the
initial request cannot come from the proxy and is loaded from wgServer
directly. Therefore we need to set crossOriginAttribute=false to override
the new default that v1.1.1 introduced.
Change-Id: I9f5067b949c0a77e46f47c2a110a7b5df5953fda
jenkins-bot [Sat, 15 Apr 2017 02:11:02 +0000 (02:11 +0000)]
Merge "phpunit: Make LogFormatterTest less slow"
jenkins-bot [Sat, 15 Apr 2017 02:06:33 +0000 (02:06 +0000)]
Merge "qunit: Improve testrunner logging for pending ajax"
jenkins-bot [Sat, 15 Apr 2017 00:37:35 +0000 (00:37 +0000)]
Merge "Add grep infos to Parser::getImageParams"
Timo Tijhof [Sat, 15 Apr 2017 00:12:06 +0000 (17:12 -0700)]
qunit: Improve testrunner logging for pending ajax
* Move `restoreWarnings()` in tearDown() to the mirrored location
of related code in setUp().
* Ensure that accidentally calling `suppressWarnings()` twice will
not wipe out the original reference indefinitely. If it was
already set, subsequent calls should do nothing instead of
overwriting them again so that recovery is still possible.
* Log all ajax requests logged during the test, not just the
one currently still pending. This should avoid situations
where we throw "Pending ajax requests" but no information
is logged about which requests those might be.
Change-Id: I900ad98c4c8520bdd6ae00a24ac82272f3becfee
Timo Tijhof [Fri, 14 Apr 2017 23:13:39 +0000 (16:13 -0700)]
phpunit: Make LogFormatterTest less slow
Right now it's quite slow because it reloads LocalisationCache
for every test case.
Change the reload to only happen once for the entire class.
Also use RequestContext instead of wgLang to match logic in
the parent class (MediaWikiLangTestCase).
$ phpunit includes/logging/LogFormatterTest.php
Before
- run 1) Time: 23.56 seconds, Memory: 48.00MB
- run 2) Time: 22.41 seconds, Memory: 48.75MB
After
- run 1) Time: 14.27 seconds, Memory: 47.50MB
- run 2) Time: 13.45 seconds, Memory: 47.25MB
Change-Id: Ia791563ca9094c36782acfe9826def45f2a1d621
Umherirrender [Fri, 14 Apr 2017 21:42:15 +0000 (23:42 +0200)]
Add grep infos to Parser::getImageParams
Comments for grep makes searching easier
Change-Id: I98e93baf6bd89df36185d535d6e63c51c6f65bc9
Derk-Jan Hartman [Fri, 14 Apr 2017 13:24:41 +0000 (15:24 +0200)]
Avoid overflowing of unbreakable words in interwiki search results
The interwiki search results can be pretty narrow, and longer
unbreakable words or titles in the results might easily overflow the
containing box. break-word fixes all that.
Change-Id: I97e2b101433bde50a0aa48b772b2fe5a7157aed4
Aaron Schulz [Fri, 14 Apr 2017 02:15:42 +0000 (19:15 -0700)]
Fix some LoadBalancer::waitFor*() inconsistencies
* Make sure waitFor() always handles laggedReplicaMode updates,
even if the actual waiting was deferred until a connection was
needed.
* Restore the old mWaitForPos in waitForOne()/waitForAll() since
this do not care about the generic reader index or the sort of
ChronologyProtector logic related to it.
Change-Id: I0767e9831b8fd7fd115a472354977e3c1e12114a
Moriel Schottlender [Fri, 14 Apr 2017 00:10:11 +0000 (17:10 -0700)]
RCFilters: Remove 'overflow:hidden' from filter header
This will make it possible to z-index it on top of the list
for other elements (like the guided tour 'pulsing dot') to appear
on top of the list.
Bug: T162971
Change-Id: Iac3b8eabdeaee009b65c7b0c104179c760705306
jenkins-bot [Thu, 13 Apr 2017 22:48:50 +0000 (22:48 +0000)]
Merge "RCFilters: Followup I42be06913: Destroy tag widget when removing"
Moriel Schottlender [Thu, 13 Apr 2017 22:01:25 +0000 (15:01 -0700)]
RCFilters: Followup I42be06913: Destroy tag widget when removing
Change-Id: Ifa051dd88dd36fa8ab14eacbeaea49f9aa0dbcdc