Merge "SpecialLog: Don't ignore offender when it's a nonexistent username"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 18 Jan 2018 03:09:53 +0000 (03:09 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 18 Jan 2018 03:09:53 +0000 (03:09 +0000)
includes/specials/SpecialLog.php

index 511cfbf..de3fd19 100644 (file)
@@ -79,10 +79,12 @@ class SpecialLog extends SpecialPage {
                $qc = [];
                if ( $opts->getValue( 'type' ) == 'suppress' ) {
                        $offender = User::newFromName( $opts->getValue( 'offender' ), false );
-                       if ( $offender && $offender->getId() > 0 ) {
-                               $qc = [ 'ls_field' => 'target_author_id', 'ls_value' => $offender->getId() ];
-                       } elseif ( $offender && IP::isIPAddress( $offender->getName() ) ) {
-                               $qc = [ 'ls_field' => 'target_author_ip', 'ls_value' => $offender->getName() ];
+                       if ( $offender ) {
+                               if ( $offender->getId() > 0 ) {
+                                       $qc = [ 'ls_field' => 'target_author_id', 'ls_value' => $offender->getId() ];
+                               } else {
+                                       $qc = [ 'ls_field' => 'target_author_ip', 'ls_value' => $offender->getName() ];
+                               }
                        }
                } else {
                        // Allow extensions to add relations to their search types