From: Bryan Tong Minh <btongminh@users.mediawiki.org>
Date: Sun, 24 Oct 2010 15:24:04 +0000 (+0000)
Subject: (bug 23934) Groups defined in $wgRevokePermissions but not in $wgGroupPermissions... 
X-Git-Tag: 1.31.0-rc.0~34339
X-Git-Url: http://git.cyclocoop.org/%7B%7B%20url_for%28%27admin_vote_add%27%29%20%7D%7D?a=commitdiff_plain;h=8befd5282b3fe99a6f30681d5e6dd64e87e0fe32;p=lhc%2Fweb%2Fwiklou.git

(bug 23934) Groups defined in $wgRevokePermissions but not in $wgGroupPermissions now appear on Special:ListGroupRights
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 50d6c46e3a..81594ba602 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -360,6 +360,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 25462) Fix double-escaping for section edit link tooltips
 * action=raw was removed for Special:Statistics. This information is still
   available via the API
+* (bug 23934) Groups defined in $wgRevokePermissions but not in
+  $wgGroupPermissions now appear on Special:ListGroupRights
 
 === API changes in 1.17 ===
 * (bug 22738) Allow filtering by action type on query=logevent.
diff --git a/includes/specials/SpecialListgrouprights.php b/includes/specials/SpecialListgrouprights.php
index e1294a922f..072b37d45a 100644
--- a/includes/specials/SpecialListgrouprights.php
+++ b/includes/specials/SpecialListgrouprights.php
@@ -60,7 +60,11 @@ class SpecialListGroupRights extends SpecialPage {
 				'</tr>'
 		);
 
-		foreach( $wgGroupPermissions as $group => $permissions ) {
+		$allGroups = array_merge( array_keys( $wgGroupPermissions ), 
+				array_keys( $wgRevokePermissions ) );
+		foreach ( $allGroups as $group ) {
+			$permissions = isset( $wgGroupPermissions[$group] ) ? 
+					$wgGroupPermissions[$group] : array();
 			$groupname = ( $group == '*' ) ? 'all' : $group; // Replace * with a more descriptive groupname
 
 			$msg = wfMsg( 'group-' . $groupname );