From: Alexandre Emsenhuber <ialex.wiki@gmail.com>
Date: Fri, 12 Oct 2012 06:36:47 +0000 (+0200)
Subject: Use Linker::link() instead of Linker::linkKnown() when having options
X-Git-Tag: 1.31.0-rc.0~21914^2
X-Git-Url: http://git.cyclocoop.org/%7B%7B%20url_for%28%27admin_vote_add%27%29%20%7D%7D?a=commitdiff_plain;h=5787cbc7d7aad5336522e21afa58953b6a7faecd;p=lhc%2Fweb%2Fwiklou.git

Use Linker::link() instead of Linker::linkKnown() when having options

Linker::linkKnown() with options is useless and confusing, since in
this case options set by Linker::linkKnown() are simply overridden.

Change-Id: I079f0ed5a7365e2dd22b8de27d0d36ca859b4bf4
---

diff --git a/includes/specials/SpecialNewpages.php b/includes/specials/SpecialNewpages.php
index bd7b41fd2f..08d1517f8f 100644
--- a/includes/specials/SpecialNewpages.php
+++ b/includes/specials/SpecialNewpages.php
@@ -325,12 +325,13 @@ class SpecialNewpages extends IncludableSpecialPage {
 			$query['rcid'] = $result->rc_id;
 		}
 
-		$plink = Linker::linkKnown(
+		// Linker::linkKnown() uses 'known' and 'noclasses' options. This breaks the colouration for stubs.
+		$plink = Linker::link(
 			$title,
 			null,
 			array( 'class' => 'mw-newpages-pagename' ),
 			$query,
-			array( 'known' ) // Set explicitly to avoid the default of 'known','noclasses'. This breaks the colouration for stubs
+			array( 'known' )
 		);
 		$histLink = Linker::linkKnown(
 			$title,