jenkins-bot [Fri, 16 Sep 2016 01:45:33 +0000 (01:45 +0000)]
Merge "API: Force straight join for prop=linkshere|transcludedin|fileusage"
jenkins-bot [Fri, 16 Sep 2016 01:44:00 +0000 (01:44 +0000)]
Merge "Make DB snapshot commit errors include active methods"
jenkins-bot [Fri, 16 Sep 2016 01:34:01 +0000 (01:34 +0000)]
Merge "mediawiki.user: Minor clean up of code and unit tests"
jenkins-bot [Fri, 16 Sep 2016 01:25:53 +0000 (01:25 +0000)]
Merge "Avoid global state in DatabaseBase::factory()/query()"
jenkins-bot [Fri, 16 Sep 2016 01:04:07 +0000 (01:04 +0000)]
Merge "Remove wfSetBit()/wfSetVar() calls in DatabaseBase"
Aaron Schulz [Thu, 15 Sep 2016 17:51:13 +0000 (10:51 -0700)]
Remove wfSetBit()/wfSetVar() calls in DatabaseBase
Change-Id: I4f1269d3a4e26c766f181208942042fdf768e0af
jenkins-bot [Fri, 16 Sep 2016 00:44:35 +0000 (00:44 +0000)]
Merge "Remove wfRandomString() dependency in DatabaseBase"
jenkins-bot [Fri, 16 Sep 2016 00:41:43 +0000 (00:41 +0000)]
Merge "Move LoadMonitorMySQL to LoadMonitor"
jenkins-bot [Fri, 16 Sep 2016 00:41:12 +0000 (00:41 +0000)]
Merge "Move database constants to their own file"
Aaron Schulz [Thu, 15 Sep 2016 09:21:21 +0000 (02:21 -0700)]
Avoid global state in DatabaseBase::factory()/query()
Change-Id: Ibb4f1c0dafea071a1c34e0cd5b5c15b8b4bb7bc6
Aaron Schulz [Wed, 14 Sep 2016 17:09:36 +0000 (10:09 -0700)]
Make DB snapshot commit errors include active methods
Change-Id: I59e501528b104e797b36103fa18792f539d92a14
Aaron Schulz [Thu, 15 Sep 2016 22:02:53 +0000 (15:02 -0700)]
Remove wfRandomString() dependency in DatabaseBase
Change-Id: I9a889e120bd665683e53dfbc8729a7c484ea507c
Timo Tijhof [Fri, 16 Sep 2016 00:05:25 +0000 (17:05 -0700)]
mediawiki.user: Minor clean up of code and unit tests
* Clarify getRegistration() return documentation and minor
optimisation of code order.
* Fix typo in test name for getUserInfo().
* Remove redundant test expect numbers.
Follows-up
7c363752ed.
* Separate getter assertions for anonymous and logged-in.
Avoid changing the fixture mid-test. Let setup/teardown
clean up in the middle.
Change-Id: If777d44a571ac590e91ed84060ea714df67f8f2f
Aaron Schulz [Thu, 15 Sep 2016 23:17:40 +0000 (16:17 -0700)]
Move database constants to their own file
Change-Id: I47e067687bbce7b89e02a0e732ee27368beddb61
jenkins-bot [Fri, 16 Sep 2016 00:21:43 +0000 (00:21 +0000)]
Merge "Remove wfGetCaller() dependency from DatabaseBase"
jenkins-bot [Fri, 16 Sep 2016 00:17:30 +0000 (00:17 +0000)]
Merge "resourceloader: Set a Title on context-created messages"
jenkins-bot [Fri, 16 Sep 2016 00:16:45 +0000 (00:16 +0000)]
Merge "Deprecate jquery.arrowSteps module"
Aaron Schulz [Thu, 15 Sep 2016 05:38:47 +0000 (22:38 -0700)]
Move LoadMonitorMySQL to LoadMonitor
* The LoadMonitor interface is now ILoadMonitor.
* Nothing in this code was MySQL specific.
Now any DB type can benefit from a LoadMonitor.
Change-Id: I272a72cd55a70f99a866d518d44cb3bcaca91b9e
jenkins-bot [Thu, 15 Sep 2016 23:09:45 +0000 (23:09 +0000)]
Merge "Infrastructure for augmenting search results"
Stanislav Malyshev [Tue, 26 Apr 2016 22:19:58 +0000 (15:19 -0700)]
Infrastructure for augmenting search results
Bug: T117493
Change-Id: Ia5413a7846cc961026a2dc3542b619493bc76a23
Kunal Mehta [Thu, 15 Sep 2016 22:41:11 +0000 (15:41 -0700)]
Add one more level for GlobalTitleFail logging
htmlspecialchars/Message->__toString/Message->toString/Message->parseText/MessageCache->parse
is useless without the caller of htmlspecialchars().
Change-Id: I2dad5a487225a11b98149610f1c775057f8baad2
Kunal Mehta [Thu, 15 Sep 2016 22:11:59 +0000 (15:11 -0700)]
resourceloader: Set a Title on context-created messages
Ensure that messages created using ResourceLoaderContext::msg() have a
title set so they don't trigger the GlobalTitleFail log. We use a dummy
title since there is no real title we can use here, and the cache
doesn't vary on a title anyways. This particular title was picked
especially for Roan.
This patch should quiet the GlobalTitleFail logs for
MFResourceLoaderParsedMessageModule and VisualEditorDataModule.
Change-Id: I502faa22776e1cb34a6ef17be96567f121c80081
Chad Horohoe [Wed, 7 Sep 2016 17:28:13 +0000 (10:28 -0700)]
EditPage: Generate all messages using $this->context so we have titles
Change-Id: I5ba13f1677e1a1b4160e14357a483b5e1f11ea1c
Aaron Schulz [Thu, 15 Sep 2016 21:40:00 +0000 (14:40 -0700)]
Remove wfGetCaller() dependency from DatabaseBase
Change-Id: I3e240b2eb5c1f6a21f1bc974c3d28f5755c7451a
jenkins-bot [Thu, 15 Sep 2016 21:38:10 +0000 (21:38 +0000)]
Merge "Replace WikiPage::doEdit() usages"
jenkins-bot [Thu, 15 Sep 2016 21:10:53 +0000 (21:10 +0000)]
Merge "Allow quotes in $wgDebugComments HTML comments"
L10n-bot [Thu, 15 Sep 2016 20:25:54 +0000 (20:25 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Reedy [Thu, 15 Sep 2016 20:13:22 +0000 (21:13 +0100)]
Replace WikiPage::doEdit() usages
Update/add some comments
Bug: T145737
Change-Id: Ib3b2b69906074cbb51917dc57204c989fd6c58b2
jenkins-bot [Thu, 15 Sep 2016 20:23:27 +0000 (20:23 +0000)]
Merge "benchmarkParse: Add option to clear link cache"
jenkins-bot [Thu, 15 Sep 2016 20:20:32 +0000 (20:20 +0000)]
Merge "Emit deprecation warnigns for Article::getText()"
jenkins-bot [Thu, 15 Sep 2016 20:18:46 +0000 (20:18 +0000)]
Merge "Linker: Deprecate formatSize()"
Translation updater bot [Thu, 15 Sep 2016 20:18:46 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic6504bfa03dfb50c40231151255bc0297f28275c
Aaron Schulz [Thu, 15 Sep 2016 19:53:43 +0000 (12:53 -0700)]
Allow quotes in $wgDebugComments HTML comments
Change-Id: Id1fbab9ad3d6d645b6efea1d1e66a18ab4fe0b89
jenkins-bot [Thu, 15 Sep 2016 18:43:22 +0000 (18:43 +0000)]
Merge "Fix default "srvCache" BagOStuff in DatabaseBase"
jenkins-bot [Thu, 15 Sep 2016 18:19:14 +0000 (18:19 +0000)]
Merge "Dependency inject $wgSharedTables into DatabaseBase"
Aaron Schulz [Thu, 15 Sep 2016 17:07:47 +0000 (10:07 -0700)]
Dependency inject $wgSharedTables into DatabaseBase
Change-Id: I3e659b56c587d2059fc3d3f922bc38dec7685df4
Aaron Schulz [Thu, 15 Sep 2016 18:06:31 +0000 (11:06 -0700)]
Fix default "srvCache" BagOStuff in DatabaseBase
Follow up to
4660b56f
Change-Id: I19975ce66ddc318fd494d5c4a3807c62d04fad70
jenkins-bot [Thu, 15 Sep 2016 17:55:14 +0000 (17:55 +0000)]
Merge "Move updater/installer specific methods out of DatabaseBase"
jenkins-bot [Thu, 15 Sep 2016 17:39:35 +0000 (17:39 +0000)]
Merge "Rename LBFactory => LBFactoryMW and make LBFactory in /libs"
jenkins-bot [Thu, 15 Sep 2016 17:35:50 +0000 (17:35 +0000)]
Merge "docs: mw.widgets.CategorySelector: Fix example code"
Aaron Schulz [Wed, 14 Sep 2016 11:34:17 +0000 (04:34 -0700)]
Rename LBFactory => LBFactoryMW and make LBFactory in /libs
The former extends the later with MW-specific logic.
Also removed a wf* method call from ChronologyProtector.
Change-Id: I325f59b7467ab9c2137731d1ce69816f5a020f03
jenkins-bot [Thu, 15 Sep 2016 17:09:34 +0000 (17:09 +0000)]
Merge "Remove global state from DatabaseBase::__construct()"
jenkins-bot [Thu, 15 Sep 2016 16:52:10 +0000 (16:52 +0000)]
Merge "Move Linker::formatTemplates() to separate class, remove global usage"
jenkins-bot [Thu, 15 Sep 2016 16:39:36 +0000 (16:39 +0000)]
Merge "Fix broken wincache merge() implementation"
jenkins-bot [Thu, 15 Sep 2016 16:39:32 +0000 (16:39 +0000)]
Merge "OutputPage: Don't set 'user' module state if filtered out"
jenkins-bot [Thu, 15 Sep 2016 16:36:51 +0000 (16:36 +0000)]
Merge "Revert "Remove jquery.arrowSteps module""
Bartosz Dziewoński [Thu, 15 Sep 2016 16:29:14 +0000 (16:29 +0000)]
Deprecate jquery.arrowSteps module
Bug: T144974
Change-Id: I765902082e6a71ca69983a2e67dcc856ad8b6ca8
Bartosz Dziewoński [Thu, 15 Sep 2016 16:28:42 +0000 (16:28 +0000)]
Revert "Remove jquery.arrowSteps module"
It should probably be deprecated first after all.
This reverts commit
6fba9a7dc6ac969676c57f85b09bbdac9067a2bd.
Bug: T144974
Change-Id: I830fbfc2e453be6b18d43775a8aa1a366690907c
jenkins-bot [Thu, 15 Sep 2016 13:02:29 +0000 (13:02 +0000)]
Merge "Set fallback language for lzh to zh-hant"
zppix1 [Thu, 11 Aug 2016 21:31:17 +0000 (16:31 -0500)]
Change wording, change grammar in lang/en.json
Bug: T142756
Depends-On: I233ce58fd82a1dbc57b3ab58ce669b23a5781b57
Change-Id: I164d397d6ea41ea6b88bb0d84604b52419dadd0f
Aaron Schulz [Thu, 15 Sep 2016 11:50:25 +0000 (04:50 -0700)]
Fix broken wincache merge() implementation
Bug: T145664
Change-Id: I2f841779108df281e24003c586775b71aa176909
zppix1 [Sat, 30 Jul 2016 23:06:28 +0000 (18:06 -0500)]
Cleaned up some un needed wording in the English i18n file
Changed messages:
* noindex-category
* morenotlisted
Change-Id: I233ce58fd82a1dbc57b3ab58ce669b23a5781b57
Aaron Schulz [Thu, 15 Sep 2016 11:22:57 +0000 (04:22 -0700)]
Remove global state from DatabaseBase::__construct()
Change-Id: Iba347fce8f0f531aa7e565bb8806260bcbf04a98
MarcoAurelio [Tue, 2 Aug 2016 09:27:55 +0000 (11:27 +0200)]
Set fallback language for lzh to zh-hant
Bug: T125373
Change-Id: Ie39d03efce0997c928ac0bc7f4a97ee8e047df45
Aaron Schulz [Thu, 15 Sep 2016 09:25:16 +0000 (02:25 -0700)]
Move updater/installer specific methods out of DatabaseBase
Change-Id: I995799fc15d2797ce7ab9ce2aca8beeef409447c
Kunal Mehta [Thu, 15 Sep 2016 08:45:43 +0000 (01:45 -0700)]
Emit deprecation warnigns for Article::getText()
Deprecated since 1.21.
Bug: T145747
Change-Id: I6fe620702fcc455dbe229abca1145b0c8ea3f8d2
Kunal Mehta [Thu, 15 Sep 2016 06:55:35 +0000 (23:55 -0700)]
benchmarkParse: Add option to clear link cache
For performance testing the lookup of links (e.g. LinkHolderArray),
allow resetting the LinkCache after every parse.
Change-Id: I75c2cad9a8cf1b41d192708773194f799673ce83
Aaron Schulz [Thu, 15 Sep 2016 05:02:43 +0000 (22:02 -0700)]
Remove unused LBFactoryFake class
Change-Id: I88acf72fc32c7e3c9bead81d11c5adfd8dff6151
jenkins-bot [Thu, 15 Sep 2016 04:26:27 +0000 (04:26 +0000)]
Merge "Avoid MWException and wf* log methods in DatabaseBase"
Aaron Schulz [Thu, 15 Sep 2016 01:37:35 +0000 (18:37 -0700)]
Avoid MWException and wf* log methods in DatabaseBase
Change-Id: Idc418ae1088f87d6416e2552976d94f7d1e8f5db
Aaron Schulz [Wed, 14 Sep 2016 10:11:41 +0000 (03:11 -0700)]
Move various DB helper classes to /libs/rdbms
Change-Id: I0724f1acce4f6c43b1f0983fa119e628e7c53ba5
Aaron Schulz [Wed, 14 Sep 2016 09:40:29 +0000 (02:40 -0700)]
Move LoadBalancer to /libs/rdbms
Change-Id: Ic87f1cc84ba44be20f345944406e1d8a34be1c96
Aaron Schulz [Thu, 15 Sep 2016 02:04:21 +0000 (19:04 -0700)]
Change DatabaseBase => IDatabase in /db where possible
Change-Id: Ia0a049cd4294c5a39aa9ed228d4eb5b15736ea1f
jenkins-bot [Thu, 15 Sep 2016 02:24:05 +0000 (02:24 +0000)]
Merge "Change $wiki => $domain in LoadBalancer"
jenkins-bot [Thu, 15 Sep 2016 02:19:03 +0000 (02:19 +0000)]
Merge "Exception cleanups for LoadBalancer"
Aaron Schulz [Thu, 15 Sep 2016 02:13:41 +0000 (19:13 -0700)]
Change $wiki => $domain in LoadBalancer
Change-Id: I97f96383c501e9b3262c11d143795b82ae36aca5
Timo Tijhof [Wed, 14 Sep 2016 22:51:05 +0000 (15:51 -0700)]
phpunit: Simplify mock object syntax in includes/db/ tests
* Omit redundant `expects( $this->any() )`.
* Use willReturn() instead of `will( $this->returnValue() )`.
Change-Id: If90ac651748af8a78a720992240e40ba53cec79c
Aaron Schulz [Wed, 14 Sep 2016 09:28:18 +0000 (02:28 -0700)]
Exception cleanups for LoadBalancer
* Make the error message itself be dumb/raw.
* Make the exception exposer show the same GUI message.
* Remove overzelous wgLang check in MWExceptionRenderer.
Change-Id: Ifffff3b3cc785ea3080e4975efe33b3c2cf304d6
jenkins-bot [Thu, 15 Sep 2016 00:46:03 +0000 (00:46 +0000)]
Merge "Move DBConnRef and ChronologyProtector to /libs/rdbms"
jenkins-bot [Thu, 15 Sep 2016 00:43:34 +0000 (00:43 +0000)]
Merge "Move TransactionProfiler to /libs/rdbms"
jenkins-bot [Thu, 15 Sep 2016 00:31:04 +0000 (00:31 +0000)]
Merge "Make WikiPage::getRevision() make use of Revision::newKnownCurrent()"
Aaron Schulz [Wed, 14 Sep 2016 09:21:18 +0000 (02:21 -0700)]
Move DBConnRef and ChronologyProtector to /libs/rdbms
Change-Id: If2c4b314a5c39311328843f534d91bf90823e179
jenkins-bot [Thu, 15 Sep 2016 00:15:15 +0000 (00:15 +0000)]
Merge "More DB related class cleanups to prepare files for /libs"
jenkins-bot [Thu, 15 Sep 2016 00:09:16 +0000 (00:09 +0000)]
Merge "Re-add parser tests to the ParserTests group"
jenkins-bot [Thu, 15 Sep 2016 00:09:12 +0000 (00:09 +0000)]
Merge "Fix broken select() call in rebuildFileCache.php"
Aaron Schulz [Wed, 14 Sep 2016 07:22:35 +0000 (00:22 -0700)]
More DB related class cleanups to prepare files for /libs
* Cleaned up some related logging bits.
* Avoid some wf* methods in LoadBalancer.
Change-Id: I5da97174441c086e61ffc120889c068e241ebfd2
Aaron Schulz [Wed, 14 Sep 2016 23:57:54 +0000 (16:57 -0700)]
Make WikiPage::getRevision() make use of Revision::newKnownCurrent()
Change-Id: Id06319b31bc523a5d514930c3d609af4d991453b
jenkins-bot [Wed, 14 Sep 2016 23:54:00 +0000 (23:54 +0000)]
Merge "Move IDatabase/ILoadBalancer to /libs/rdbms"
jenkins-bot [Wed, 14 Sep 2016 23:42:43 +0000 (23:42 +0000)]
Merge "mediawiki.Upload.BookletLayout: Fix typo in comment"
Tim Starling [Wed, 14 Sep 2016 23:37:06 +0000 (09:37 +1000)]
Re-add parser tests to the ParserTests group
It was omitted due to the new way in which parser test TestCase objects
are constructed. Should fix Jenkins double-execution of parser tests.
Change-Id: I8131c3b13f2e08f784bce46fee16051c14761304
Aaron Schulz [Wed, 14 Sep 2016 07:19:30 +0000 (00:19 -0700)]
Move IDatabase/ILoadBalancer to /libs/rdbms
Change-Id: I71f980b1024dc2fbca9cafbad2c9daebb6f28c9b
Aaron Schulz [Wed, 14 Sep 2016 16:16:06 +0000 (09:16 -0700)]
Make SiteStatsUpdate implement MergeableUpdate
Change-Id: I53c9bf133f0707f2fa203ddd1a7fcb65be8b1329
Timo Tijhof [Wed, 14 Sep 2016 22:58:44 +0000 (15:58 -0700)]
mediawiki.Upload.BookletLayout: Fix typo in comment
Follows-up
33041b752d.
Change-Id: I50747f140d6c0a42385aa94c8827f8ff7354628d
Timo Tijhof [Wed, 14 Sep 2016 21:14:31 +0000 (14:14 -0700)]
resourceloader: Fix WikiModule preload to support localised titles
Follows-up
6f8dc27ca2 and
dbd11e04aa. You'd expect a bug in preloading
to fallback to fetching it on-demand but due to a title format mismatch
the preload method did use the same title format for the cache key, but
not the same title format for discovering the results. As such, it set
the right cache key to an empty array.
* Make relevant methods testable and mockable.
* Add regression test.
* Change call to array_interect_key to use the same format as
fetchTitleInfo(): Normalised title keys from Title::getPrefixedText.
Previously, the intersect used the declared titles from getPages() which
are not localised - causing an empty array to be returned from the
intersect on wikis where the namespace name is localised.
Bug: T145673
Change-Id: Ibe788157724d73c727b9e2127b6828db32ca9420
Aaron Schulz [Wed, 14 Sep 2016 19:37:36 +0000 (12:37 -0700)]
Fix broken select() call in rebuildFileCache.php
A few other small cleanups
Change-Id: Ie62cf93feb5a57f629a893c7ea298ed902b52789
L10n-bot [Wed, 14 Sep 2016 20:07:35 +0000 (20:07 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Wed, 14 Sep 2016 20:00:21 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iee268ac310eb4a09e6df11ca71a9a71a7d8b19e5
jenkins-bot [Wed, 14 Sep 2016 20:00:17 +0000 (20:00 +0000)]
Merge "Move DBError to /libs/rdbms/exception"
jenkins-bot [Wed, 14 Sep 2016 19:21:08 +0000 (19:21 +0000)]
Merge "Add MWExceptionRenderer class and decouple DBError"
jenkins-bot [Wed, 14 Sep 2016 19:18:32 +0000 (19:18 +0000)]
Merge "Reduce WikiPage::getContentModel() queries via caching"
jenkins-bot [Wed, 14 Sep 2016 19:14:40 +0000 (19:14 +0000)]
Merge "Add caching to Title::loadRestrictions()"
Aaron Schulz [Wed, 14 Sep 2016 18:55:33 +0000 (11:55 -0700)]
Move DBError to /libs/rdbms/exception
Change-Id: I2ad40db66a68f03fb34a63278a652e0505195076
Aaron Schulz [Wed, 14 Sep 2016 03:57:54 +0000 (20:57 -0700)]
Add MWExceptionRenderer class and decouple DBError
* This handles the work of showing exceptions so that
MWException does not have too.
* Simplify the DBError classes to regular Exception
classes. Lots of pointless prettification has been
removed, but DBConnectionError still gets the usual
special treatment of a fallback page and Google form.
* Remove hacky file cache fallback code that probably
did not work.
* Make MWExceptionHandler::report() wrap
MWExceptionExposer::output().
* Make MWException::runHooks() wrap
MWExceptionExposer::runHooks().
Change-Id: I5dfdc84e94ddac65417226cf7c84513ebb9f9faa
Kunal Mehta [Wed, 14 Sep 2016 18:12:14 +0000 (11:12 -0700)]
ParserOptions: Remove setters for magic links options
This will allow clients to assume that the global configuration state
($wgEnableMagicLinks) is the same as the state in ParserOptions, fixing
some consistency issues in wfEscapeWikiText() and Scribunto. The
abstraction for the ParserOptions getters is still useful because it
keeps the global state out of the Parser.
Change-Id: Ic2c447443963eb336c786cacf9dfd041a2df3b77
jenkins-bot [Wed, 14 Sep 2016 16:36:59 +0000 (16:36 +0000)]
Merge "API: Deprecate use of ApiPurge via GET"
jenkins-bot [Wed, 14 Sep 2016 15:58:36 +0000 (15:58 +0000)]
Merge "API: Expose $wgEnableMagicLinks in meta=siteinfo"
jenkins-bot [Wed, 14 Sep 2016 15:33:07 +0000 (15:33 +0000)]
Merge "Fix login API for users with @ in their usernames"
Brad Jorsch [Wed, 14 Sep 2016 15:04:33 +0000 (11:04 -0400)]
API: Deprecate use of ApiPurge via GET
This emits a warning and logs feature usage, and also pretends that POST
is required in the help and paraminfo output.
Bug: T145649
Change-Id: Ied8d47a947662158fddab383c764bf70c5ab0112
Brad Jorsch [Wed, 14 Sep 2016 14:13:10 +0000 (10:13 -0400)]
API: Force straight join for prop=linkshere|transcludedin|fileusage
MySQL (or at least 5.5.5-10.0.23-MariaDB) chooses a really bad query plan if it
thinks there will be more matching rows in the linktable than are in page. Use
STRAIGHT_JOIN here to force it to use the intended, fast plan. See T145079 for
details.
Bug: T145079
Change-Id: I1a363450b818a049938145d0feb207c9894d2a49
Aaron Schulz [Wed, 14 Sep 2016 12:18:57 +0000 (05:18 -0700)]
Move TransactionProfiler to /libs/rdbms
Change-Id: I13173facc9f101bca69e3bf3e85f292f8468e855