Krinkle [Sat, 21 Jan 2012 13:31:51 +0000 (13:31 +0000)]
[Resources] Add missing or implied dependencies
* mediawiki.action.watch.ajax:
-- Depends on mediawiki.api.watch>mediawiki.api>mediawiki.util
-- But also uses mw.util itself, so adding it here as well. mw.Api might one day not use mw.util
* mediawiki.special.block: Uses mw.util.isIPv4Address / mw.util.isIPv6Address
* mediawiki.special.changeemail: Uses mw.util.validateEmail
* mediawiki.legacy.upload: Uses mw.util.wikiScript
* Uses mw.util.wikiUrlencode
Commit is inspired by and a superset of the patch provided by Rainer@Rillke.eu at bug 33760.
Alexandre Emsenhuber [Sat, 21 Jan 2012 07:59:25 +0000 (07:59 +0000)]
Fix bug 32948:
* {{REVISIONID}} and related variables are no longer blank after doing a null edit
* {{REVISIONID}} and related variables are no longer blank after calling action=purge&forcelinkupdate
Krinkle [Sat, 21 Jan 2012 06:57:34 +0000 (06:57 +0000)]
Reinstate r109223 per CR + fixes
* Action/Context stuff is pretty deeply nested everywhere.
* Should be okay now, at last.
* Reverts reverting r109243
* Same as r109223, except adding this:
+ if ( !$context->canUseWikiPage() ) {
+ return 'view';
+ }
Krinkle [Sat, 21 Jan 2012 06:18:38 +0000 (06:18 +0000)]
[JSTesting] update QUnit html
* Through all QUnit updates, the html was never updated (only the JS/CSS files). Updating html now according to QUnit documentation. (introduced a new html element used for adding test document elements which are automatically cleaned up. the JS/CSS for QUnit was already referring to this but silently failing)
Aaron Schulz [Sat, 21 Jan 2012 00:04:09 +0000 (00:04 +0000)]
* r109659: actually return the exact type we say we do
* Made use of FileRepo::cleanupBatch() in ForeignAPIFile::purgeThumbnails()
Aaron Schulz [Fri, 20 Jan 2012 22:46:35 +0000 (22:46 +0000)]
* Added FileBackend::parentStoragePath() convenience function for getting parent directories.
* In StoreBatchTest: sed proper clean() function to remove temp dirs (follows up r109641). Also removed some commented out code.
* Fixed temp dir leakage in FileBackendTest.
Aaron Schulz [Fri, 20 Jan 2012 21:55:15 +0000 (21:55 +0000)]
Make sure FSFileBackend clears the php stat cache in clearCache(). Otherwise it will just clear the FileBackend cache and refetch the same cached data from PHP's stat cache.
Aaron Schulz [Fri, 20 Jan 2012 20:52:09 +0000 (20:52 +0000)]
Similar to r108937: fixed breakage where the zone urls were defined as relative paths.
Raimond Spekking [Fri, 20 Jan 2012 20:41:42 +0000 (20:41 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Platonides [Fri, 20 Jan 2012 20:15:26 +0000 (20:15 +0000)]
Fix folder leakage.
Platonides [Fri, 20 Jan 2012 19:46:27 +0000 (19:46 +0000)]
If you are going to leak folders, at least give them your surname.
Niklas Laxström [Fri, 20 Jan 2012 19:09:55 +0000 (19:09 +0000)]
Can't PHP just DWIM? Ping r109628
Niklas Laxström [Fri, 20 Jan 2012 16:57:46 +0000 (16:57 +0000)]
Reducy query flood in r96546. Allow formatters to provide titles for LinkBatch.
Alexandre Emsenhuber [Fri, 20 Jan 2012 16:12:34 +0000 (16:12 +0000)]
* Inlinise Preferences::loadOldSearchNs() in SearchEngine::userNamespaces(); the latter is the only caller of the former
* Made code clearer and removed duplication
* Marked Preferences::loadOldSearchNs() as deprecated
Niklas Laxström [Fri, 20 Jan 2012 09:44:39 +0000 (09:44 +0000)]
Split LogPager out of LogEventsList.php
Aaron Schulz [Fri, 20 Jan 2012 00:12:20 +0000 (00:12 +0000)]
Message change I forgot to commit in r109583
Krinkle [Thu, 19 Jan 2012 23:52:46 +0000 (23:52 +0000)]
[mediawiki.js] edit comment
* Follows-up r108230
Aaron Schulz [Thu, 19 Jan 2012 23:18:03 +0000 (23:18 +0000)]
* Follow-up r109009: Check that paths are usable in FileOp::doPrecheck(). Also lock parent directories to avoid prepare()/clean() race conditions for FS backends.
* Fixed bogus $params var in logException() call in SwiftFileBackend.
* Added 'latest' param to FileBackendMultliWrite::consistencyCheck().
* Dummy-proof FileBackend::getFileStat() w.r.t the 'latest' param and removed related FileOp::allowStaleReads() comment.
* Tweaked backend-fail-batchsize message from r109469.
Antoine Musso [Thu, 19 Jan 2012 23:06:23 +0000 (23:06 +0000)]
comment wgLocalFileRepo has an example usage in Setup.php
Raimond Spekking [Thu, 19 Jan 2012 21:38:41 +0000 (21:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Thu, 19 Jan 2012 21:12:37 +0000 (21:12 +0000)]
r109562: Register new message key for maintenance script
Sam Reed [Thu, 19 Jan 2012 20:26:10 +0000 (20:26 +0000)]
Followup r109562
Don't use such a naieve host check
Sam Reed [Thu, 19 Jan 2012 19:16:06 +0000 (19:16 +0000)]
* (bug 32341) Add upload by URL domain limitation.
Niklas Laxström [Thu, 19 Jan 2012 19:11:59 +0000 (19:11 +0000)]
Remove extra space, ping r109550
Benny Situ [Thu, 19 Jan 2012 18:22:53 +0000 (18:22 +0000)]
followup to r107187 - Making textarea width to be 100% in all skins
Sam Reed [Thu, 19 Jan 2012 17:27:29 +0000 (17:27 +0000)]
Documentation
Remove unused globals
Antoine Musso [Thu, 19 Jan 2012 17:22:36 +0000 (17:22 +0000)]
design file for nested tables CSS
See:
Bug 33752 - Wikitable uses CSS not supported in IE6
r107669
Sam Reed [Thu, 19 Jan 2012 16:55:42 +0000 (16:55 +0000)]
Add some escaping to r109547, 109548, 109549
Improve RELEASE-NOTES-1.19 also
Sam Reed [Thu, 19 Jan 2012 16:44:49 +0000 (16:44 +0000)]
* (bug 33819) Display filesize on Special:NewFiles in appropriate unit.
Do the same for the rest of the file usages of 'nbytes' in Generic.php
Sam Reed [Thu, 19 Jan 2012 16:41:04 +0000 (16:41 +0000)]
Like r109547, display file size in appropriate units on mimesearch
Sam Reed [Thu, 19 Jan 2012 16:37:54 +0000 (16:37 +0000)]
* (bug 33819) Display filesize on Special:NewFiles in appropriate unit.
Sam Reed [Thu, 19 Jan 2012 16:33:57 +0000 (16:33 +0000)]
Cache gallery object, don't create a new one unless we need to
Make getStartBody return something
Sam Reed [Thu, 19 Jan 2012 15:22:28 +0000 (15:22 +0000)]
Fix stray comma from r109537
Sam Reed [Thu, 19 Jan 2012 14:56:18 +0000 (14:56 +0000)]
Documentation and whitespace
Clearing another w/c
Sam Reed [Thu, 19 Jan 2012 14:17:22 +0000 (14:17 +0000)]
Remove unused globals
Remove pointless continue;
Clearing up w/c
Niklas Laxström [Thu, 19 Jan 2012 11:00:48 +0000 (11:00 +0000)]
Less Title Case
Niklas Laxström [Thu, 19 Jan 2012 11:00:18 +0000 (11:00 +0000)]
12em was too narrow, 18 seems to be better
Niklas Laxström [Thu, 19 Jan 2012 10:58:49 +0000 (10:58 +0000)]
Table headers looked ugly without the same padding as content
Alexandre Emsenhuber [Thu, 19 Jan 2012 10:08:38 +0000 (10:08 +0000)]
Change $wgDebugFunctionEntry's default value from 0 to false; it is supposed to be a boolean, not an integer.
Alexandre Emsenhuber [Thu, 19 Jan 2012 10:05:38 +0000 (10:05 +0000)]
$wgLanguageCode goes with $wgContLang, not $wgLang. This was breaking ApiBlockTest because $wgContLang->getCode() != $wgLanguageCode.
Niklas Laxström [Thu, 19 Jan 2012 09:20:32 +0000 (09:20 +0000)]
Typofix, ping r109446
Aaron Schulz [Thu, 19 Jan 2012 02:26:10 +0000 (02:26 +0000)]
Reverted r109062 per code slush (also has a CR complaint)
Aaron Schulz [Thu, 19 Jan 2012 02:24:49 +0000 (02:24 +0000)]
Renamed 'overwriteDest' FileBackend operation parameter to just 'overwrite', which is shorter and more consistent with 'overwriteSame'
Aaron Schulz [Thu, 19 Jan 2012 02:07:48 +0000 (02:07 +0000)]
In FileBackend/FileOp:
* Added a sane default max file size to FileBackend. Operation batches need to check this before trying anything.
* Temporarily adjust the PHP execution time limit in attemptBatch() to reduce the chance of dying in the middle of it. Also added a maximum batch size limit.
* Added some code comments.
mrbluesky [Thu, 19 Jan 2012 02:04:30 +0000 (02:04 +0000)]
Update comment
mrbluesky [Thu, 19 Jan 2012 01:51:27 +0000 (01:51 +0000)]
Comments on status codes
mrbluesky [Wed, 18 Jan 2012 22:46:26 +0000 (22:46 +0000)]
(bug 32899) Alphabetical sorting for methods and properties in doxygen
mrbluesky [Wed, 18 Jan 2012 22:40:51 +0000 (22:40 +0000)]
Additional doc/comments
Sam Reed [Wed, 18 Jan 2012 21:27:28 +0000 (21:27 +0000)]
Add __METHOD__ to begin/commit
Improve error message from r109433
Sam Reed [Wed, 18 Jan 2012 21:20:50 +0000 (21:20 +0000)]
Just experienced with commons. Dealt with UploadStashBadPathException
path doesn't exist
Backtrace:
#0 /home/wikipedia/common/php-1.18/maintenance/cleanupUploadStash.php(68): UploadStash->getFile('zyvzeiza5hg.xab...', true)
#1 /home/wikipedia/common/php-1.18/maintenance/doMaintenance.php(105): UploadStashCleanup->execute()
#2 /home/wikipedia/common/php-1.18/maintenance/cleanupUploadStash.php(75): require_once('/home/wikipedia...')
#3 /home/wikipedia/common/multiversion/MWScript.php(73): require_once('/home/wikipedia...')
#4 {main}
Raimond Spekking [Wed, 18 Jan 2012 21:07:15 +0000 (21:07 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Wed, 18 Jan 2012 20:01:46 +0000 (20:01 +0000)]
Make time of '-total' item correct if using 'user' time metric
Aaron Schulz [Wed, 18 Jan 2012 19:57:32 +0000 (19:57 +0000)]
In SwiftFileBackend:
* r108944: doCleanInternal() should delete empty containers only if the container dir was given.
* Made doSecureInternal() set container permissions. Also renamed swiftProxyUser -> swiftAnonUser.
* Made doGetFileStat() respect the 'latest' parameter (using r109235).
* Fixed connTTL default and renamed it to authTTL. Also added explicit close() call to getConnection().
* Reduced RTTs in doPrepareInternal() by checking getContainer() first (which is process cached).
* Killed an RTT in doStoreInternal(), doCreateInternal(), and doCopyInternal() by using create_object(). Also cleaned up logic with regards to the destination CF_Object object fields getting preloaded before write().
* Cleanups to getLocalCopy(); only create the tmp file if get_object() succeeds to short-circuits things.
* Made getContainer() limit the container cache size for sanity.
* Simplified doDeleteInternal() code a bit.
* Renamed $destRel => $dstRel for consistency.
Siebrand Mazeland [Wed, 18 Jan 2012 18:20:50 +0000 (18:20 +0000)]
Remove support for the deprecated and no longer used in trunk hook MagicWordMagicWords.
Siebrand Mazeland [Wed, 18 Jan 2012 17:53:04 +0000 (17:53 +0000)]
Update documentation.
Siebrand Mazeland [Wed, 18 Jan 2012 17:43:08 +0000 (17:43 +0000)]
Update documentation as LanguageGetMagic hook is deprecated.
Antoine Musso [Wed, 18 Jan 2012 15:58:25 +0000 (15:58 +0000)]
MWDebugTest: clear log before running tests
Some other test could have added their own logs, for example
deprecated notice. In that case, the first test will fail because
the log array already has some content :-b
Antoine Musso [Wed, 18 Jan 2012 15:50:00 +0000 (15:50 +0000)]
tests: mark tests requiring a database connection
Alexandre Emsenhuber [Wed, 18 Jan 2012 14:48:35 +0000 (14:48 +0000)]
Fix profiling, that function is not profiled
Alexandre Emsenhuber [Wed, 18 Jan 2012 12:10:16 +0000 (12:10 +0000)]
Pass some more __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit()
Antoine Musso [Wed, 18 Jan 2012 10:36:45 +0000 (10:36 +0000)]
dbg toolbar: prevents screen jumping
preventDefault() ask the browser to ignore URL fragment which
we handle manually (by closing/opening tabs).
Works with Hovzer plugin added by r107982
ping r105122
Siebrand Mazeland [Wed, 18 Jan 2012 08:05:27 +0000 (08:05 +0000)]
Follow-up r107881: revert. Adding forgotten part in r109260.
Gabriel Wicke [Wed, 18 Jan 2012 01:38:44 +0000 (01:38 +0000)]
Correct typo in comment, so that it reflects the spec and the actual value in
the regexp.
Siebrand Mazeland [Wed, 18 Jan 2012 00:26:11 +0000 (00:26 +0000)]
Revert r107881 per CR.
Aaron Schulz [Tue, 17 Jan 2012 23:07:15 +0000 (23:07 +0000)]
Reverted r109223 per CR
Aaron Schulz [Tue, 17 Jan 2012 22:56:43 +0000 (22:56 +0000)]
r108749: added missing backend-fail-contenttype message
Raimond Spekking [Tue, 17 Jan 2012 22:10:16 +0000 (22:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Tue, 17 Jan 2012 21:49:27 +0000 (21:49 +0000)]
[Actions] Move action logic out of MediaWiki::getAction/MediaWiki::performAction into Action::getActionName.
* Follows-up r109195
* Reverts/Redoes r108342, r108343, r108345
* Contributes to solution of bug 27930 - Ability to get current action (The Right Way)
Krinkle [Tue, 17 Jan 2012 19:56:08 +0000 (19:56 +0000)]
[Actions] Move the remaining actions out of MediaWiki::performAction into single action classes (finally).
- [Actions] -
* I am aware that eventually these classes should be more than just a few lines re-directing control to WikiPage, but I'm keeping these commits as uncontroversial as possible due to feature freeze. Refactor could be done later.
* Contributes to solution of bug 27930 - Ablity to get current action (The Right Way)
* Final goal: Get the current action without needing access to Wiki.php internals (i.e. with Action::factory in one hand and an instance of IContextSource in the other)
* Required for proper fix of r108342/108343 (currently marked FIXME)
Krinkle [Tue, 17 Jan 2012 17:39:30 +0000 (17:39 +0000)]
[jquery.footHovzer] Remove buggy scrollstate preserver
* Intended to preserver scroll-state (which is shifted when an element to the bottom gains height). However too unstable to be more handy that it is annoying when it is not.
* Follows-up r107982
Antoine Musso [Tue, 17 Jan 2012 16:42:53 +0000 (16:42 +0000)]
deprecated $query2 in Title.php
$query2 was used to pass a variant. Make that deprecated, the
recommanded way is to use an array as a first parameter. Ex:
$this->getLocalUrl( array( 'variant' => 'foo' ) );
Ping r105919
Sam Reed [Tue, 17 Jan 2012 13:29:42 +0000 (13:29 +0000)]
Fixed reading from file from r108774
Alexandre Emsenhuber [Tue, 17 Jan 2012 12:38:23 +0000 (12:38 +0000)]
* Reordered code to not create a RequestContext if the title is invalid
* Use Article::newFromTitle() instead of new Article()
* Set the WikiPage in the context from the created Article object
Alexandre Emsenhuber [Tue, 17 Jan 2012 12:19:51 +0000 (12:19 +0000)]
If you want to display miliseconds, make the time be really miliseconds and not seconds
Alexandre Emsenhuber [Tue, 17 Jan 2012 11:38:00 +0000 (11:38 +0000)]
Pass __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit()
Antoine Musso [Tue, 17 Jan 2012 10:10:21 +0000 (10:10 +0000)]
dbg toolbar: makes pane title consistent
Example output:
Console (1) | Queries (45) | Debug Log (21) | Request | PHP includes (131)
A null / undefined / 0 value will skip the parentheses output.
Antoine Musso [Tue, 17 Jan 2012 09:58:00 +0000 (09:58 +0000)]
dbg toolbar query list
* add headers (using <th> instead of <colgroup>
* hardcoded width that looks fine to me. 4em is enoug for query count
* split function name / execution time in their own column
Santhosh Thottingal [Tue, 17 Jan 2012 08:54:39 +0000 (08:54 +0000)]
Make the QunitTestResources in sync with qunit/index.html.
JqueryMsg tests were not preset in QunitTestResources.
Aaron Schulz [Tue, 17 Jan 2012 05:34:01 +0000 (05:34 +0000)]
* Fixed type check in StreamFile::prepareForStream() for 404s
* Code comment tweaks and fixes
Aaron Schulz [Tue, 17 Jan 2012 03:58:41 +0000 (03:58 +0000)]
Added CurlHttpRequest to AutoLoader.php
Jeroen De Dauw [Tue, 17 Jan 2012 00:33:44 +0000 (00:33 +0000)]
added missing semicolon
Amir E. Aharoni [Tue, 17 Jan 2012 00:23:07 +0000 (00:23 +0000)]
Force left-to-right directionality on the QUnit output and apply the appropriate directionality to its header, since it can be translated.
Amir E. Aharoni [Tue, 17 Jan 2012 00:17:55 +0000 (00:17 +0000)]
Follow up to r105855 - now with updated phpunit tests.
Aaron Schulz [Mon, 16 Jan 2012 22:54:22 +0000 (22:54 +0000)]
Follow-up r108185: removed now unused ALLOW_STALE param
Alexandre Emsenhuber [Mon, 16 Jan 2012 21:54:24 +0000 (21:54 +0000)]
* Use WikiPage instead of Article to call updateRevisionOn()
* Also lock 'user' table, needed in Revision::newFromId()
Raimond Spekking [Mon, 16 Jan 2012 21:47:30 +0000 (21:47 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Mon, 16 Jan 2012 21:29:05 +0000 (21:29 +0000)]
Only run some MWDebug code when really needed:
* Add the mediawiki.debug module from OutputPage::addDefaultModules() along with other modules
* Get the request information when building the JS output instead of in Setup.php
Antoine Musso [Mon, 16 Jan 2012 21:13:48 +0000 (21:13 +0000)]
firefox does not honor colgroup width with fixed layout
Sam Reed [Mon, 16 Jan 2012 15:49:32 +0000 (15:49 +0000)]
Update documentation for ImportHandleRevisionXMLTag
Siebrand Mazeland [Mon, 16 Jan 2012 14:27:46 +0000 (14:27 +0000)]
Tweak 'protect-text'.
Antoine Musso [Mon, 16 Jan 2012 13:56:18 +0000 (13:56 +0000)]
enable MWDebug tests
The first ones were failing because the test suite ran on gallium without
MWDebug being initialized. This is now the case since r109033.
The second part was failling because PHPUnit on gallium does not have
the assertCount() method. Use a assertEquals() / count() workaround instead.
Tests added by 108873
Reverts r108877
Antoine Musso [Mon, 16 Jan 2012 13:50:17 +0000 (13:50 +0000)]
test with MWDebug enabled (made possible by r109032)
Antoine Musso [Mon, 16 Jan 2012 13:44:46 +0000 (13:44 +0000)]
Move MWDebug enabling logic to Setup.php
MWDebug initialization method was made to look up for a global variable. This
patch move the logic to Setup.php so we can replicate it when doing tests.
Side effect, MWDebug is disabled by default. Users will explicitly have to
enable it by using init().
Ping r105123
Siebrand Mazeland [Mon, 16 Jan 2012 12:05:55 +0000 (12:05 +0000)]
Add plural support in 'longpageerror'.
Amir E. Aharoni [Mon, 16 Jan 2012 10:45:01 +0000 (10:45 +0000)]
Follow up to r109021, corrected the comment, and added a translation from Russian.
Antoine Musso [Mon, 16 Jan 2012 10:36:55 +0000 (10:36 +0000)]
typo in r103711: right -> rights
Antoine Musso [Mon, 16 Jan 2012 10:33:24 +0000 (10:33 +0000)]
Skip BrokenRedirectsPage query test under MySQL
The MySQL backend, when using temporary tables, does not support referencing
a table which was already open.
http://bugs.mysql.com/bug.php?id=10327
This patch skip BrokenRedirectsPage on MySQL as reported on r102411.
Santhosh Thottingal [Mon, 16 Jan 2012 10:05:48 +0000 (10:05 +0000)]
reintroduce the shortcut evaluation removed in r108403 and r108405
Amir E. Aharoni [Mon, 16 Jan 2012 09:46:56 +0000 (09:46 +0000)]
Improved the comment about the two-forms plural shortcut.
Antoine Musso [Mon, 16 Jan 2012 08:59:17 +0000 (08:59 +0000)]
reverts wgDeprecationWhitelist
Per wikitech-l
Reverts r106883 and r106946