From: Sam Reed Date: Mon, 24 Jan 2011 01:00:29 +0000 (+0000) Subject: (bug 26895) in /include/db/LoadBalancer.php function "closeConnecton" should be calle... X-Git-Tag: 1.31.0-rc.0~32398 X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/wiki/supprimer.php?a=commitdiff_plain;h=bb29dc588da8889a18839afe0f7eed8c0341c345;p=lhc%2Fweb%2Fwiklou.git (bug 26895) in /include/db/LoadBalancer.php function "closeConnecton" should be called "closeConnection" Seemingly no callers in extensions OR phase3 (weird...), searching for "closeConnecton" or the correctly spelt "closeConnection" The back-compat typo thing probably wants removing.. Seems to have been as such since it was added in r32578... --- diff --git a/includes/db/LoadBalancer.php b/includes/db/LoadBalancer.php index 2be8fd350c..e6dfd6a1ef 100644 --- a/includes/db/LoadBalancer.php +++ b/includes/db/LoadBalancer.php @@ -760,12 +760,21 @@ class LoadBalancer { ); } + /** + * Deprecated function, typo in function name + */ + function closeConnecton( $conn ) { + $this->closeConnection( $conn ); + } + /** * Close a connection * Using this function makes sure the LoadBalancer knows the connection is closed. * If you use $conn->close() directly, the load balancer won't update its state. + * @param $conn + * @return void */ - function closeConnecton( $conn ) { + function closeConnection( $conn ) { $done = false; foreach ( $this->mConns as $i1 => $conns2 ) { foreach ( $conns2 as $i2 => $conns3 ) {