From: Sam Reed Date: Sat, 31 Dec 2011 00:21:27 +0000 (+0000) Subject: Add braces X-Git-Tag: 1.31.0-rc.0~25664 X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/wiki/supprimer.php?a=commitdiff_plain;h=5d39b698b62b19f6c7c53125ae2adb21d34ab21f;p=lhc%2Fweb%2Fwiklou.git Add braces Fix documentation --- diff --git a/includes/ChangesList.php b/includes/ChangesList.php index 066d3e3bd3..c8e136dc9f 100644 --- a/includes/ChangesList.php +++ b/includes/ChangesList.php @@ -446,7 +446,7 @@ class ChangesList extends ContextSource { /** Inserts a rollback link * - * @param $s + * @param $s string * @param $rc RecentChange */ public function insertRollback( &$s, &$rc ) { @@ -469,10 +469,9 @@ class ChangesList extends ContextSource { } /** - * @param $s + * @param $s string * @param $rc RecentChange * @param $classes - * @return */ public function insertTags( &$s, &$rc, &$classes ) { if ( empty($rc->mAttribs['ts_tags']) ) diff --git a/includes/filerepo/backend/lockmanager/DBLockManager.php b/includes/filerepo/backend/lockmanager/DBLockManager.php index 004caa8d31..3110d5b1d1 100644 --- a/includes/filerepo/backend/lockmanager/DBLockManager.php +++ b/includes/filerepo/backend/lockmanager/DBLockManager.php @@ -206,7 +206,7 @@ class DBLockManager extends LockManager { $votesLeft = count( $this->dbsByBucket[$bucket] ); // remaining DBs $quorum = floor( $votesLeft/2 + 1 ); // simple majority // Get votes for each DB, in order, until we have enough... - foreach ( $this->dbsByBucket[$bucket] as $index => $lockDb ) { + foreach ( $this->dbsByBucket[$bucket] as $lockDb ) { // Check that DB is not *known* to be down if ( $this->cacheCheckFailures( $lockDb ) ) { try { diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php index 5c6255f844..1c2cbfff45 100644 --- a/includes/installer/Installer.php +++ b/includes/installer/Installer.php @@ -1228,7 +1228,7 @@ abstract class Installer { /** * Overridden by WebInstaller to provide lastPage parameters. - * @param $page stirng + * @param $page string * @return string */ protected function getDocUrl( $page ) { diff --git a/maintenance/commandLine.inc b/maintenance/commandLine.inc index db0c56020f..4b6422a63f 100644 --- a/maintenance/commandLine.inc +++ b/maintenance/commandLine.inc @@ -41,8 +41,9 @@ class CommandLineInc extends Maintenance { * No help, it would just be misleading since it misses custom options */ protected function maybeHelp( $force = false ) { - if ( !$force ) + if ( !$force ) { return; + } parent::maybeHelp( true ); } diff --git a/maintenance/runJobs.php b/maintenance/runJobs.php index 0edf7ac934..6068311e99 100644 --- a/maintenance/runJobs.php +++ b/maintenance/runJobs.php @@ -61,16 +61,18 @@ class RunJobs extends Maintenance { $dbw = wfGetDB( DB_MASTER ); $n = 0; $conds = ''; - if ( $type !== false ) + if ( $type !== false ) { $conds = "job_cmd = " . $dbw->addQuotes( $type ); + } while ( $dbw->selectField( 'job', 'job_id', $conds, 'runJobs.php' ) ) { $offset = 0; for ( ; ; ) { $job = !$type ? Job::pop( $offset ) : Job::pop_type( $type ); - if ( !$job ) + if ( !$job ) { break; + } wfWaitForSlaves(); $t = microtime( true );