From fd15274dcd4aa924ea07de9ce2c9b98f899d506b Mon Sep 17 00:00:00 2001 From: addshore Date: Sat, 25 Jan 2014 14:15:42 +0100 Subject: [PATCH] Cleanup RefreshLinksPartitionTest Change-Id: I9c8e66b7370f8ea8d9b4f8843718b29e992b1180 --- includes/job/utils/BacklinkJobUtils.php | 2 +- .../phpunit/includes/jobqueue/RefreshLinksPartitionTest.php | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/includes/job/utils/BacklinkJobUtils.php b/includes/job/utils/BacklinkJobUtils.php index b0b6ccdfa9..c8e5df66f7 100644 --- a/includes/job/utils/BacklinkJobUtils.php +++ b/includes/job/utils/BacklinkJobUtils.php @@ -62,7 +62,7 @@ class BacklinkJobUtils { * @param int $bSize BacklinkCache partition size; usually $wgUpdateRowsPerJob * @param int $cSize Max titles per leaf job; Usually 1 or a modest value * @param array $opts Optional parameter map - * @return array List of Job objects + * @return Job[] List of Job objects */ public static function partitionBacklinkJob( Job $job, $bSize, $cSize, $opts = array() ) { $class = get_class( $job ); diff --git a/tests/phpunit/includes/jobqueue/RefreshLinksPartitionTest.php b/tests/phpunit/includes/jobqueue/RefreshLinksPartitionTest.php index 531a95474c..3d2b5d81ba 100644 --- a/tests/phpunit/includes/jobqueue/RefreshLinksPartitionTest.php +++ b/tests/phpunit/includes/jobqueue/RefreshLinksPartitionTest.php @@ -6,7 +6,7 @@ * @group Database */ class RefreshLinksPartitionTest extends MediaWikiTestCase { - function __construct( $name = null, array $data = array(), $dataName = '' ) { + public function __construct( $name = null, array $data = array(), $dataName = '' ) { parent::__construct( $name, $data, $dataName ); $this->tablesUsed[] = 'page'; @@ -20,9 +20,6 @@ class RefreshLinksPartitionTest extends MediaWikiTestCase { public function testRefreshLinks( $ns, $dbKey, $pages ) { $title = Title::makeTitle( $ns, $dbKey ); - $dbw = wfGetDB( DB_MASTER ); - - $rows = array(); foreach ( $pages as $page ) { list( $bns, $bdbkey ) = $page; $bpage = WikiPage::factory( Title::makeTitle( $bns, $bdbkey ) ); -- 2.20.1