From a931293184bdc7a03df7b3e31d71dd03b8400c66 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Tue, 15 Apr 2014 22:16:41 +0200 Subject: [PATCH] Properly deprecate the SpecialVersionExtensionTypes hook wfRunHooks() has recently gained a new parameter for this. Change-Id: If8dd90d03334ca6007f5af5e79c2545886c88b5f --- docs/hooks.txt | 3 ++- includes/specials/SpecialVersion.php | 5 +---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/hooks.txt b/docs/hooks.txt index 668cc06155..2e876042db 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -2485,7 +2485,8 @@ Special:Upload. $form: The SpecialUpload object 'SpecialVersionExtensionTypes': Called when generating the extensions credits, -use this to change the tables headers. +use this to change the tables headers. Deprecated since MediaWiki 1.17, use the +ExtensionTypes hook instead. $extTypes: associative array of extensions types 'SpecialVersionVersionUrl': Called when building the URL for Special:Version. diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index f07d97b176..9ad95ec0f7 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -433,10 +433,7 @@ class SpecialVersion extends SpecialPage { $extensionTypes = self::getExtensionTypes(); - /** - * @deprecated as of 1.17, use hook ExtensionTypes instead. - */ - wfRunHooks( 'SpecialVersionExtensionTypes', array( &$this, &$extensionTypes ) ); + wfRunHooks( 'SpecialVersionExtensionTypes', array( &$this, &$extensionTypes ), '1.17' ); $out = Xml::element( 'h2', -- 2.20.1