From 48fb7a673e34f59e4e7f50de94d0279205fa4aec Mon Sep 17 00:00:00 2001
From: Raimond Spekking <raymond@users.mediawiki.org>
Date: Wed, 18 Feb 2009 20:34:13 +0000
Subject: [PATCH] * Special:ListUsers: Sort list of usergroups by alphabet *
 Add an ID to the inputform * Use specific Xml::fieldset function

---
 RELEASE-NOTES                          |  1 +
 includes/specials/SpecialListusers.php | 14 +++++++++-----
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index f17e3bc84e..0b5aaabbd9 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -110,6 +110,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 14981) Shared repositories can now have display names, located at
   Mediawiki:Shared-repo-name-REPONAME, where REPONAME is the name in 
   $wgForeignFileRepos
+* Special:ListUsers: Sort list of usergroups by alphabet
 
 === Bug fixes in 1.15 ===
 * (bug 16968) Special:Upload no longer throws useless warnings.
diff --git a/includes/specials/SpecialListusers.php b/includes/specials/SpecialListusers.php
index ff9e57e509..418b9eb85d 100644
--- a/includes/specials/SpecialListusers.php
+++ b/includes/specials/SpecialListusers.php
@@ -171,10 +171,9 @@ class UsersPager extends AlphabeticPager {
 		$self = $this->getTitle();
 
 		# Form tag
-		$out  = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) ) .
-			'<fieldset>' .
-			Xml::element( 'legend', array(), wfMsg( 'listusers' ) );
-		$out .= Xml::hidden( 'title', $self->getPrefixedDbKey() );
+		$out  = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'id' => 'mw-listusers-form' ) ) .
+			Xml::fieldset( wfMsg( 'listusers' ) ) .
+			Xml::hidden( 'title', $self->getPrefixedDbKey() );
 
 		# Username field
 		$out .= Xml::label( wfMsg( 'listusersfrom' ), 'offset' ) . ' ' .
@@ -198,17 +197,22 @@ class UsersPager extends AlphabeticPager {
 		$out .= Xml::hidden( 'limit', $this->mLimit );
 		$out .= Xml::submitButton( wfMsg( 'allpagessubmit' ) );
 		wfRunHooks( 'SpecialListusersHeader', array( $this, &$out ) );
-		$out .= '</fieldset>' .
+		$out .= Xml::closeElement( 'fieldset' ) .
 			Xml::closeElement( 'form' );
 
 		return $out;
 	}
 
+	/**
+	 * Get a list of all explicit groups
+	 * @return array
+	 */
 	function getAllGroups() {
 		$result = array();
 		foreach( User::getAllGroups() as $group ) {
 			$result[$group] = User::getGroupName( $group );
 		}
+		asort( $result );
 		return $result;
 	}
 
-- 
2.20.1