From 1fe65bd2ad2bc92c175273a8dfa9af4626d00509 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gerg=C5=91=20Tisza?= Date: Tue, 14 Nov 2017 15:01:38 -0800 Subject: [PATCH] Remove $wgAuth usage from wrapOldPasswords.php AuthPlugin::allowSetLocalPassword() has been deprecated with no real replacement. (Authentication providers largely describe things from a client POV, so we can check whether the authentication system is configured to use passwords but not whether it uses the user_password field. We could check whether the auth providers include LocalPasswordAuthenticationProvider but that's rather fragile.) There does not seem to be much need, either; we can assume the site admin has at least a basic knowledge of what they are using and would not run wrapOldPasswords.php if the site wasn't using local passwords. Bug: T180537 Change-Id: I34f2d8ad0d801b5460b768ad1d52b29b0a1b08db --- maintenance/wrapOldPasswords.php | 6 ------ 1 file changed, 6 deletions(-) diff --git a/maintenance/wrapOldPasswords.php b/maintenance/wrapOldPasswords.php index 85fa7805e6..1dbad18485 100644 --- a/maintenance/wrapOldPasswords.php +++ b/maintenance/wrapOldPasswords.php @@ -43,12 +43,6 @@ class WrapOldPasswords extends Maintenance { } public function execute() { - global $wgAuth; - - if ( !$wgAuth->allowSetLocalPassword() ) { - $this->error( '$wgAuth does not allow local passwords. Aborting.', true ); - } - $passwordFactory = new PasswordFactory(); $passwordFactory->init( RequestContext::getMain()->getConfig() ); -- 2.20.1