From: Roan Kattouw <catrope@users.mediawiki.org>
Date: Sat, 30 Jan 2010 12:09:28 +0000 (+0000)
Subject: API: Fix E_NOTICE. !is_null() and isset() are not equivalent when indexing arrays
X-Git-Tag: 1.31.0-rc.0~38034
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=8366e22bc7c8af1b947a50ad3051af905984db7d;p=lhc%2Fweb%2Fwiklou.git

API: Fix E_NOTICE. !is_null() and isset() are not equivalent when indexing arrays
---

diff --git a/includes/api/ApiQueryUserContributions.php b/includes/api/ApiQueryUserContributions.php
index 424de998a8..f1ca2324b4 100644
--- a/includes/api/ApiQueryUserContributions.php
+++ b/includes/api/ApiQueryUserContributions.php
@@ -255,7 +255,7 @@ class ApiQueryContributions extends ApiQueryBase {
 			$this->addFields( 'ts_tags' );
 		}
 		
-		if ( !is_null( $this->params['tag'] ) ) {
+		if ( isset( $this->params['tag'] ) ) {
 			$this->addTables( 'change_tag' );
 			$this->addJoinConds( array( 'change_tag' => array( 'INNER JOIN', array( 'rev_id=ct_rev_id' ) ) ) );
 			$this->addWhereFld( 'ct_tag', $this->params['tag'] );