From ec4be6b44f30c5233ec874903d13fcff6602c12d Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sun, 14 Apr 2019 23:12:53 +0100 Subject: [PATCH] selenium: Disable flaky wdio rollback tests that rely on pauses Wait for an actual state to be reached, whether a JavaScript expression to become true, or a certain state in the DOM. Using pauses is an anti-pattern and inherently unstable. Bug: T219440 Change-Id: Ibb2bd335f12442ab8ec2973031454cb58733211d --- tests/selenium/specs/rollback.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/selenium/specs/rollback.js b/tests/selenium/specs/rollback.js index 648e52f600..970fb9e6ef 100644 --- a/tests/selenium/specs/rollback.js +++ b/tests/selenium/specs/rollback.js @@ -48,7 +48,7 @@ describe( 'Rollback with confirmation', function () { assert.strictEqual( HistoryPage.rollbackConfirmableNo.getText(), 'Cancel' ); } ); - it( 'should offer a way to cancel rollbacks', function () { + it.skip( 'should offer a way to cancel rollbacks', function () { HistoryPage.rollback.click(); browser.pause( 300 ); @@ -60,7 +60,7 @@ describe( 'Rollback with confirmation', function () { assert.strictEqual( HistoryPage.heading.getText(), 'Revision history of "' + name + '"' ); } ); - it( 'should perform rollbacks after confirming intention', function () { + it.skip( 'should perform rollbacks after confirming intention', function () { HistoryPage.rollback.click(); browser.pause( 300 ); -- 2.20.1