From dabbf42aa702ef1095bd3ecff03447360f4e0aea Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 13 Mar 2019 11:31:58 -0700 Subject: [PATCH] Avoid page table query spam in HistoryPager due to lastLink() Pass in the Title so there is not an extra query for each revision. Change-Id: I0d36422a304c31c4bda0a408ef4a6fcd52ad57f1 --- includes/Title.php | 1 + includes/actions/pagers/HistoryPager.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/Title.php b/includes/Title.php index 82e79b379c..9161733aeb 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -437,6 +437,7 @@ class Title implements LinkTarget, IDBAccessObject { } else { $title = null; } + return $title; } diff --git a/includes/actions/pagers/HistoryPager.php b/includes/actions/pagers/HistoryPager.php index a59597fea9..d3a32d0e27 100644 --- a/includes/actions/pagers/HistoryPager.php +++ b/includes/actions/pagers/HistoryPager.php @@ -541,7 +541,7 @@ class HistoryPager extends ReverseChronologicalPager { ); } - $nextRev = new Revision( $next ); + $nextRev = new Revision( $next, 0, $this->getTitle() ); if ( !$prevRev->userCan( Revision::DELETED_TEXT, $this->getUser() ) || !$nextRev->userCan( Revision::DELETED_TEXT, $this->getUser() ) -- 2.20.1