From bf29eadf3ea4bcaff236c15b3ee7315cdf186da2 Mon Sep 17 00:00:00 2001 From: Juan Osorio Date: Fri, 5 Apr 2019 14:47:38 -0700 Subject: [PATCH] Fixes LocalFile isMissing always returning true Bug: T220244 Change-Id: I6f4e1371759559a14cb7b2125792fcfbba7e4cf3 --- includes/filerepo/file/LocalFile.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/includes/filerepo/file/LocalFile.php b/includes/filerepo/file/LocalFile.php index 134a1045c1..aa04faec8f 100644 --- a/includes/filerepo/file/LocalFile.php +++ b/includes/filerepo/file/LocalFile.php @@ -796,11 +796,14 @@ class LocalFile extends File { /** isVisible inherited */ /** + * Checks if this file exists in its parent repo, as referenced by its + * virtual URL. + * * @return bool */ function isMissing() { if ( $this->missing === null ) { - list( $fileExists ) = $this->repo->fileExists( $this->getVirtualUrl() ); + $fileExists = $this->repo->fileExists( $this->getVirtualUrl() ); $this->missing = !$fileExists; } -- 2.20.1