From a1731db5abba7323eada8c11db2340cf0ecc3670 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Sat, 11 May 2019 16:21:18 +0100 Subject: [PATCH] SearchEngine: Remove deprecated unused method `transformSearchTerm()` I've checked around with code search tool and realized that SMW has its own implementation of `transformSearchTerm()` which overwrites the implementation of this method from core as it extends SearchEngine. So removing this won't break SMW, see usage below; Usage ===== https://codesearch.wmflabs.org/search/?q=%5CbtransformSearchTerm%5Cb&i=nope&files=&repos= Bug: T220656 Change-Id: I3dbe04ecba07700167c894673e23c1eead95460f --- RELEASE-NOTES-1.34 | 1 + includes/search/SearchEngine.php | 14 -------------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34 index db24a44e26..247f48eb37 100644 --- a/RELEASE-NOTES-1.34 +++ b/RELEASE-NOTES-1.34 @@ -156,6 +156,7 @@ because of Phabricator reports. * ChangeTags::purgeTagUsageCache(), deprecated in 1.33, has been removed. * JobQueueGroup::pushLazyJobs(), deprecated in 1.33, has been removed. * MediaWikiTestCase::stashMwGlobals(), deprecated in 1.32, has been removed. +* SearchEngine::transformSearchTerm(), deprecated in 1.32, has been removed. * … === Deprecations in 1.34 === diff --git a/includes/search/SearchEngine.php b/includes/search/SearchEngine.php index b99c0d3dee..9771e8881e 100644 --- a/includes/search/SearchEngine.php +++ b/includes/search/SearchEngine.php @@ -235,20 +235,6 @@ abstract class SearchEngine { return MediaWikiServices::getInstance()->getContentLanguage()->segmentByWord( $string ); } - /** - * Transform search term in cases when parts of the query came as different - * GET params (when supported), e.g. for prefix queries: - * search=test&prefix=Main_Page/Archive -> test prefix:Main Page/Archive - * @param string $term - * @return string - * @deprecated since 1.32 this should now be handled internally by the - * search engine - */ - public function transformSearchTerm( $term ) { - wfDeprecated( __METHOD__, '1.32' ); - return $term; - } - /** * Get service class to finding near matches. * @param Config $config Configuration to use for the matcher. -- 2.20.1