jenkins-bot [Thu, 26 Jul 2018 22:26:11 +0000 (22:26 +0000)]
Merge "Segregate right to edit sitewide CSS/JS"
jenkins-bot [Thu, 26 Jul 2018 21:37:00 +0000 (21:37 +0000)]
Merge "Deprecate $wgExternalDiffEngine = 'wikidiff2'"
jenkins-bot [Thu, 26 Jul 2018 20:06:13 +0000 (20:06 +0000)]
Merge "Prefill username in form when calling Special:Log/<username>"
jenkins-bot [Thu, 26 Jul 2018 19:33:03 +0000 (19:33 +0000)]
Merge "Handle $title === null in Title::newFromText"
jenkins-bot [Thu, 26 Jul 2018 19:17:35 +0000 (19:17 +0000)]
Merge "SelectWithInput: Add 'disabled' property on main widget"
jenkins-bot [Thu, 26 Jul 2018 18:59:10 +0000 (18:59 +0000)]
Merge "GlobalFunctions: Enable patch-coverage for wfExpandUrl test"
jenkins-bot [Thu, 26 Jul 2018 18:48:28 +0000 (18:48 +0000)]
Merge "INSTALL: Don't warn against using PHP "as a CGI plugin""
jenkins-bot [Thu, 26 Jul 2018 18:46:06 +0000 (18:46 +0000)]
Merge "Update jetbrains/phpstorm-stubs"
Gergő Tisza [Thu, 26 Jul 2018 18:39:21 +0000 (20:39 +0200)]
Handle $title === null in Title::newFromText
This relied on TitleCodec throwing MalformedTitleException in the
past, but that is fragile as other parts of the logic do not
expect null.
Bug: T200456
Change-Id: I1aca3971e2a9c0b1fe3adbcf34f3ee65b2271234
Reedy [Thu, 26 Jul 2018 16:31:49 +0000 (17:31 +0100)]
Update composer/spdx-licenses to 1.4.0 and mediawiki/mediawiki-codesniffer to 21.0.0
https://github.com/composer/spdx-licenses/compare/1.3.0...1.4.0
Change-Id: I39f7a1310455159866bfed5224536e800befec0d
Reedy [Thu, 26 Jul 2018 17:14:22 +0000 (18:14 +0100)]
Update jetbrains/phpstorm-stubs
Change-Id: I553afcc8f0126b9611dd9fce26029bd9c9e17071
Jayprakash12345 [Thu, 26 Jul 2018 16:50:56 +0000 (22:20 +0530)]
Prefill username in form when calling Special:Log/<username>
Bug: T200446
Change-Id: I3f2fcedee8440d5943e556f7c1c06dfb1085e549
jenkins-bot [Thu, 26 Jul 2018 15:06:41 +0000 (15:06 +0000)]
Merge "Upstream EasyDeflate library from VisualEditor"
jenkins-bot [Thu, 26 Jul 2018 12:06:05 +0000 (12:06 +0000)]
Merge "Deprecate public access to some DifferenceEngine properties"
Gergő Tisza [Wed, 11 Jul 2018 11:11:25 +0000 (13:11 +0200)]
Deprecate $wgExternalDiffEngine = 'wikidiff2'
The value 'wikidiff2' for $wgExternalDiffEngine was obsoleted in
I32b670ebf6 but not formally deprecated. Let's do that now.
Change-Id: Ie5ccd3895544cf393885b84d38eca6003c79e8ad
Depends-On: I33c6207cfc5fb66987d31818bc27055f597d28c7
Gergő Tisza [Wed, 11 Jul 2018 08:54:58 +0000 (10:54 +0200)]
Deprecate public access to some DifferenceEngine properties
These had no business being public in the first place and there is
no usage in Gerrit. In case something does use them, it will probably
be broken by the refactoring that's soon to come, so the deprecation
warning makes it easier to figure out where the problem lies.
Change-Id: I72ba5cfbf91f4af16028ba4f8619df6a7168a786
Aryeh Gregor [Wed, 25 Jul 2018 14:57:23 +0000 (17:57 +0300)]
Use setContentLang() instead of setMwGlobals()
This changes behavior in some tests by making them set $wgLanguageCode
as well as $wgContLang, but that seems like a good thing.
Bug: T200246
Change-Id: I936888f46ff9fefe2707efba837e2ce3a7ca5e3f
jenkins-bot [Thu, 26 Jul 2018 09:05:18 +0000 (09:05 +0000)]
Merge "Use 'default' instead of 'value' in HTMLTextField"
Kevin Israel [Thu, 26 Jul 2018 05:36:19 +0000 (01:36 -0400)]
INSTALL: Don't warn against using PHP "as a CGI plugin"
This note is very old; it was added in r2832 (
635388356be70130) and
r3285 (
7ab7a50cf928861f). Modern versions of MediaWiki support CGI and
FastCGI installations nearly as well as mod_php installations. In fact,
Wikimedia currently uses HHVM's "fastcgi" server type, and intends to
use php-fpm with PHP 7 (see migration plan in T176370).
For a basic MediaWiki installation using the web installer, the only
difference I know of is the default URLs: /w/index.php?title=$1 for CGI,
as opposed to /w/index.php/$1 for mod_php. This issue is easy to fix by
changing $wgArticlePath, if the web server sets REQUEST_URI. Admins who
want to use short URLs (e.g. /wiki/$1) have to do this anyway.
Also, in img_auth.php and the "img-auth-nopathinfo" message, don't imply
that CGI and FastCGI server configurations generally can't provide path
information or support MediaWiki features that need it.
Change-Id: I89212e9d51f950a58f911083b9e109b69cd4e060
jenkins-bot [Wed, 25 Jul 2018 22:49:39 +0000 (22:49 +0000)]
Merge "Add helper trait for deprecating properties"
Aaron Schulz [Mon, 25 Jun 2018 12:16:15 +0000 (13:16 +0100)]
Make MessageCache use APC for big messages
Bug: T118893
Change-Id: I418d0ca490911d7ee4213fe1728cfbc637ef8b10
Translation updater bot [Wed, 25 Jul 2018 19:57:29 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I69852319aa363902ca532563bee3938103e1be41
Jayprakash12345 [Wed, 25 Jul 2018 19:38:16 +0000 (01:08 +0530)]
Use 'default' instead of 'value' in HTMLTextField
Bug: T193087
Change-Id: I631970797a778caa77d3605e0a5b8ca00e2cb56e
Timo Tijhof [Wed, 25 Jul 2018 17:24:48 +0000 (18:24 +0100)]
GlobalFunctions: Enable patch-coverage for wfExpandUrl test
Change-Id: I3b4594dab0aba659cc47233f7be3da751066b7de
jenkins-bot [Wed, 25 Jul 2018 17:06:06 +0000 (17:06 +0000)]
Merge "Make the 'other' option superessable in getSuggestedDurations"
jenkins-bot [Wed, 25 Jul 2018 16:23:13 +0000 (16:23 +0000)]
Merge "Follow-up
9742d569b: Replace accidental \t in i18n with a space"
jenkins-bot [Wed, 25 Jul 2018 16:22:22 +0000 (16:22 +0000)]
Merge "Deprecate $wgShowSQLErrors and $wgShowDBErrorBacktrace and make nonfunctional"
Bill Pirkle [Tue, 17 Jul 2018 16:51:36 +0000 (11:51 -0500)]
Deprecate $wgShowSQLErrors and $wgShowDBErrorBacktrace and make nonfunctional
Clarify and simplify exception output by deprecating
$wgShowSQLErrors and wgShowDBErrorBacktrace.
$wgShowExceptionDetails will now control most related output.
$wgShowHostnames will now solely control output of
MWExceptionRenderer::reportOutageHTML.
Bug: T165768
Change-Id: Idead2c11c499463dfa6293c3d4b33be3bde92e1a
James D. Forrester [Wed, 25 Jul 2018 15:34:51 +0000 (08:34 -0700)]
Follow-up
9742d569b: Replace accidental \t in i18n with a space
Change-Id: Id8ad5916b7dd59a078fb600c7998e41f1b8abd3c
jenkins-bot [Wed, 25 Jul 2018 15:33:48 +0000 (15:33 +0000)]
Merge "Make load* methods of DifferenceEngine idempotent"
jenkins-bot [Wed, 25 Jul 2018 14:52:44 +0000 (14:52 +0000)]
Merge "cache: Minor docs for MessageCache interaction with WANObjectCache"
Timo Tijhof [Sun, 22 Jul 2018 23:52:41 +0000 (00:52 +0100)]
cache: Minor docs for MessageCache interaction with WANObjectCache
Follows-up
04bc03a29a.
Change-Id: I8fb810fc2e08277bb64fa18595483a2161cfb1cc
jenkins-bot [Wed, 25 Jul 2018 11:59:58 +0000 (11:59 +0000)]
Merge "Fallback language for Santali should be English"
Prateek Saxena [Wed, 25 Jul 2018 05:29:03 +0000 (10:59 +0530)]
SelectWithInput: Add 'disabled' property on main widget
…also HTMLSelectAndOtherField and HTMLSelectOrOtherField now
pass the 'disabled' field when creating the input widget.
The OOUI versions of these HTMLFormFields would get enabled
right after infusion even they were disabled in PHP. This
makes sure that they remain disabled.
Change-Id: Iddd8ad81731dba7bdcb599d6fe104cb259b11733
jenkins-bot [Wed, 25 Jul 2018 05:29:12 +0000 (05:29 +0000)]
Merge "ApiBase: Use prefixed parameter name for 'missingparam' error"
jenkins-bot [Wed, 25 Jul 2018 04:40:53 +0000 (04:40 +0000)]
Merge "Make OutputPage::mPagetitle private"
jenkins-bot [Wed, 25 Jul 2018 04:16:18 +0000 (04:16 +0000)]
Merge "objectcache: improve logging and error handling in BagOStuff"
Martin Urbanec [Tue, 24 Jul 2018 19:47:50 +0000 (21:47 +0200)]
Fallback language for Santali should be English
Bug: T200290
Change-Id: I65005b8b31bd022c7978628f69c5d56d735063e3
Translation updater bot [Tue, 24 Jul 2018 19:53:03 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idbc346a6c0d5bf2bdc2278bc2ef3440579500dc7
Aaron Schulz [Thu, 12 Jul 2018 15:26:13 +0000 (16:26 +0100)]
objectcache: improve logging and error handling in BagOStuff
Bug: T198239
Bug: T199383
Change-Id: I0b4110396d03b98e83a7b614caf57d7e7c284361
jenkins-bot [Tue, 24 Jul 2018 16:18:25 +0000 (16:18 +0000)]
Merge "PageArchive: Pass correct overrides to newRevisionFromArchiveRow()"
jenkins-bot [Tue, 24 Jul 2018 16:13:39 +0000 (16:13 +0000)]
Merge "Avoid a redirect loop when the request URL is not normalized"
Huji Lee [Mon, 30 Apr 2018 01:38:42 +0000 (21:38 -0400)]
Make the 'other' option superessable in getSuggestedDurations
Bug: T193364
Change-Id: Ic2dbc961f7eebad11da53724b9cce2f804ffad39
Aryeh Gregor [Tue, 24 Jul 2018 13:38:44 +0000 (16:38 +0300)]
Make OutputPage::mPagetitle private
Code search revealed only one outside access, which I've submitted a patch for.
Depends-On: I001deecad241b091070483d882088d2d6361ed5a
Change-Id: I0f7e565f4eacc1074c619772b2d11a47a05e3584
Thiemo Kreuz (WMDE) [Tue, 24 Jul 2018 06:02:55 +0000 (06:02 +0000)]
thiemowmde's legal name changed
I was a co-author only, and my contribution was not really
noteworthy, so I choose to remove the outdated name (in this
case only).
Change-Id: I9d9592d5b114adae633f6a4bdac2dd60f329bd7a
jenkins-bot [Tue, 24 Jul 2018 01:54:31 +0000 (01:54 +0000)]
Merge "LogEventsList: Correct typo"
jenkins-bot [Tue, 24 Jul 2018 01:13:32 +0000 (01:13 +0000)]
Merge "$wgHttpsPort should only be used in very special cases"
jenkins-bot [Mon, 23 Jul 2018 20:55:21 +0000 (20:55 +0000)]
Merge "LogPager: Add backwards-compatibility for hide_[type]_log URL params"
Translation updater bot [Mon, 23 Jul 2018 20:08:57 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8b632d4052c2634867c7d498305cf287d2fc58c9
Greg Grossmeier [Mon, 23 Jul 2018 16:45:31 +0000 (16:45 +0000)]
Revert "Ensure LanguageCode::bcp47() returns a valid BCP 47 language code"
This reverts commit
8380f0173e79b66f0e2afd6c49cd88afb9f4f6f3.
Reason for revert: Caused T199941
Bug: T199941
Change-Id: I93af756a2d70d6bc91f828fe6ac19bf10ca8788f
jenkins-bot [Mon, 23 Jul 2018 17:22:32 +0000 (17:22 +0000)]
Merge "Revert "Accept BCP 47 codes as aliases for nonstandard variants""
Greg Grossmeier [Mon, 23 Jul 2018 16:44:55 +0000 (16:44 +0000)]
Revert "Accept BCP 47 codes as aliases for nonstandard variants"
This reverts commit
0818070c59eb4e8330496796b943951c01c7a573.
Reason for revert: Caused T199941
Bug: T199941
Change-Id: I24c178eb33890477de79cbb3122861c140578011
jenkins-bot [Mon, 23 Jul 2018 16:28:45 +0000 (16:28 +0000)]
Merge "LogEventsList: Use DerivativeContext"
Bartosz Dziewoński [Mon, 23 Jul 2018 16:18:04 +0000 (18:18 +0200)]
LogEventsList: Correct typo
The parameter to getTitleInputDesc() is actually unused, so this was
not breaking anything.
Change-Id: Ia301faf511e30b4fc4542ccb80b24cf807cf731c
Brad Jorsch [Mon, 23 Jul 2018 13:22:23 +0000 (09:22 -0400)]
ApiBase: Use prefixed parameter name for 'missingparam' error
Similar errors use the prefixed parameter name, this one should too.
Bug: T200155
Change-Id: Ia14d6a9c457af06e72428c1eae14bd3849b4595a
Brad Jorsch [Mon, 23 Jul 2018 12:44:02 +0000 (08:44 -0400)]
PageArchive: Pass correct overrides to newRevisionFromArchiveRow()
Revision::newFromArchiveRow took 'page' as an override for ar_page_id,
while RevisionStore::newRevisionFromArchiveRow() needs 'page_id'.
Thanks to sanity checks elsewhere in RevisionStore, this mistaken
override causes an exception to be thrown rather than undeleted
revisions potentially pointing to the wrong page.
Bug: T200072
Change-Id: I9d7543866c674f4d8aea9ec00fcc15cbf616ca66
Prateek Saxena [Mon, 23 Jul 2018 04:22:36 +0000 (09:52 +0530)]
LogEventsList: Use DerivativeContext
Bug: T200136
Change-Id: Ie2b7753684dc0257b0b53d9c9314feeb14d99182
jenkins-bot [Mon, 23 Jul 2018 02:55:53 +0000 (02:55 +0000)]
Merge "HTMLMultiSelectField: Improve compat with GET forms with no wpFormIdentifier"
Bill Pirkle [Thu, 12 Jul 2018 22:07:54 +0000 (17:07 -0500)]
Added non-parallel fallback to MultiHttpClient when curl is unavailable
If the curl extension is not available, fall back to the existing
HttpRequestFactory and associated classes. Also added related phpunit tests.
Bug: T139169
Change-Id: I2f9d4acbb491bce28d7105e124c5cee7e16e86d7
jenkins-bot [Sun, 22 Jul 2018 23:59:18 +0000 (23:59 +0000)]
Merge "Make MessageCache use getWithSetCallback() for big messages"
Translation updater bot [Sun, 22 Jul 2018 19:52:41 +0000 (21:52 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I93c905909b83a89898922e241610275186e5346b
Gergő Tisza [Tue, 20 Mar 2018 22:44:27 +0000 (15:44 -0700)]
Segregate right to edit sitewide CSS/JS
To limit the likelihood of incidents like T189665, the ability to
edit sitewide CSS/JSON/JS is split out from editinterface, into
separate 'editsitecss', 'editsitejson' and 'editsitejs' rights.
editsitecss, editsitejs, and the right to edit another (potentially
more privileged) user's personal CSS/JS is removed from sysops, and
a new user group, interface-admin, is created specifically for that
task (along with a new grant group 'editsiteconfig').
interface-admin is granted to the first user of a new wiki, along with
sysop and bureaucrat.
Bug: T120886
Bug: T190015
Depends-On: Ia9b2ea1450aff6121dc0f3777bf029292c8aaad9
Change-Id: Ifefd872640642441e26f8b2f144ffe4b88d2eb12
Translation updater bot [Sat, 21 Jul 2018 19:52:53 +0000 (21:52 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I848c703ad10f39827730fcdacdd83b4ad47b346d
jenkins-bot [Sat, 21 Jul 2018 00:55:09 +0000 (00:55 +0000)]
Merge "Explicitly mark Skin::makeVariablesScript() public"
jenkins-bot [Fri, 20 Jul 2018 20:37:45 +0000 (20:37 +0000)]
Merge "Fix octal escape sequence overflow in FiltersTest.php"
Reedy [Fri, 20 Jul 2018 20:02:40 +0000 (21:02 +0100)]
Explicitly mark Skin::makeVariablesScript() public
Remove else. If contains an unconditional return
Change-Id: I57a04339395d947dffbc3595d321106d4fd8256c
Translation updater bot [Fri, 20 Jul 2018 19:53:15 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I01a747cba68c60850761ac5dcef992bcebaaf6b5
jenkins-bot [Fri, 20 Jul 2018 15:13:48 +0000 (15:13 +0000)]
Merge "Send API timing to statsd for all requests, not just writes"
Gergő Tisza [Mon, 28 May 2018 16:25:36 +0000 (16:25 +0000)]
Add maintenance script for resetting login/signup throttle
Bug: T194506
Change-Id: I6dda5f516ba47a452e438946379fcb696c8c87f9
jenkins-bot [Fri, 20 Jul 2018 10:51:35 +0000 (10:51 +0000)]
Merge "filebackend: let any specific backend value of "readOnly" override the default"
jenkins-bot [Fri, 20 Jul 2018 10:30:37 +0000 (10:30 +0000)]
Merge "JobQueueGroup: Allow readOnlyReason to be specified per JQ type"
jenkins-bot [Fri, 20 Jul 2018 10:21:48 +0000 (10:21 +0000)]
Merge "Install cache/integration-tests as require-dev"
addshore [Wed, 18 Jul 2018 10:47:27 +0000 (12:47 +0200)]
Install cache/integration-tests as require-dev
Bug: T199440
Change-Id: I1e50d7202a5d02088319ec9e90e0136519cba1ce
Max Semenik [Fri, 20 Jul 2018 06:54:49 +0000 (23:54 -0700)]
GlobalFunctions: use a closure instead of polluting global namespace
Change-Id: Ia587008de75a8bde90ad45d4932284f0b6401845
Tim Starling [Fri, 20 Jul 2018 06:49:49 +0000 (16:49 +1000)]
Send API timing to statsd for all requests, not just writes
The rate will be about 8k req/s, whereas currently graphite1001
receives about 350k metric updates per second, so we would expect
this to increase statsd load by about 2%.
This would have been very helpful in diagnosing API cluster overload
incidents such as the one on July 11.
Change-Id: I0a248e1bcec05915d98ec735f4cfb9800e64412d
jenkins-bot [Fri, 20 Jul 2018 06:12:44 +0000 (06:12 +0000)]
Merge "language: Document sources of data and example usage"
jenkins-bot [Fri, 20 Jul 2018 04:59:31 +0000 (04:59 +0000)]
Merge "resourceloader: CSSMin::getLocalFileReferences now strips anchors"
jenkins-bot [Fri, 20 Jul 2018 04:56:09 +0000 (04:56 +0000)]
Merge "Language::listToText: Avoid PHP warnings from E_STRICT"
Antoine Musso [Tue, 17 Jul 2018 15:59:17 +0000 (17:59 +0200)]
resourceloader: CSSMin::getLocalFileReferences now strips anchors
When processing:
url( 'foo.svg#anchors' )
getLocalFileReferences() would yield a file 'foo.svg#anchors'. It might
occur with upstream libraries, such as WikiFonts used by the Refreshed
skin.
When a path is found, strip the anchor entirely. Skip the case if that
results in an empty file.
remap() would properly skip the behavior "#default#', also skip url that
are solely an anchor such as '#other'.
Add a few test cases to cover CSSMin::getLocalFileReferences and cover
anchors usage in CSSMin::remap.
Bug: T115436
Change-Id: I1749ddc2b89021807f42d64131931ad7a99a7b43
Timo Tijhof [Fri, 20 Jul 2018 03:06:28 +0000 (20:06 -0700)]
language: Document sources of data and example usage
Change-Id: I0c72069d010285d9b88ff83bc1478410961065d3
Tim Starling [Fri, 20 Jul 2018 02:03:48 +0000 (12:03 +1000)]
parserTests: re-enable save parse and fix MCR errors
* Re-enable parse on save as requested in T159014, instead hide
the feature behind an option.
* Add the MCR tables to the list of tables that need to be cloned. Fixes
unconditional exception.
* Fix some undefined member variables, remove assignment to unused
variable $this->databaseSetupDone.
Bug: T159014
Change-Id: I6be577ebcbadeb4e08079a82543d521fc2bb5948
Prateek Saxena [Thu, 19 Jul 2018 05:02:24 +0000 (10:32 +0530)]
LogPager: Add backwards-compatibility for hide_[type]_log URL params
Also, the $default value in LogEventsList#getFiltersDesc was not
being generated properly and would have always been an empty array.
Bug: T199856
Change-Id: Id286c76259406521f12cda67a4a715032e022637
jenkins-bot [Fri, 20 Jul 2018 00:06:16 +0000 (00:06 +0000)]
Merge "Convert Title::getTitleCache() to using MapCacheLRU (again)"
jenkins-bot [Fri, 20 Jul 2018 00:06:10 +0000 (00:06 +0000)]
Merge "ApiMain: Always create a new printer in getPrinterByName()"
jenkins-bot [Fri, 20 Jul 2018 00:06:05 +0000 (00:06 +0000)]
Merge "Avoid passing "false" as keys to MapCacheLRU in RepoGroup"
Aaron Schulz [Thu, 19 Jul 2018 23:40:02 +0000 (00:40 +0100)]
Convert Title::getTitleCache() to using MapCacheLRU (again)
Re-applies commit
7a25cd388c8adcce6, reverted by
3648e5683c0ff11c0.
Change-Id: I087edb15fbe11ccac7be28540e20d990f5615c4e
Aaron Schulz [Thu, 19 Jul 2018 10:02:57 +0000 (11:02 +0100)]
Avoid passing "false" as keys to MapCacheLRU in RepoGroup
Bug: T200026
Change-Id: I40f6ad2a3d281d06c9b6eaf4f31d9796ea5e9e9e
Translation updater bot [Thu, 19 Jul 2018 20:13:30 +0000 (22:13 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I78f8728c250651e132b1104d2a26047ee938ac54
jenkins-bot [Thu, 19 Jul 2018 18:19:56 +0000 (18:19 +0000)]
Merge "Convert Title::getTitleCache() to using MapCacheLRU (again)"
jenkins-bot [Thu, 19 Jul 2018 17:35:01 +0000 (17:35 +0000)]
Merge "In mysql.php ignore SIGINT"
Mark A. Hershberger [Fri, 13 Jul 2018 18:19:51 +0000 (14:19 -0400)]
Language::listToText: Avoid PHP warnings from E_STRICT
Language::listToText() uses for(;;) which assumes the index in a list
starts at 0 and following keys are consecutive integers.
This assumption fails (and results in warnings with E_STRICT) when
SpecialListGroupRights::formatPermissions() uses the key-preserving
array_intersect() to create a subset of $allGroups.
Bug: T199559
Change-Id: I4eb03a95509d69653156a2764d58c0c5d0d1dfbc
jenkins-bot [Thu, 19 Jul 2018 17:02:53 +0000 (17:02 +0000)]
Merge "RCFilters: Work around Chrome browser bug in filter menu"
jenkins-bot [Thu, 19 Jul 2018 16:59:29 +0000 (16:59 +0000)]
Merge "Set default wgMultiContentRevisionSchemaMigrationStage to write-both"
Marko Obrovac [Thu, 19 Jul 2018 16:13:38 +0000 (18:13 +0200)]
JobQueueGroup: Allow readOnlyReason to be specified per JQ type
We use $wgReadOnly for various reasons, one of which is to disallow
writes in the currently-non-active DC. However, we should allow the
readOnlyReason configuration variable to be available per JobQueue type
and have it the code respect that.
In our current set-up, we use JobQueueEventBus which ever only uses the
enqueue execution path and does not depend upon which DC it is executed
in, so this will allow us to enqueue jobs in both DCs.
Note that this is an alternative approach to the one outlined in
Ibbad6063b6b154d7f7d172c79f7be324bf80eb7e
Bug: T199594
Change-Id: I8f1a57a81ea11c1c587c0057fa8bb3454b0e0b56
Aaron Schulz [Thu, 19 Jul 2018 16:11:39 +0000 (17:11 +0100)]
filebackend: let any specific backend value of "readOnly" override the default
Previously, only different reason strings could override, but there was
no way to override the read-only mode to being off.
Change-Id: I4266694034bfbdada90d4be96bcbc1a37f5b5409
jenkins-bot [Thu, 19 Jul 2018 16:11:24 +0000 (16:11 +0000)]
Merge "docs: Remove table-layout documentation from core"
Brad Jorsch [Thu, 19 Jul 2018 13:24:48 +0000 (09:24 -0400)]
ApiMain: Always create a new printer in getPrinterByName()
ApiMain already caches the printer in ->mPrinter, so if
getPrinterByName() is being called more than once that's because we
really want a new printer instance, without any cached errors or other
behavior that results from reusing the same instance.
Bug: T199949
Change-Id: I779cbbaa8aab9b049a8eed732416edd828121ec4
jenkins-bot [Thu, 19 Jul 2018 14:40:26 +0000 (14:40 +0000)]
Merge "config: Add new ConfigRepository"
jenkins-bot [Thu, 19 Jul 2018 14:26:51 +0000 (14:26 +0000)]
Merge "registration: Expose config array to ExtensionRegistry"
Florian Schmidt [Wed, 14 Dec 2016 20:55:56 +0000 (21:55 +0100)]
config: Add new ConfigRepository
This, for now, has the focus for holding metadata of each
configuration option inside of MediaWiki (both extensions and core).
It's very close to the Config interface and friends, and uses these
implementations to retrieve the actual value of the
configuration option.
The goal with this change is to implement a basic architecture to
allow to display the values of the curent configuration of the MediaWiki
installation on-wiki (e.g. on a special page). It also provides a
central point, where the currently known options can be fetched
from.
The long-term goal, of course, would be to get a web interface to really
configure the MediaWiki installation. But, this is more like a dream,
then a plan (from the point of view of this commit).
Next steps would be:
* Enable ExtensionRegistry to "register" the configuration options of
extensions, so they're available in the repo (done).
* Find a good way to get mediawiki/core configurations into this repo
* Work out an overall architecture to display the different possible
values. (I think about something like different formatters for types).
Change-Id: I9419508eaa85ffc55520db7f33b3e9530fc99f00