From: Fomafix <fomafix@googlemail.com>
Date: Tue, 28 May 2019 18:10:48 +0000 (+0200)
Subject: mediawiki.action.view.dblClickEdit: Move preventDefault()
X-Git-Tag: 1.34.0-rc.0~1574
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/membres/fiche.php?a=commitdiff_plain;h=5267844eea035669aa3c2e597a468e6b9ee44fb2;p=lhc%2Fweb%2Fwiklou.git

mediawiki.action.view.dblClickEdit: Move preventDefault()

Move the preventDefault() into the if-condition to trigger the
preventDefault() only together with the click() trigger.

Change-Id: Icde2187248b8b18cd4fd5085a92d840e1f77b00d
---

diff --git a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
index dbf029e3c2..7b7c70d6cf 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
+++ b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
@@ -7,11 +7,11 @@
 			var $a;
 			// Recheck preference so extensions can do a hack to disable this code.
 			if ( parseInt( mw.user.options.get( 'editondblclick' ), 10 ) ) {
-				e.preventDefault();
 				// Trigger native HTMLElement click instead of opening URL (T45052)
 				$a = $( '#ca-edit a' );
 				// Not every page has an edit link (T59713)
 				if ( $a.length ) {
+					e.preventDefault();
 					// eslint-disable-next-line no-jquery/no-event-shorthand
 					$a.get( 0 ).click();
 				}