Brion Vibber [Thu, 20 Oct 2011 22:50:04 +0000 (22:50 +0000)]
QUnit test cases for bug 31847: will trigger a fail on IE 6/7/8
jquery.textSelection's getCaretPosition() gives bogus results on IE 6/7/8 when there's not a selection set in the textarea; it seems to give us some value somewhere in the middle of the textarea, rather than what we expected.
If we actually set an empty selection, then it gets it back just fine!
But if the cursor is in initial state, or has been moved by the user, we get back garbage. This is causing WikiEditor to sometimes insert things in the wrong place, as it tries to pull the caret position and manipulate the selection to do insertions; we then end up using the bogus selection when it gets saved in via selection restoration.
Krinkle [Thu, 20 Oct 2011 22:35:27 +0000 (22:35 +0000)]
Updating jquery.qunit from upstream
* Source: https://github.com/jquery/qunit/tree/
ee156923cdb01820e35e6bb579d5cf6bf55736d4
-- Several bug fixes
-- New hooks system
-- Version numbers, finally (this is 1.2.0pre)
-- (BREAKING CHANGE) start/stop now takes count instead of timeout as first argument (read more at https://github.com/jquery/qunit/pull/125 and http://docs.jquery.com/QUnit/stop)
Krinkle [Thu, 20 Oct 2011 22:34:05 +0000 (22:34 +0000)]
[JSTesting] Fix dependencies. Of course jquery.qunit.completenessTest needs jquery.qunit
Krinkle [Thu, 20 Oct 2011 22:33:05 +0000 (22:33 +0000)]
[JSTesting] Don't rely on the timeout argument of start/stop. This behavior is removed in the latest QUnit version.
-- Actually, in the latest QUnit version start/stop take 'count' as first argument. It would internally set the number of wait levels to 5000 xD
Sam Reed [Thu, 20 Oct 2011 21:22:59 +0000 (21:22 +0000)]
After r100379, move release notes for bug 29392
Raimond Spekking [Thu, 20 Oct 2011 19:16:53 +0000 (19:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 20 Oct 2011 19:05:48 +0000 (19:05 +0000)]
More whitespace tweaks...and fixed doc typo
Aaron Schulz [Thu, 20 Oct 2011 17:13:53 +0000 (17:13 +0000)]
Removed deprecated getFullPath(); no callers
Mark A. Hershberger [Thu, 20 Oct 2011 15:12:13 +0000 (15:12 +0000)]
eol w/s
Mark A. Hershberger [Thu, 20 Oct 2011 14:46:29 +0000 (14:46 +0000)]
Revert r79363, r79364, and r79369 to disable datalists support entirely based
on Bug 31602, Bug 31697, Bug 31654, Bug 31658, and even Aryeh Gregor's
comments in
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-December/029593.html
Antoine Musso [Thu, 20 Oct 2011 14:28:41 +0000 (14:28 +0000)]
(bug 31345) document API Revisions parameters as enum
Patch by Brad Jorsch.
Alexandre Emsenhuber [Thu, 20 Oct 2011 10:29:51 +0000 (10:29 +0000)]
Fix for r100333: forgot to override requiresWrite() and requiresUnblock()
Alexandre Emsenhuber [Thu, 20 Oct 2011 08:10:25 +0000 (08:10 +0000)]
* Changed action=raw to use an Action subclass
* Left RawPage with back compat code for extensions that use it
* Removed calls to Skin for gen=(css|js). Calling action=raw&gen=(css|js) will now unconditionally return empty content
* Removed Skin::generateUserJs() and Skin::generateUserStylesheet() since they were only used in RawPage
Raimond Spekking [Thu, 20 Oct 2011 07:36:22 +0000 (07:36 +0000)]
* (bug 25306) Add link of old page title to MediaWiki:Delete_and_move_reason
Aaron Schulz [Thu, 20 Oct 2011 03:03:45 +0000 (03:03 +0000)]
* Simplified r100286 by just using the field 'user_name' and removed the COALESCE
* Simplified contribs pager with Revision::selectFields()
Aaron Schulz [Thu, 20 Oct 2011 02:26:59 +0000 (02:26 +0000)]
Moved contribs rev parent ID batch query into doBatchLookups()
Aaron Schulz [Thu, 20 Oct 2011 01:15:28 +0000 (01:15 +0000)]
* Made ?contribs=user actually show the results for the *user* if 'newbies' was given as the user.
* Added a link batch query to newbie contribs paging
Aaron Schulz [Thu, 20 Oct 2011 00:43:43 +0000 (00:43 +0000)]
* Added a proper Pager::doBatchLookups() function
* Made HistoryPager use a link batch via Pager::doBatchLookups()
Aaron Schulz [Thu, 20 Oct 2011 00:41:48 +0000 (00:41 +0000)]
FU r100300, r100286:
* Updated link batch code in MergeHistory
* Marked some Revision functions explicitly public
Aaron Schulz [Thu, 20 Oct 2011 00:04:14 +0000 (00:04 +0000)]
JOIN to get user_name in Contributions, HistoryPage, RevisionList, RevisionDelete, and MergeHistory
Aaron Schulz [Wed, 19 Oct 2011 23:56:48 +0000 (23:56 +0000)]
FU r100286: Added sanity check to fetchFromConds() join conds
Aaron Schulz [Wed, 19 Oct 2011 22:25:26 +0000 (22:25 +0000)]
* Tweaked Revision class to handle loading the current user name instead of rev_user_text. It still falls back to rev_user_text when building objects from DB rows for b/c.
* Moved JOIN conds to fetchFromConds() as that's where the tables are specified. This lets us avoid the same page_id=rev_page join conds plastered all over the code. Also, we can't mix WHERE and JOIN style join conds.
* Removed duplication in fetchFromConds() by using selectPageFields().
* Removed duplicate rev_parent_id field from contribs SELECT.
Yo make use of these changes, Pagers and lists still need to be updated to use Revision::selectUserFields() and join on the user table.
Aaron Schulz [Wed, 19 Oct 2011 21:21:20 +0000 (21:21 +0000)]
Code cleanups & fixed strange comma
Raimond Spekking [Wed, 19 Oct 2011 20:15:34 +0000 (20:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Wed, 19 Oct 2011 20:08:15 +0000 (20:08 +0000)]
Add some braces
Unindent most of the code
Mark A. Hershberger [Wed, 19 Oct 2011 20:01:50 +0000 (20:01 +0000)]
Revert r100262 — wasn't the right place for it and other problems,
like broken parser tests.
Please read [[Manual:Pre-commit checklist]] before committing.
Jeroen De Dauw [Wed, 19 Oct 2011 19:38:17 +0000 (19:38 +0000)]
we want to get the edit token, not edit the token...
Mark A. Hershberger [Wed, 19 Oct 2011 19:34:56 +0000 (19:34 +0000)]
Give a clear error message instead of un-intelligible UNIQ.*QINU
markers.
Not sure the preg_match() is actually needed. Or it may be
appropriate to use MARKER_SUFFIX for the match.
The error message may also need to be rewritten to be more
user-friendly, but I'm pretty sure *an* error message is friendlier
than UNIQ garbage. And making them visible error messages makes them
easier to be found.
Aaron Schulz [Wed, 19 Oct 2011 18:50:34 +0000 (18:50 +0000)]
Join ipb_by to user table to get the user name. If we can't find a user, fallback to ipb_by_text. This lets centralauth blocks have the blocking user be displayable again.
Aaron Schulz [Wed, 19 Oct 2011 17:30:55 +0000 (17:30 +0000)]
* Fixed undefined var $g error
* Style cleanups
Raimond Spekking [Wed, 19 Oct 2011 17:15:05 +0000 (17:15 +0000)]
Change the hook case per CR r95152
Happy-melon [Wed, 19 Oct 2011 17:09:04 +0000 (17:09 +0000)]
Follow-up r82285: we should not apply case conversion to these names, because it's unintuitive and potentially risky when they could theoretically contain weird characters. It was necessary before r86508, but not now there is a prefix meaning the group name is not at the start of the title. Plus the default messages are already at the lowercase titles.
Alexandre Emsenhuber [Wed, 19 Oct 2011 15:30:02 +0000 (15:30 +0000)]
Follow-up r100227:
* Missed one call to ParserOptions::getUserLang() in Parser
* Also convert RefreshLinksJob and RefreshLinksJob2 to use ParserOptions::newFromUserAndLang() and pass $wgContLang instead of whatever $wgLang could be
Platonides [Wed, 19 Oct 2011 15:15:08 +0000 (15:15 +0000)]
It is valid (albeit silly) to specify lang;q=1.000 No more than three decimals are allowed.
(rfc2616 section 3.9: Quality Values)
The language-range may contain more than one - (section 14.4) such as x-pig-latin
(section 3.10: Language Tags)
Alexandre Emsenhuber [Wed, 19 Oct 2011 14:52:26 +0000 (14:52 +0000)]
Don't reinvent the wheel in LegacyTemplate::pageStats(), just use them items from SkinTemplate
Alexandre Emsenhuber [Wed, 19 Oct 2011 14:16:01 +0000 (14:16 +0000)]
* Changed ParserOptions to store a Language object instead of only a string, avoids object -> string -> object conversion
* ParserOptions::getUserLang() will still return a string for compatibility, added ParserOptions::getUserLangObj() to get the object
* Added ParserOptions::newFromUserAndLang() and ParserOptions::newFromContext() to easily get a ParserOptions object when a context is available or when someone wants to force the language
* Updated OutputPage and Preferences to use newFromContext() and WikiPage to use newFromUserAndLang()
* ParserOptions::setUserLang() still accepts either a string or a Language object, but changed the calls to pass an object instead of a string
* Changed Parser::getFunctionLang() to return the Language object from ParserOptions when parsing interface messages rather than $wgLang directly and updated the documentation to say that $wgLang should not be used directly (as $wgUser, $wgTitle and $wgRequest)
Philip Tzou [Wed, 19 Oct 2011 14:13:41 +0000 (14:13 +0000)]
Revert unihan.zip's version to 5.2.0.
Philip Tzou [Wed, 19 Oct 2011 13:51:33 +0000 (13:51 +0000)]
Fix some incorrect rules. Fxxk unihan.zip!
Philip Tzou [Wed, 19 Oct 2011 13:10:16 +0000 (13:10 +0000)]
Fix a bug existed in Makefile.py which allows single character appearring in words list.
Philip Tzou [Wed, 19 Oct 2011 12:19:00 +0000 (12:19 +0000)]
Update Chinese conversion table: follow r90409, fix an incorrect rule.
Raimond Spekking [Wed, 19 Oct 2011 09:35:33 +0000 (09:35 +0000)]
Fix r100138 per Nikas CR: "always use explicit conversion to string with wfMessage"
Aaron Schulz [Wed, 19 Oct 2011 04:06:16 +0000 (04:06 +0000)]
* Removed newFileFromKey() which had a misleading description and a bug where giving a sha1,time could fail if two current version files existed with the same sha1 but different timestamps. Merged the code into findFileFromKey().
* Fixed bug in findFileFromKey() were it would bail out if it couldn't find a matching current file without even check for matching old files.
* Fixed timestamp format of oi_timestamp condition in newFromKey().
* Some code style cleanups.
Ryan Kaldari [Wed, 19 Oct 2011 00:53:39 +0000 (00:53 +0000)]
more accurate documentation for addValue() method
Aaron Schulz [Wed, 19 Oct 2011 00:14:13 +0000 (00:14 +0000)]
Minor code style cleanups and tweaks
Siebrand Mazeland [Tue, 18 Oct 2011 22:51:48 +0000 (22:51 +0000)]
Clarify proxyblockreason per suggestion of Amir.
Siebrand Mazeland [Tue, 18 Oct 2011 22:24:51 +0000 (22:24 +0000)]
Use spaces around "×" for consistency.
Sam Reed [Tue, 18 Oct 2011 21:47:51 +0000 (21:47 +0000)]
Remove some more code after r98467
Mark A. Hershberger [Tue, 18 Oct 2011 21:09:52 +0000 (21:09 +0000)]
revert r99562 and set standard_conforming_strings “on” by default
Krinkle [Tue, 18 Oct 2011 20:00:17 +0000 (20:00 +0000)]
Add bug id, follows-up r99934didn't know there was a bug about that
Raimond Spekking [Tue, 18 Oct 2011 19:31:51 +0000 (19:31 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Tue, 18 Oct 2011 18:07:56 +0000 (18:07 +0000)]
Fix for r100114: make API and tests work again
Raimond Spekking [Tue, 18 Oct 2011 17:57:32 +0000 (17:57 +0000)]
* (bug 18823) "move succeeded" text displays bluelinks even when redirect was suppressed
Ping r100017 for the subpage part.
Sam Reed [Tue, 18 Oct 2011 17:50:59 +0000 (17:50 +0000)]
Kill unused maintenance script (probably rotten and seriously out of date also)
Sam Reed [Tue, 18 Oct 2011 17:32:20 +0000 (17:32 +0000)]
Remove some unused getting of non existent arguments
Documentation
Sam Reed [Tue, 18 Oct 2011 17:31:54 +0000 (17:31 +0000)]
Remove some unused getting of non existent arguments
Documentation
Sam Reed [Tue, 18 Oct 2011 17:30:36 +0000 (17:30 +0000)]
Cleanup whitespace
Couple of bits of documentation
Sam Reed [Tue, 18 Oct 2011 17:29:06 +0000 (17:29 +0000)]
Kill dead/rotting importUseModWiki(pedia)? maintenance scripts
Sam Reed [Tue, 18 Oct 2011 17:27:52 +0000 (17:27 +0000)]
Documentation
Explicit member variable definitions
Simplify some code
Sam Reed [Tue, 18 Oct 2011 17:26:09 +0000 (17:26 +0000)]
Add documentation
Fix some unused variables, commented some others out
Raimond Spekking [Tue, 18 Oct 2011 15:13:37 +0000 (15:13 +0000)]
Add namespace gender aliases for 'dsb' and 'hsb' per https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=
94929642#Geschlechtsspezifische_Namensr.C3.A4ume
Alexandre Emsenhuber [Tue, 18 Oct 2011 14:08:48 +0000 (14:08 +0000)]
* Use local context instead of global variables
* Pass the context between Special:Userlogin and Special:ChangePassword when calling the other one
Alexandre Emsenhuber [Tue, 18 Oct 2011 13:53:27 +0000 (13:53 +0000)]
Fix for r97314: add HttpError to the AutoLoader
Antoine Musso [Tue, 18 Oct 2011 09:01:05 +0000 (09:01 +0000)]
Qunit coverage for mw.Title.js
Follow up comment on r93702 asking to cover:
new mw.Title( 'user:NeilK' );
Also added a case conversion test
Krinkle [Mon, 17 Oct 2011 22:57:50 +0000 (22:57 +0000)]
Fix svn props, r99919
Platonides [Mon, 17 Oct 2011 21:11:28 +0000 (21:11 +0000)]
Remove unused global $wgLoadScript
Platonides [Mon, 17 Oct 2011 21:00:42 +0000 (21:00 +0000)]
Remove global added in 2005 by vibber (r11563). There's a new one added in r99349.
Raimond Spekking [Mon, 17 Oct 2011 19:32:40 +0000 (19:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Mon, 17 Oct 2011 19:16:33 +0000 (19:16 +0000)]
* (bug 31692) "summary" parameter now also work when undoing revisions
Rotem Liss [Mon, 17 Oct 2011 16:31:26 +0000 (16:31 +0000)]
Localization update for he.
Happy-melon [Mon, 17 Oct 2011 16:16:26 +0000 (16:16 +0000)]
(bug 31405) block reason preload. Patch by Brad Jorsch.
Antoine Musso [Mon, 17 Oct 2011 15:57:47 +0000 (15:57 +0000)]
add useful comments about portlet ids
comments comes from r95571 commit log by Krinkle
Happy-melon [Mon, 17 Oct 2011 15:56:25 +0000 (15:56 +0000)]
Type hinting
Alexandre Emsenhuber [Mon, 17 Oct 2011 14:33:04 +0000 (14:33 +0000)]
Added a User parameter to SpecialPageFactory::getUsablePages() so that it does not need to depend on $wgUser; updated the only call to it
Alexandre Emsenhuber [Mon, 17 Oct 2011 14:17:52 +0000 (14:17 +0000)]
Use local context to get messages
Raimond Spekking [Mon, 17 Oct 2011 10:29:16 +0000 (10:29 +0000)]
Fix native name of Ligurian: translatewiki.net/wiki/Thread:Support/Wrong_name_for_language!!!!
Compare with http://www.ethnologue.com/show_language.asp?code=lij and https://lij.wikipedia.org/wiki/Lengoa_ligure
Antoine Musso [Mon, 17 Oct 2011 09:46:05 +0000 (09:46 +0000)]
adding note to code snippet
This small comment will avoid us using pathinfo() again and reimplement
bug 30219.
follow up r94171
Raimond Spekking [Mon, 17 Oct 2011 09:11:07 +0000 (09:11 +0000)]
Old link is not always known, it depends on $createRedirect
Russ Nelson [Sun, 16 Oct 2011 23:03:17 +0000 (23:03 +0000)]
StoreBatchTest counts even MORE correct than before.
Daniel Friesen [Sun, 16 Oct 2011 22:56:14 +0000 (22:56 +0000)]
Followup r99404, remove <sup> tags.
Krinkle [Sun, 16 Oct 2011 22:33:04 +0000 (22:33 +0000)]
Fix broken test by r99321
Krinkle [Sun, 16 Oct 2011 22:30:28 +0000 (22:30 +0000)]
Adding missing test for isEmpty
Chad Horohoe [Sun, 16 Oct 2011 22:25:41 +0000 (22:25 +0000)]
Forgot lowercase again, arrggghhhh
Chad Horohoe [Sun, 16 Oct 2011 22:25:18 +0000 (22:25 +0000)]
Do a test for 1K
Chad Horohoe [Sun, 16 Oct 2011 22:24:30 +0000 (22:24 +0000)]
Add another test case for shorthand to integer (lowercase too)
Chad Horohoe [Sun, 16 Oct 2011 22:24:13 +0000 (22:24 +0000)]
Add another test case for shorthand to integer
Russ Nelson [Sun, 16 Oct 2011 22:18:18 +0000 (22:18 +0000)]
StoreBatchTest counts now correct, and using assertEquals
Sam Reed [Sun, 16 Oct 2011 22:14:23 +0000 (22:14 +0000)]
After merging r98374 into REL1_18 in r99980, move RELEASE-NOTES to 1.18
Sam Reed [Sun, 16 Oct 2011 22:01:10 +0000 (22:01 +0000)]
Few bits of documentation
Platonides [Sun, 16 Oct 2011 19:53:30 +0000 (19:53 +0000)]
Parse error (missing ';') in r99938.
Sam Reed [Sun, 16 Oct 2011 19:52:46 +0000 (19:52 +0000)]
Remove duplicate setting of From
Raimond Spekking [Sun, 16 Oct 2011 19:48:07 +0000 (19:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Chad Horohoe [Sun, 16 Oct 2011 18:35:32 +0000 (18:35 +0000)]
Initial tests for wfShorthandToInteger(). Definitely needs more
Max Semenik [Sun, 16 Oct 2011 15:08:38 +0000 (15:08 +0000)]
Fixed bug in r99914, also reverted accidental tabs->spaces conversion
Alexandre Emsenhuber [Sun, 16 Oct 2011 13:16:45 +0000 (13:16 +0000)]
Per Nikerabbit, fix for r99863: removed copy/paste error in method documentation
Alexandre Emsenhuber [Sun, 16 Oct 2011 12:39:05 +0000 (12:39 +0000)]
* Send "undisclosed-recipients" in "To" header when sending the mail to more than one user instead of checking $wgEnotifImpersonal. This was causing Special:EmailUser to send mails with that header when $wgEnotifImpersonal is true
* Fix for r91662: Return-Path must an e-mail address and only a e-mail address, it cannot be "Name <address@...>"
* Code simplification
Alexandre Emsenhuber [Sun, 16 Oct 2011 09:53:41 +0000 (09:53 +0000)]
* Do magic word parsing after parameter replacement in MediaWiki:Enotif_body and MediaWiki:Enotif_subject
* Fix link to Special:EmailUser in case $wgEnotifUseRealName was true and the user defined a real name, link was pointing to Special:EmailUser/Real_Name instead of Special:EmailUser/User_Name
* Simplified the code of EmailNotification::composeCommonMailtext()
Sam Reed [Sun, 16 Oct 2011 03:32:39 +0000 (03:32 +0000)]
svn:eol-style native
Sam Reed [Sun, 16 Oct 2011 03:27:12 +0000 (03:27 +0000)]
Fixup some assignments in conditionals
Add/normalise some more return statements
Krinkle [Sat, 15 Oct 2011 23:51:24 +0000 (23:51 +0000)]
Add 'padding: 0;' for '.catlinks ul' in commonPrint as well
* Follows-up r97381 adding it to shared.css
* Reason: Several browsers have defaults like padding-left: 40px; for unordered lists. That looks rather ugly if the list is used with inline list items (as is the case for cat links)
Krinkle [Sat, 15 Oct 2011 23:48:14 +0000 (23:48 +0000)]
Drop IE5.x support
-- except for fixalpha/IE5.5 (iirc this is for IE6 as well)