From fd56227ac3aec7fe313f2479d078e14ce4a1260a Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Tue, 28 Feb 2012 02:36:29 +0000 Subject: [PATCH] Fix scoping in r112451: isReady was accidentally used as a global variable --- resources/mediawiki.action/mediawiki.action.edit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/mediawiki.action/mediawiki.action.edit.js b/resources/mediawiki.action/mediawiki.action.edit.js index c5e38fffa6..6b10485253 100644 --- a/resources/mediawiki.action/mediawiki.action.edit.js +++ b/resources/mediawiki.action/mediawiki.action.edit.js @@ -9,7 +9,7 @@ // If you want to add buttons, use // mw.toolbar.addButton( imageFile, speedTip, tagOpen, tagClose, sampleText, imageId, selectText ); addButton : function() { - if ( isReady ) { + if ( this.isReady ) { this.insertButton.apply( this, arguments ); } else { this.buttons.push( [].slice.call( arguments ) ); @@ -48,7 +48,7 @@ onReady : function() { this.$toolbar = $( '#toolbar' ); - isReady = true; + this.isReady = true; // Legacy // Merge buttons from mwCustomEditButtons var buttons = [].concat( this.buttons, window.mwCustomEditButtons ); -- 2.20.1