Aryeh Gregor [Fri, 21 Aug 2009 21:34:52 +0000 (21:34 +0000)]
Omit useless value="" in Html::input()
Brion Vibber [Fri, 21 Aug 2009 21:26:34 +0000 (21:26 +0000)]
No need to store the value of the magic quotes check here; just use a local var for clarity.
Siebrand Mazeland [Fri, 21 Aug 2009 21:25:08 +0000 (21:25 +0000)]
Localisation updates for special page aliases from translatewiki.net
Siebrand Mazeland [Fri, 21 Aug 2009 21:17:54 +0000 (21:17 +0000)]
Localisation updates for core magic words from translatewiki.net
Siebrand Mazeland [Fri, 21 Aug 2009 21:09:57 +0000 (21:09 +0000)]
Localisation extension for core messages from translatewiki.net (2009-08-21 20:59 UTC)
Aryeh Gregor [Fri, 21 Aug 2009 21:06:28 +0000 (21:06 +0000)]
Don't output useless value=""
Aryeh Gregor [Fri, 21 Aug 2009 21:06:06 +0000 (21:06 +0000)]
Only require necessary fields in Special:ResetPass
This fixes r54567. That made the password fields on Special:ResetPass
always required, but in fact the current password should never be
required (existing users always might have empty passwords), and the new
password is only required if $wgMinimalPasswordLength > 0.
This commit also permits passing array( 'required' ) to
Html::(rawE|e)lement() instead of array( 'required' => 'meaningless' ),
for boolean attribs only. This syntax is used in SpecialResetpass.
Aryeh Gregor [Fri, 21 Aug 2009 20:50:35 +0000 (20:50 +0000)]
Move validation logic from input() to rawElement()
This way callers of rawElement() or element() will also get correct
behavior.
Aryeh Gregor [Fri, 21 Aug 2009 20:39:35 +0000 (20:39 +0000)]
Switch from Xml:: to Html:: in a few places
These should all theoretically be covered by the parser tests. All
tests pass, the only change needed was to account for less overescaping
in Html::expandAttributes(). There's no reason to escape <>' in
"-quoted attributes, unless I'm mistaken and have just added some XSS.
Aryeh Gregor [Fri, 21 Aug 2009 20:39:16 +0000 (20:39 +0000)]
Correct outdated comments
Aryeh Gregor [Fri, 21 Aug 2009 20:38:53 +0000 (20:38 +0000)]
Don't escape >" in tag contents, no point
Alexandre Emsenhuber [Fri, 21 Aug 2009 20:18:20 +0000 (20:18 +0000)]
* (bug 20296) Fixed a PHP warning in Parser::preSaveTransform() in PHP 5.3: Parameter 1 was expected to be a reference but value given when unstubbing $wgContLang
Brion Vibber [Fri, 21 Aug 2009 18:11:13 +0000 (18:11 +0000)]
Fix for wgArticleId being exported to JavaScript as a string instead of integer. :P
Throw around some intval()s on page id, length data coming out of database into Title and Article objects and the link cache... blast PHP's soft typing!
Philip Tzou [Fri, 21 Aug 2009 16:00:01 +0000 (16:00 +0000)]
1. Revert my revision r55371. Since it may override logged user's settings.
2. Patch for situations that some wikis like zhwikisource may disabled some language variants. We should treat these disabled variants unacceptable in LanguageConverter.
Shinjiman [Fri, 21 Aug 2009 14:36:04 +0000 (14:36 +0000)]
*(bug 17742) Fixes inconsistent special page aliases for the Taiwanese language.
Philip Tzou [Fri, 21 Aug 2009 04:44:46 +0000 (04:44 +0000)]
Add and modify parser test for new language converter rules.
Chad Horohoe [Fri, 21 Aug 2009 00:59:11 +0000 (00:59 +0000)]
Move dumpRev and orphanStats to subclass Maintenance. Make orphanStats bail out early if blob_orphans doesn't exist. dumpRev could use a nice description.
Chad Horohoe [Fri, 21 Aug 2009 00:32:38 +0000 (00:32 +0000)]
Remove random comments.
Alex Z [Fri, 21 Aug 2009 00:25:39 +0000 (00:25 +0000)]
Delete maintenance/fetchInterwiki.pl - has been obsolete since r1589
Alex Z [Fri, 21 Aug 2009 00:22:08 +0000 (00:22 +0000)]
Tweak Access-Control-Allow-Origin stuff per comments on r54127.
Use a wildcard syntax rather than string/regex options
Rotem Liss [Thu, 20 Aug 2009 21:49:59 +0000 (21:49 +0000)]
Localization update.
Alexandre Emsenhuber [Thu, 20 Aug 2009 21:35:22 +0000 (21:35 +0000)]
Document wfWarn() function
Brion Vibber [Thu, 20 Aug 2009 21:31:38 +0000 (21:31 +0000)]
bug 20327 Error in FlaggedRevs.hooks.php after r55168's restructuring of history page classes
Aryeh Gregor [Thu, 20 Aug 2009 21:30:47 +0000 (21:30 +0000)]
Remove somewhat braindead comments
On second thought, if you're outputting user-supplied JS without careful
validation, it doesn't really matter if it's HTML-escaped or not. :D
CSS has expr() and such too.
Alex Z [Thu, 20 Aug 2009 21:06:24 +0000 (21:06 +0000)]
Update ChangesList output for enhanced changes to use CSS instead of obsolete attrbutes and elements (cellpadding, <tt>, etc.)
The test page I was using successfully validated as HTML 5 :)
Tested for signs of obvious regressions in FF 3.5, IE8, Opera 9.64 and Safari 4.0.
Supposedly, the border-spacing property isn't supported by IE, but I didn't see any obvious issues when testing,
so either the information I got was wrong/outdated, or its not actually necessary here. Needs testing in IE6/7 to verify.
If I did everything right, there shouldn't be any visible changes, save maybe a couple trivial spacing quirks.
Ilmari Karonen [Thu, 20 Aug 2009 15:27:51 +0000 (15:27 +0000)]
add parser test for r55382
Ilmari Karonen [Thu, 20 Aug 2009 14:56:11 +0000 (14:56 +0000)]
(bug 15248) Normalize NBSP and other odd Unicode whitespace characters to normal spaces.
Note: run cleanupTitles.php and cleanupImages.php after deploying this!
Michael Dale [Thu, 20 Aug 2009 14:06:16 +0000 (14:06 +0000)]
* non firefogg add media wizard upload updates (only works once bug noted)
Raimond Spekking [Thu, 20 Aug 2009 13:41:34 +0000 (13:41 +0000)]
Follow-up r55368: Fix parser tests
Michael Dale [Thu, 20 Aug 2009 13:31:25 +0000 (13:31 +0000)]
* working inline uploader
Michael Dale [Thu, 20 Aug 2009 12:14:14 +0000 (12:14 +0000)]
* skin revert
Michael Dale [Thu, 20 Aug 2009 12:05:16 +0000 (12:05 +0000)]
* restored control Builder as wel
Michael Dale [Thu, 20 Aug 2009 11:57:37 +0000 (11:57 +0000)]
* partial revert to 55208 (pre kskin)
Philip Tzou [Thu, 20 Aug 2009 11:45:49 +0000 (11:45 +0000)]
Fixed some of tests failed caused by r55371.
Michael Dale [Thu, 20 Aug 2009 11:37:48 +0000 (11:37 +0000)]
* kskin final state before revert for presentations
Philip Tzou [Thu, 20 Aug 2009 11:16:19 +0000 (11:16 +0000)]
Set linkTrail for Chinese language. There is no character should be appended to a titlelink in Chinese wiki.
Philip Tzou [Thu, 20 Aug 2009 11:11:15 +0000 (11:11 +0000)]
Save the variant find from HTTP_ACCEPT_LANGUAGE to $mPreferredVariant, so we do not need to do it again.
Michael Dale [Thu, 20 Aug 2009 10:29:09 +0000 (10:29 +0000)]
* slightly better sequencer css layout.
* now to fix the mismatched selectors *****I hate kskin right now****
Michael Dale [Thu, 20 Aug 2009 09:55:40 +0000 (09:55 +0000)]
* minor css fixes
* fixes to inline uploads
* stubs for recent uploaded asset import listing
Raimond Spekking [Thu, 20 Aug 2009 09:13:29 +0000 (09:13 +0000)]
* (bug 20318) Distinct CSS classes for ISBN/RFC/PMID special links added
Michael Dale [Thu, 20 Aug 2009 05:44:10 +0000 (05:44 +0000)]
* moved $wgEnableTemporalOggUrls configuration var from default settings to oggHandler
Michael Dale [Thu, 20 Aug 2009 04:28:52 +0000 (04:28 +0000)]
* broken kskin integration mvpcf bootstrapping
Brion Vibber [Wed, 19 Aug 2009 23:40:48 +0000 (23:40 +0000)]
De-clutter base directory; moving install-utils.inc into maintenance.
Chad Horohoe [Wed, 19 Aug 2009 23:35:24 +0000 (23:35 +0000)]
Oops and fix the test it was supposed to check.
Chad Horohoe [Wed, 19 Aug 2009 23:34:42 +0000 (23:34 +0000)]
Add dash to Britney Spears
Siebrand Mazeland [Wed, 19 Aug 2009 22:47:58 +0000 (22:47 +0000)]
Localisation updates for core messages from translatewiki.net (2009-08-19 22:36 UTC)
Michael Dale [Wed, 19 Aug 2009 18:48:12 +0000 (18:48 +0000)]
* minor updates
Trevor Parscal [Wed, 19 Aug 2009 18:34:07 +0000 (18:34 +0000)]
Incrimented $wgStyleVersion to refelct the changes in r55333.
Brion Vibber [Wed, 19 Aug 2009 18:28:59 +0000 (18:28 +0000)]
fix up doc comment on Database::buildConcat()
Brion Vibber [Wed, 19 Aug 2009 18:22:31 +0000 (18:22 +0000)]
Cleanup for r54264 "* Don't suppress warnings while developing, wasting my time for debugging"
Remove the warning suppression entirely; if you're seeing any warnings come up here it's probably because you forgot an isset() :) Please find and fix any such items.
Trevor Parscal [Wed, 19 Aug 2009 18:19:42 +0000 (18:19 +0000)]
Bug #20175 identifies some rendering artifacts which started popping up when we started messing with the font sizes of Vector at the body level. The problem is that Vector was originally designed with a fixed font size set at the body level, but using fixed font sizes like px and pt (which browsers like IE 5 - 7 don't scaled with user's prefs) - so changing it to something relative caused other issues like the tabs not lining up right and such. This patch switches the approach to using a 100% font size on everything except for the actual text in the UI, usually set at the a or span tag level (closest to text as possible). Everything in the #bodyContent and #siteNotice is also scaled at that level, so content can use relative sizes as usual without any change in behavior. This approach avoids strange rounding errors which each browser seems to handle differently, making the tabs look right - while also giving users of older IE browser control over their font sizes. Thus, this fixes #20175.
Brion Vibber [Wed, 19 Aug 2009 17:34:08 +0000 (17:34 +0000)]
Revert r54291 "(bug 19004) Added support for tags to the API. Patch by Matthew Britton."
Per notes on code review, this doesn't handle multiple tags correctly right now.
Brion Vibber [Wed, 19 Aug 2009 17:03:00 +0000 (17:03 +0000)]
Break installer guts out of config/index.php so we can display the "arglebargle need PHP 5" error.
The installer now uses enough PHP 5 features that PHP 4 won't even parse the file. :)
Still todo:
* auto-forward hits from index.php to index.php5 on a PHP 4/5 mixed setup
Michael Dale [Wed, 19 Aug 2009 16:29:35 +0000 (16:29 +0000)]
* some k-skin clean up for better jquery.ui compatibility
Michael Dale [Wed, 19 Aug 2009 14:35:50 +0000 (14:35 +0000)]
* some sequence fixes
Michael Dale [Wed, 19 Aug 2009 13:01:45 +0000 (13:01 +0000)]
* crappy broken kskin merge with mvpcf for now
* minor sequencer fix
* other minor code cleanup
Michael Dale [Wed, 19 Aug 2009 11:58:02 +0000 (11:58 +0000)]
* don't wrap video player container if already in DOM
Michael Dale [Wed, 19 Aug 2009 11:42:38 +0000 (11:42 +0000)]
* playhead width and player select fixes
Andrew Garrett [Wed, 19 Aug 2009 11:06:13 +0000 (11:06 +0000)]
Add doc comment for JS2 dependency in live preview enhancements from r55239
Michael Dale [Wed, 19 Aug 2009 10:39:33 +0000 (10:39 +0000)]
* working display of menus .. now to fix j hooking
Siebrand Mazeland [Wed, 19 Aug 2009 10:28:33 +0000 (10:28 +0000)]
* remove message "wgfogg_wrong_version"; was unused
* rename some message keys, to avoid duplicates in mwEmbed.i18n.php with other MediaWiki message keys (not yet done)
* fix link errors and unwanted changes introduced in r55296 where ":" was replaced by " : " also in messages
* update mwEmbed.i18n.php with updated keys
Michael Dale [Wed, 19 Aug 2009 09:07:58 +0000 (09:07 +0000)]
* updated kskin integration (still mostly broken)
Benjamin Lees [Wed, 19 Aug 2009 05:41:42 +0000 (05:41 +0000)]
Follow-up to mediawiki.org/wiki/Special:Code/MediaWiki/54561: use the class autoloader.
Brion Vibber [Wed, 19 Aug 2009 05:08:17 +0000 (05:08 +0000)]
newline at end of output :)
Brion Vibber [Wed, 19 Aug 2009 02:33:04 +0000 (02:33 +0000)]
Revert r54585 "Fix bug 19261 by saving the username as the signature if it is submitted empty"
Looks like the base problem is that empty is being interpreted as "put empty in the sig" instead of as "use default sig" at signature replacement time.
We shouldn't be saving the username into preferences if it hasn't been explicitly typed; if the user changes their name, they should automatically pick up the new value.
Brion Vibber [Wed, 19 Aug 2009 02:17:05 +0000 (02:17 +0000)]
Follow-up r54629 - clarify that we're making the style sheets work in Opera, not that we're making them not work :)
Brion Vibber [Wed, 19 Aug 2009 02:07:00 +0000 (02:07 +0000)]
Revert image crop for now:
r54746 "Update formatting for r54745"
r54745 "Added crop support for inline images."
r54748 "Making demon happy (adding public/protected to function definitions) and add some comments along the way."
Several issues:
* Implementation is ImageMagick-specific, no support for GD backend
* Specification syntax is pretty ugly and non-obvious imo... [[File:foo.jpg|<width>px|<left>x<top>x<width>x<height]]
* Crop syntax seems to be tied to pixels... I _presume_ source pixels? This would break if a file is re-uploaded with a new size.
* In general I'm very leery of tacking on more infinite-options-in-infinte-combinations for image rendering; our treatment of resizing already has implications for CPU and disk usage and this just adds another level of arbitrary-rendered horror. ;)
I'd much rather we move towards limiting the number of rendered variants we have, not increase them... IMO cropping would be better served with an interface allowing for explicit, visible cropping which creates either a new saved version, or a 'cloned' virtual file which can be referred to by name... and more importantly, uses of it would be trackable so that if crops needs to be updated they can be cleanly.
Chad Horohoe [Wed, 19 Aug 2009 01:55:13 +0000 (01:55 +0000)]
Followup r53884, use wfSuppressWarnings/wfRestoreWarnings instead of @
Brion Vibber [Wed, 19 Aug 2009 01:39:05 +0000 (01:39 +0000)]
Cleanup from r54770 "Add Html::input() convenience function"
Split the giant arrays of attributes/values to one item per line, which makes them easier to look at, easier to grep, and easier to see what's happening when they're changed in diffs.
We're not printing; vertical space isn't at a premium. ;)
Siebrand Mazeland [Wed, 19 Aug 2009 01:07:27 +0000 (01:07 +0000)]
Fix syntax error from r55287
Chad Horohoe [Wed, 19 Aug 2009 00:46:18 +0000 (00:46 +0000)]
Redo r54644. php -l still sucks, but some people don't have parsekit. So let's support both :)
Michael Dale [Wed, 19 Aug 2009 00:28:57 +0000 (00:28 +0000)]
* language updates and fixes/enhancements to js/php merge system
Brion Vibber [Wed, 19 Aug 2009 00:26:59 +0000 (00:26 +0000)]
Multithreaded rebuild currently relies on PHP's pcntl extension, which is not present by default and unsupported on Windows.
Rather than just spitting out a fatal error, let's gracefully fall back to single threading and tell the user why.
(Also now actually validating the thread number, though a maximum might be wise. ;)
Note that this could be implemented without pcntl instead by shelling out to subprocesses.
Siebrand Mazeland [Wed, 19 Aug 2009 00:20:05 +0000 (00:20 +0000)]
Localisation updates for core messages from translatewiki.net (2009-08-18 23:54 UTC)
Brion Vibber [Tue, 18 Aug 2009 23:55:37 +0000 (23:55 +0000)]
Disable the mysterious keypress throttling that overrides your operating system's keypress throttling for the up and down arrow keys in mwsuggest drop down.
The throttle didn't work prior to r55064, which was just fine since it makes your system behave more slowly for no apparent reason. :)
Michael Dale [Tue, 18 Aug 2009 23:49:36 +0000 (23:49 +0000)]
* added support for merging php -> js (already supported js -> php)
Aryeh Gregor [Tue, 18 Aug 2009 23:25:36 +0000 (23:25 +0000)]
$wgMaximumMovedPages should only count moved pages
(bug 20289) Previously, some pages that weren't actually moved were
counted against the limit by mistake. Whether it's sane for people to
move pages back and forth by hand to get around the limit is open to
debate, of course.
Siebrand Mazeland [Tue, 18 Aug 2009 23:23:59 +0000 (23:23 +0000)]
* update messages in the actual JavaScript files; also remove trailing whitespace
* update mwEmbed.i18n.php
Chad Horohoe [Tue, 18 Aug 2009 23:06:24 +0000 (23:06 +0000)]
Redo addArgs() as addArg() so we can actually do useful things with arguments like descriptions and proper requirement checks, similar to addOption()
Siebrand Mazeland [Tue, 18 Aug 2009 22:22:55 +0000 (22:22 +0000)]
Remove duplicate tab added in r55281
Siebrand Mazeland [Tue, 18 Aug 2009 22:13:31 +0000 (22:13 +0000)]
Stylize, reindent, pretty comment blocks, updated command line output
Brion Vibber [Tue, 18 Aug 2009 22:03:57 +0000 (22:03 +0000)]
Quick hack workaround for lack of optional argument lists in Maintenance class:
* don't list the start argument (good: means we default to 0; bad: means the --help doesn't list it)
* use "0" rather than 0 as the default so it doesn't fail the ctype_digit check
Siebrand Mazeland [Tue, 18 Aug 2009 21:56:04 +0000 (21:56 +0000)]
Update capitalisation, some rewording, spelling fixes
Michael Dale [Tue, 18 Aug 2009 21:44:37 +0000 (21:44 +0000)]
* removed <JAVASCRIPT EN REPLACE> in favor of normal $messages['en'] check
* updated maintenance script accordingly
Aryeh Gregor [Tue, 18 Aug 2009 21:22:59 +0000 (21:22 +0000)]
Remove all usage of projection stylesheets
(bug 18497) We don't actually intend for any of these stylesheets to be
used for projection, so providing projection is incorrect. Opera will
not use screen stylesheets in full-screen mode, but *only* if there's at
least one projection stylesheet present somewhere. If we remove *all*
projection stylesheets, then theoretically it should fall back to screen
stylesheets. I've confirmed that this works fine on my dev wiki with
Opera 9.6.
Michael Dale [Tue, 18 Aug 2009 21:12:53 +0000 (21:12 +0000)]
* fixes for multiple iframes target mismatch for single page
** lays groundwork for multiple in-page uploads
Brion Vibber [Tue, 18 Aug 2009 21:00:30 +0000 (21:00 +0000)]
Revert r55255 "Unblocking: Linking to contributions list instead of user page for IPs (other messages do so as well)"
This message seems to be used for the subtitle link on unblock success on Special:BlockList, and is used both for accounts and IPs. Needs to handle both these cases at least; double-check also handling of IP ranges?
Roan Kattouw [Tue, 18 Aug 2009 20:59:12 +0000 (20:59 +0000)]
Core changes for r55234: generalize some CSS for mwsuggest
Roan Kattouw [Tue, 18 Aug 2009 20:28:26 +0000 (20:28 +0000)]
Untested equivalent of r55262 ("When moving a page to a subpage of itself, don't move the root page twice") for Title::moveSubpages(). SpecialMovepage should be refactored to use Title::moveSubpages() some day.
Aryeh Gregor [Tue, 18 Aug 2009 20:14:41 +0000 (20:14 +0000)]
Throw an exception instead of PHP fatal error
I don't actually know how this is getting hit, but it was in my testing,
although not reproducibly.
Aryeh Gregor [Tue, 18 Aug 2009 20:14:23 +0000 (20:14 +0000)]
Fix comment to note return type on error
Aryeh Gregor [Tue, 18 Aug 2009 20:13:37 +0000 (20:13 +0000)]
Don't move twice when moving subpages to a subpage
(bug 14817) When a page got moved to a subpage of itself, and "move
subpages" was checked, the page got moved, then moved again, like Foo ->
Foo/Bar -> Foo/Bar/Bar. There was an explicit check to prevent this,
but the check was incorrect: it used $ot->getArticleID() after $ot had
already been moved, so the ID was the redirect. The behavior of
getArticleID() here isn't obvious, so I cached the ID in advance for
clarity instead of switching to $nt->getArticleID().
Brief inspection of Title::moveSubpages() suggests that that would be
affected too. The third place we have this code copy-pasted (bleh) is
SpecialRenameuser, but that's not affected because usernames can't have
slashes in them.
Rotem Liss [Tue, 18 Aug 2009 19:50:29 +0000 (19:50 +0000)]
Localization update.
Michael Dale [Tue, 18 Aug 2009 19:45:54 +0000 (19:45 +0000)]
* fixed SpecialUpload page iframe uploading for js2 (forgot to commit the SpecialUpload page that had the token id attr)
* fixed random error in mvFirefogg
* updated jquery skin path
Michael Dale [Tue, 18 Aug 2009 19:34:34 +0000 (19:34 +0000)]
* reorganized the jsAutoLoading class system to use mv_embed.js as the master json array of class paths. (this way we only define the js paths once and its easier to maintain)
* added stubs for html logic in skins
* renamed jquery.ui to non-version number
Tobias [Tue, 18 Aug 2009 18:28:27 +0000 (18:28 +0000)]
Unblocking: Linking to contributions list instead of user page for IPs (other messages do so as well)
Andrew Garrett [Tue, 18 Aug 2009 17:27:19 +0000 (17:27 +0000)]
Rewrite JS-based Live Preview to use jQuery, was 200 lines, now less than 35. TODO: LiquidThreads support, some sort of progress indicator.
Aryeh Gregor [Tue, 18 Aug 2009 10:43:22 +0000 (10:43 +0000)]
Fix fatal on every move over redirect, from r53659
Best not to call methods on variables until after you initialize them.
:)
Michael Dale [Tue, 18 Aug 2009 09:07:58 +0000 (09:07 +0000)]
* initial import "kaltura skin" (yaron.s)
* basic hook into js system for new k-class names
* menu items remain to be filled in.
Siebrand Mazeland [Tue, 18 Aug 2009 08:42:08 +0000 (08:42 +0000)]
* remove unused Skin::copyrightLink()
* remove now unused 'copyrightpagename' ('copyrightpage' is used elsewhere)
* rebuild core messages files