jenkins-bot [Wed, 3 Apr 2019 20:21:22 +0000 (20:21 +0000)]
Merge "Language: Use type hint instead of manual type check"
jenkins-bot [Wed, 3 Apr 2019 19:06:14 +0000 (19:06 +0000)]
Merge "LogFormatter: ignore unrecoverable data"
jenkins-bot [Wed, 3 Apr 2019 18:47:13 +0000 (18:47 +0000)]
Merge "Remove `.background-size()` mixin usage"
Aaron Schulz [Thu, 14 Mar 2019 07:56:40 +0000 (00:56 -0700)]
Set synchronous = NORMAL for cache tables in Sqlite installer
In local testing, this makes SqlBagOStuff::set 17x faster.
Change-Id: I54d0d4f009ca1289485b89a1dcab46ffb31d8f11
jenkins-bot [Wed, 3 Apr 2019 17:58:37 +0000 (17:58 +0000)]
Merge "ServiceWiring: Use RequestContext instead of $wgUser global"
jenkins-bot [Wed, 3 Apr 2019 17:58:27 +0000 (17:58 +0000)]
Merge "installer: make sqlite installer move the job queue to another DB"
jenkins-bot [Wed, 3 Apr 2019 17:43:40 +0000 (17:43 +0000)]
Merge "Add Job::getMetadata() and Job::setMetadata() accessors"
jenkins-bot [Wed, 3 Apr 2019 17:43:31 +0000 (17:43 +0000)]
Merge "jobqueue: remove entire unused JobQueueAggregator class hierarchy"
Fomafix [Wed, 3 Apr 2019 16:38:55 +0000 (18:38 +0200)]
Language: Use type hint instead of manual type check
Change-Id: I9c68d0838d5865c29bff85b9a6bf50e02e83f556
Aaron Schulz [Sat, 30 Mar 2019 15:05:31 +0000 (08:05 -0700)]
Add Job::getMetadata() and Job::setMetadata() accessors
Change-Id: I3a97008d324f600a1c9f6005673073277ee564fa
Jack Phoenix [Wed, 3 Apr 2019 14:25:49 +0000 (17:25 +0300)]
Fix comment typo in fresnel config file and remove an unnecessary comma
Change-Id: I43123d9c001ea59f38f904cd232cb5f8a11e15d8
Stephane Bisson [Mon, 1 Apr 2019 14:42:57 +0000 (10:42 -0400)]
LogFormatter: ignore unrecoverable data
It is possible for the log_params column of the logging
table to contain serialized data that cannot be deserialized
anymore because the types it references are missing.
It is currently the case with old Flow log entries on enwiki.
The extension is uninstalled and the UUID class is not found.
This patch proposes to simply skip the params and log a
warning in that case.
Bug: T212742
Change-Id: I3226b8fb338dd2b81e087af5d798d8f35368282d
jenkins-bot [Wed, 3 Apr 2019 08:27:18 +0000 (08:27 +0000)]
Merge "MigrateActors: Improve query for log_search rows"
Volker E [Wed, 3 Apr 2019 02:47:19 +0000 (19:47 -0700)]
Remove `.background-size()` mixin usage
Removing deprecated LESS `.background-size()` mixin calls.
Bug: T219956
Change-Id: I48a939eae125802778d0a8822961bef826970f46
jenkins-bot [Tue, 2 Apr 2019 23:12:57 +0000 (23:12 +0000)]
Merge "RecentChanges updated to use pseudo elements for presentation"
jenkins-bot [Tue, 2 Apr 2019 22:36:23 +0000 (22:36 +0000)]
Merge "Fully utilize LinkTarget passed to getRevisionByTitle"
jdlrobson [Wed, 27 Mar 2019 00:35:01 +0000 (17:35 -0700)]
RecentChanges updated to use pseudo elements for presentation
Bug: T219348
Change-Id: I6eeeaa3b58d37adb7fefb4cc6915022229b3b324
jenkins-bot [Tue, 2 Apr 2019 21:46:53 +0000 (21:46 +0000)]
Merge "jobqueue: change MWException throw statements to using JobQueueError"
Jason Linehan [Thu, 15 Nov 2018 16:02:32 +0000 (11:02 -0500)]
Fully utilize LinkTarget passed to getRevisionByTitle
Failure of getRevisionByTitle to pass its LinkTarget argument
to newRevisionFromRow resulted in a needless second instantiation
of the Title (an extra query).
Because newRevisionFromRow needs a Title, not just a LinkTarget,
it is unfortunately necessary to call Title::newFromLinkTarget
on it for now -- however this does not involve a DB lookup and
is on track to be fixed with revisions to the Title class.
Bug: T206498
Change-Id: Ic6f98d8fbf66d85121668571c17e148efc5ec2be
jenkins-bot [Tue, 2 Apr 2019 20:37:08 +0000 (20:37 +0000)]
Merge "Style change tags correctly on log extracts"
jenkins-bot [Tue, 2 Apr 2019 20:24:25 +0000 (20:24 +0000)]
Merge "Disable expensive {{REVISIONID}} magic word in miser mode"
Matěj Suchánek [Tue, 2 Apr 2019 20:06:34 +0000 (22:06 +0200)]
Style change tags correctly on log extracts
You can see them when you view a previously deleted page
and some of those events have been tagged.
Bug: T212613
Change-Id: I88e637a0ee688dd23c0ec90790e8189ecf1a8789
jenkins-bot [Tue, 2 Apr 2019 19:18:27 +0000 (19:18 +0000)]
Merge "Add test for Special:page::buildPrevNextNavigation"
jenkins-bot [Tue, 2 Apr 2019 18:21:29 +0000 (18:21 +0000)]
Merge "maintenance: Rewrite parts of the purgeChangedPages script"
jenkins-bot [Tue, 2 Apr 2019 17:35:09 +0000 (17:35 +0000)]
Merge "Sunsetting viewPrevNext"
jenkins-bot [Tue, 2 Apr 2019 17:29:06 +0000 (17:29 +0000)]
Merge "Fix typo in MigrateActors.php"
Brad Jorsch [Tue, 2 Apr 2019 14:07:56 +0000 (10:07 -0400)]
MigrateActors: Improve query for log_search rows
The query in question is, generically,
SELECT ls_value, ls_log_id, actor_id
FROM log_search LEFT JOIN actor ON (ls_value = actor_user)
WHERE ls_field = 'target_author_id'
ORDER BY ls_value, ls_log_id
LIMIT 100;
The intention is that it'll pull out 100 rows from log_search using its
primary key, and for each of those 100 rows find the actor_id for the
referenced user_id (using the actor_user index) if an actor ID exists.
The twist comes in the fact that ls_value is a string-type column while
actor_user is an integer-type. MySQL doesn't usually care, but other DBs
do so we have to cast one into the other.
Currently the code is casting actor_user to a string. But that means the
DB can't use the index on actor_user to find the one matching row,
instead it needs to scan the whole table.
The fix is simple enough: instead of casting actor_user to a string,
cast ls_value to an integer. That allows the actor_user index to be used
as expected.
Bug: T215525
Change-Id: I2f7a6ba9fd537336594088a0281a62ea5601cd59
jenkins-bot [Tue, 2 Apr 2019 14:15:23 +0000 (14:15 +0000)]
Merge "Set default for Block::appliesToPasswordReset to true"
Brad Jorsch [Tue, 2 Apr 2019 13:49:00 +0000 (09:49 -0400)]
Fix typo in MigrateActors.php
Change-Id: Ic08210a8cd394f6ad49673a2d2e4800e6bcf2989
Thalia [Tue, 2 Apr 2019 10:00:49 +0000 (11:00 +0100)]
Set default for Block::appliesToPasswordReset to true
Follow-up to Ia3f46aba. Before that patch, the default case for
whether a block blocks password reset was true.
Bug: T218905
Change-Id: I86cb381762890abddcf32f4f7199799391cc6dfb
daniel [Mon, 11 Mar 2019 13:33:18 +0000 (14:33 +0100)]
Add test for Special:page::buildPrevNextNavigation
Change-Id: Ie17221305ec979acebebb62798b83f5d91df1f60
jenkins-bot [Tue, 2 Apr 2019 08:05:26 +0000 (08:05 +0000)]
Merge "maintenance/dev: Clean up router.php"
Filippo Giunchedi [Thu, 21 Mar 2019 14:42:19 +0000 (15:42 +0100)]
monolog: add MwlogHandler
Introduce a new handler, similar to SyslogHandler, that will be used to
replace udp2log. The main feature of the handler is being able to vary
the 'application name' with each record's channel. This way the channel
can be reconstructed later, e.g. when writing to plaintext files.
See also an overview of the plan here:
https://phabricator.wikimedia.org/T205856#
4957430
Bug: T126989
Change-Id: I0c040825b31cd70f197dc8c1d406a103dc0ed1d1
Thiemo Kreuz [Wed, 27 Mar 2019 10:43:28 +0000 (11:43 +0100)]
maintenance: Rewrite parts of the purgeChangedPages script
My motivation to touch this code was a few count() I found confusing.
I ended rearranging it a lot to improve readability and clarity.
Change-Id: I9a0ea0812d4cc0c6e8ed6134e462dfdf325fd5d9
jenkins-bot [Tue, 2 Apr 2019 04:20:26 +0000 (04:20 +0000)]
Merge "rdbms: make $wgSQLMode work as documented when it is NULL"
jenkins-bot [Tue, 2 Apr 2019 03:06:56 +0000 (03:06 +0000)]
Merge "Fix unused vars/pointless assignments"
Timo Tijhof [Fri, 29 Mar 2019 23:36:39 +0000 (23:36 +0000)]
maintenance/dev: Clean up router.php
* Remove code paths that were unreachable for me.
* Remove display_errors/error_reporting overrides.
These can be set as-needed from LocalSettings.php if desired,
and similar (but slightly different) settings are already set
by DevelopmentSettings.php.
* Default to text/plain instead of letting PHP handle it.
This makes makes the result more predictable, instead of varying
by PHP version and underlying OS behaviour. Anything we want to
support is already in our 'mime.types' file, and ours is a
superset of PHP's anyway.
Change-Id: I46608ebd8e225642cfeb804ec32739c2fcbd4d25
jenkins-bot [Tue, 2 Apr 2019 01:34:43 +0000 (01:34 +0000)]
Merge "languages: Replace loop with array_pad()"
Bartosz Dziewoński [Mon, 1 Apr 2019 23:15:55 +0000 (01:15 +0200)]
PreferencesFormOOUI: Restore ID attributes for each fieldset
Follow-up to
255a58bedd29491c5550eebe4b8d0a5968f0d56c.
Change-Id: I00f00576ffc7f9d13218b21649822e0f826ecdf9
Aaron Schulz [Sat, 30 Mar 2019 02:02:15 +0000 (19:02 -0700)]
jobqueue: fix DBO_TRX logic in JobQueueDB for avoiding transactions
Various methods were missing the flag setting logic and tests could
fail or have "outer scope" warnings in the logs for sqlite.
Change-Id: Ia0607d189a307667297f06109a34363c92e37d92
jenkins-bot [Mon, 1 Apr 2019 22:19:01 +0000 (22:19 +0000)]
Merge "Update help icon from OOUI"
jenkins-bot [Mon, 1 Apr 2019 21:56:48 +0000 (21:56 +0000)]
Merge "Change job table params from blob to mediumblob"
Aaron Schulz [Mon, 1 Apr 2019 21:39:36 +0000 (14:39 -0700)]
rdbms: make $wgSQLMode work as documented when it is NULL
NULL means that the SET query should not be sent.
This was broken since
5bc9b990acd0e0302f.
Change-Id: I148b1153ef6ecca99c56e4f63247820a766ae779
Derick Alangi [Thu, 7 Mar 2019 18:19:58 +0000 (19:19 +0100)]
ServiceWiring: Use RequestContext instead of $wgUser global
Bug: T159299
Change-Id: I2a52e9b002a93a869355f89247153b09527dc118
jenkins-bot [Mon, 1 Apr 2019 21:07:00 +0000 (21:07 +0000)]
Merge "MediaResultWidget: Remove unused code depending on VisualEditor"
Volker E [Mon, 1 Apr 2019 19:53:17 +0000 (12:53 -0700)]
DateInputWidget: Fix focus reflow
Second attempt, follow-up to I1b5beee6553. This time with correct
specificity.
Change-Id: Ifeefe668c6d50b9452f6702dc632d67439a68135
Translation updater bot [Mon, 1 Apr 2019 20:18:41 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I167dae8a2111bbad1f1656d6edfa41555e854a9f
eranroz [Thu, 25 Oct 2018 18:07:00 +0000 (21:07 +0300)]
Sunsetting viewPrevNext
Removing viewPrevNext from Language and moving it to SpecialPage.
Used soley in special pages, and we aim to remove/reduce the dependency
of messages and language
Bug:T207977
Change-Id: I49b41a89ba59cfc24982b321f02c5cca9939decd
Ed Sanders [Sat, 30 Mar 2019 23:15:48 +0000 (23:15 +0000)]
Update help icon from OOUI
The normal 'help' icon no longer has a ring outline,
so use 'helpNotice' as this looks less confusing in
an unframed button.
Bug: T219719
Change-Id: I6af23236e9d3983cab6d2ce331dd67e3b42913ff
jenkins-bot [Mon, 1 Apr 2019 17:10:29 +0000 (17:10 +0000)]
Merge "Fix flaky test BlockListPagerTest::testFormatValue"
jenkins-bot [Mon, 1 Apr 2019 16:39:45 +0000 (16:39 +0000)]
Merge "i18n: Add line-break in email notificaton for minor edits"
Erik Bernhardson [Mon, 1 Apr 2019 16:05:08 +0000 (09:05 -0700)]
Change job table params from blob to mediumblob
The default blob type holds 65kB which is often enough, but some
jobs push over this limit. When using mysql these are silently
truncated to 65kB which only issues errors when the data is retrieved.
Increase from blob to mediumblob which gives a max size of 16MB. There
may be some valid use cases for jobs > 64kB, but there should be no
use case for jobs > 16MB.
Bug: T124196
Change-Id: I6df6634bd3a5b5fa27ce6f8ff20d251a9b5eba32
David Barratt [Mon, 1 Apr 2019 14:27:39 +0000 (10:27 -0400)]
Fix flaky test BlockListPagerTest::testFormatValue
The test relied on being executed within the same minute as when it starts
which is not always the case.
Bug: T219695
Change-Id: I99eb0d25138069ca08c2975ff2e60c7f1df0a99f
Bartosz Dziewoński [Mon, 1 Apr 2019 15:55:17 +0000 (17:55 +0200)]
MediaResultWidget: Remove unused code depending on VisualEditor
It seems that this property is not actually used. The default thumb size
is also loaded in MediaResourceProvider by querying the meta=siteinfo API.
Bug: T219675
Change-Id: I42610a2ac1ba6b19f08ee9fc9a8fd4aa23e090a7
Thiemo Kreuz [Wed, 27 Mar 2019 17:37:39 +0000 (18:37 +0100)]
linkeddata: Simplity PageDataRequestHandler test setup
Most notably this gets rid of all regular expressions and replaces them
with straight string comparisons. This is mostly done for readability,
but also makes the test more independend from the setup of the server
that is running the test.
Change-Id: I8c34cf1756c8e6c126b95b3eda163561d53186b9
Thiemo Kreuz [Wed, 27 Mar 2019 15:22:39 +0000 (16:22 +0100)]
linkeddata: Fix broken check in PageDataRequestHandler
First I noticed a weird check that assumes that explode() would return
an integer. But it returns an array of strings. There is obviously a
count() missing.
Then I started simplifying the code:
* The count can only be 2 or 1, never anything else.
* If it is one, the first element in the array contains the original string.
* The empty string is already checked above and can never end down there.
* Finally I made the remaining `if ( … ) return true else return false` a
straight `return …`.
Change-Id: I289144e64f449ee0875009aaa22e10a5c0eb2734
jenkins-bot [Mon, 1 Apr 2019 07:39:30 +0000 (07:39 +0000)]
Merge "Don't return a result of a void function"
GeoffreyT2000 [Sun, 31 Mar 2019 04:17:43 +0000 (21:17 -0700)]
Remove redundant parentheses from the "Historyempty" message
With pseudo-elements now being used, the parentheses in the "Historyempty"
message become redundant, and should be removed to avoid showing "((empty))"
on empty revisions in page histories.
Bug: T219714
Change-Id: I8aacd6ede4ab0cc03b00fb891088ef0c847a6b20
jenkins-bot [Sun, 31 Mar 2019 23:14:28 +0000 (23:14 +0000)]
Merge "MediaResultWidget: Fix defaultThumbSzie config"
Ed Sanders [Sun, 31 Mar 2019 21:17:01 +0000 (22:17 +0100)]
MediaResultWidget: Fix defaultThumbSzie config
Bug: T219675
Change-Id: I38bc34f6d44460ec59881b5e968dc8cf27d75fa3
Translation updater bot [Sun, 31 Mar 2019 19:55:51 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I99e4d02a0dce78e9ac24a3a6040183bec5a56d60
jenkins-bot [Sun, 31 Mar 2019 16:36:23 +0000 (16:36 +0000)]
Merge "maintenance: Deprecate Maintenance::hasArg/getArg with no param"
Umherirrender [Sat, 30 Mar 2019 11:16:51 +0000 (12:16 +0100)]
Move MediaTransformOutput classes to own files
Change-Id: I1c676f18101250ffc28ea412213d568c5a4f527d
jenkins-bot [Sat, 30 Mar 2019 11:21:46 +0000 (11:21 +0000)]
Merge "Move class SearchEngineDummy to own file"
jenkins-bot [Sat, 30 Mar 2019 10:05:01 +0000 (10:05 +0000)]
Merge "resourceloader: Remove deprecated MessageBlobStore::getBlob"
Aaron Schulz [Sat, 30 Mar 2019 04:11:35 +0000 (21:11 -0700)]
jobqueue: change MWException throw statements to using JobQueueError
Also fix some minor phpstorm warnings in JobQueue
Change-Id: Ie4970f3e93b504fae509ec755b0e0afad71a7749
jenkins-bot [Sat, 30 Mar 2019 04:26:02 +0000 (04:26 +0000)]
Merge "Do not return invalid JSON in runJobs.php"
Aaron Schulz [Sat, 30 Mar 2019 03:44:56 +0000 (20:44 -0700)]
Do not return invalid JSON in runJobs.php
Change-Id: Ib94c23bfc5e599a628a5fd65bb14baf750874995
Aaron Schulz [Sat, 30 Mar 2019 03:25:05 +0000 (20:25 -0700)]
jobqueue: remove entire unused JobQueueAggregator class hierarchy
Change-Id: I3d56d5db54fcb4278c7cf2a8d08933c27773c3f7
Timo Tijhof [Sat, 30 Mar 2019 02:57:57 +0000 (02:57 +0000)]
resourceloader: Remove deprecated MessageBlobStore::getBlob
This class is basically `@internal`, but not yet marked as such.
The only non-core use case is a WikimediaMaintenance script,
so I suppose we can keep it public.
It's purpose is for batching, the single blob method is not
used anywhere in Wikimedia Git.
Change-Id: If2a0497b1412efbfd55b34b512d2b9e5346359fb
jenkins-bot [Sat, 30 Mar 2019 02:48:06 +0000 (02:48 +0000)]
Merge "auth: Make 'LocalUserCreated' hook non-abortable"
jenkins-bot [Sat, 30 Mar 2019 01:35:34 +0000 (01:35 +0000)]
Merge "mediawiki.user: Use then() instead of done()"
jenkins-bot [Sat, 30 Mar 2019 01:24:03 +0000 (01:24 +0000)]
Merge "mediawiki.user: Improve test suite"
jenkins-bot [Sat, 30 Mar 2019 00:43:45 +0000 (00:43 +0000)]
Merge "Avoid use of deprecated wikiId field in JobQueue"
jenkins-bot [Sat, 30 Mar 2019 00:43:36 +0000 (00:43 +0000)]
Merge "Avoid use of deprecated "wikiId" parameter for FileBackend"
jenkins-bot [Sat, 30 Mar 2019 00:22:25 +0000 (00:22 +0000)]
Merge "Fix function/class case"
jenkins-bot [Sat, 30 Mar 2019 00:08:28 +0000 (00:08 +0000)]
Merge "Replace several uses of wfWikiId() with WikiMap methods"
Krinkle [Sat, 30 Mar 2019 00:07:01 +0000 (00:07 +0000)]
Merge "Make RefreshLinksJob run DataUpdates such that they have outer scope"
jenkins-bot [Fri, 29 Mar 2019 23:55:28 +0000 (23:55 +0000)]
Merge "Clean up some database domain ID related code and fix some comments"
Max Semenik [Fri, 29 Mar 2019 23:52:48 +0000 (16:52 -0700)]
Fix unused vars/pointless assignments
Change-Id: If475c738b4af7208024c866594d4c0048af053dd
Aaron Schulz [Fri, 29 Mar 2019 01:59:42 +0000 (18:59 -0700)]
Make RefreshLinksJob run DataUpdates such that they have outer scope
This is how DeferrableUpdates are supposed to run as documented.
Change-Id: Ie4fb8c9a64b94bc2422d7e51391998315f4eeddb
Max Semenik [Fri, 29 Mar 2019 23:27:09 +0000 (16:27 -0700)]
Don't return a result of a void function
Change-Id: Ie22b0a44a489bb2f1115608c8dd782656b45537e
jenkins-bot [Fri, 29 Mar 2019 23:21:26 +0000 (23:21 +0000)]
Merge "Fix partially blocked admin undelete permissions"
Max Semenik [Fri, 29 Mar 2019 23:20:50 +0000 (16:20 -0700)]
Fix function/class case
Change-Id: I18c205736be9d76d2c09a6dc4d7377740a742ccc
jenkins-bot [Fri, 29 Mar 2019 22:54:58 +0000 (22:54 +0000)]
Merge "Make Job::hasExecutionFlag() actually work"
Aaron Schulz [Sat, 9 Mar 2019 01:21:18 +0000 (17:21 -0800)]
installer: make sqlite installer move the job queue to another DB
Also update some of the other separate DBs/files to use IMMEDIATE
Bug: T93097
Change-Id: Ib250b74cb7ff743f155512d7410cb229441cc70a
Aaron Schulz [Fri, 29 Mar 2019 22:26:25 +0000 (15:26 -0700)]
Avoid use of deprecated wikiId field in JobQueue
Change-Id: I9e30519e7985c20525572b685234ad239d62c214
Aaron Schulz [Fri, 29 Mar 2019 22:10:02 +0000 (15:10 -0700)]
Avoid use of deprecated "wikiId" parameter for FileBackend
Also cleaned up the parameter/field naming for DBFileJournal
Change-Id: I70f2a870706f0813311a694cb8ea31ced58dcabb
jenkins-bot [Fri, 29 Mar 2019 22:19:51 +0000 (22:19 +0000)]
Merge "Rename NameTableStore wiki ID field to a DB domain field"
jenkins-bot [Fri, 29 Mar 2019 22:19:42 +0000 (22:19 +0000)]
Merge "Use the WebRequest::getCheck() shortcut where possible"
jenkins-bot [Fri, 29 Mar 2019 22:19:33 +0000 (22:19 +0000)]
Merge "Fix flakey MCR test in RevisionDbTestBase by mocking the time"
Aaron Schulz [Fri, 29 Mar 2019 21:56:18 +0000 (14:56 -0700)]
Replace several uses of wfWikiId() with WikiMap methods
Also, reword some related comments.
Change-Id: I8aefa42f96b90e9ea871cf7ec1afcc7ed82a19b2
Aaron Schulz [Fri, 29 Mar 2019 21:30:21 +0000 (14:30 -0700)]
Clean up some database domain ID related code and fix some comments
Change-Id: Id5c5640e05301161dbb7c2be363e32d7d1c9a511
jenkins-bot [Fri, 29 Mar 2019 21:23:07 +0000 (21:23 +0000)]
Merge "jobqueue: simplify the signature of Job::factory() and Job::__construct()"
Aaron Schulz [Fri, 29 Mar 2019 21:14:05 +0000 (14:14 -0700)]
Fix flakey MCR test in RevisionDbTestBase by mocking the time
Change-Id: I1d089d7b155adb865b42f7e8a26466553508c9be
Dayllan Maza [Fri, 29 Mar 2019 17:13:22 +0000 (13:13 -0400)]
Fix partially blocked admin undelete permissions
If an admin is partially blocked they should be able to restore/undelete
any given page.
Bug: T219305
Change-Id: I404730273c33d72d7552cd69e93ccec78c5fad5a
jenkins-bot [Fri, 29 Mar 2019 20:18:20 +0000 (20:18 +0000)]
Merge "Convert EnqueueJob to using DB domains"
jenkins-bot [Fri, 29 Mar 2019 20:18:07 +0000 (20:18 +0000)]
Merge "Make WikiMap::isCurrentWikiDbDomain() more rigorous"
jenkins-bot [Fri, 29 Mar 2019 20:17:57 +0000 (20:17 +0000)]
Merge "Fix invalid namespace restriction when js is disabled"
Aaron Schulz [Fri, 29 Mar 2019 20:15:58 +0000 (13:15 -0700)]
jobqueue: simplify the signature of Job::factory() and Job::__construct()
Remove the $title argument from these methods to simplify subclasses that
do not have a meaningful title to use. The Job::getTitle() method can be
overriden by subclasses to return something meaningful.
The old call signature is still supported for backwards compatibility.
This will automatically determine what getTitle() returns as before.
Use "Blankpage" as the "not applicable" title for jobs instead of one
that looks like some error occured.
Change-Id: I3d5bd012d9cef1e7daaccfb0d5d319552eb89fb6