From: C. Scott Ananian <cscott@cscott.net>
Date: Wed, 12 Oct 2016 23:56:51 +0000 (-0700)
Subject: Balancer: remove unnecessary extra argument
X-Git-Tag: 1.31.0-rc.0~5128^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/pie.php?a=commitdiff_plain;h=4ae30c95164b5e47174cbc1ee73393987fc06a08;p=lhc%2Fweb%2Fwiklou.git

Balancer: remove unnecessary extra argument

The full HTML5 spec clones element attributes when they are added to
the ActiveFormattingElements list, so that when an element on that
list is later cloned and reinserted the attributes are the *original*
attributes, not reflecting any changes which embedded JavaScript
in an inline <script> block may have made to them since the element
was pushed.

However, the PHP implementation doesn't run any JavaScript so there's
no way the attributes could change during balancing and there is
thus no reason to keep extra copies of the attributes around.

Change-Id: I89647aeb90c64701d77e862ea9e3d22b19bbdedc
---

diff --git a/includes/tidy/Balancer.php b/includes/tidy/Balancer.php
index aef73c7258..1346e1cdd0 100644
--- a/includes/tidy/Balancer.php
+++ b/includes/tidy/Balancer.php
@@ -2603,8 +2603,7 @@ class Balancer {
 			case 'tt':
 			case 'u':
 				$this->afe->reconstruct( $this->stack );
-				// FIXME: only takes one parameter
-				$this->afe->push( $this->stack->insertHTMLElement( $value, $attribs ), $attribs );
+				$this->afe->push( $this->stack->insertHTMLElement( $value, $attribs ) );
 				return true;
 
 			case 'nobr':
@@ -2613,8 +2612,7 @@ class Balancer {
 					$this->inBodyMode( 'endtag', 'nobr' );
 					$this->afe->reconstruct( $this->stack );
 				}
-				// FIXME: only takes one parameter
-				$this->afe->push( $this->stack->insertHTMLElement( $value, $attribs ), $attribs );
+				$this->afe->push( $this->stack->insertHTMLElement( $value, $attribs ) );
 				return true;
 
 			case 'applet':