[specials] Xml::namespaceSelector > Html::namespaceSelector

* Makes front-end more reliable by not relying on Xml::namespaceSelector to use name="namespace" in it's output, which these forms where then requesting hardcoded from WebRequest
* Poke r109990

diff --git a/includes/specials/SpecialAllpages.php b/includes/specials/SpecialAllpages.php
index 660e3be..960a327 100644 (file)
--- a/includes/specials/SpecialAllpages.php
+++ b/includes/specials/SpecialAllpages.php
@@ -127,7 +127,10 @@ class SpecialAllpages extends IncludableSpecialPage {
                        Xml::label( $this->msg( 'namespace' )->text(), 'namespace' ) .
                        "       </td>
                        <td class='mw-input'>" .
-                       Xml::namespaceSelector( $namespace, null ) . ' ' .
+                       Html::namespaceSelector(
+                               array( 'selected' => $namespace ),
+                               array( 'name' => 'namespace', 'id' => 'namespace' )
+                       ) . ' ' .
                        Xml::submitButton( $this->msg( 'allpagessubmit' )->text() ) .
                        "       </td>
 </tr>";

diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php
index 067a956..06a8a0c 100644 (file)
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -655,7 +655,10 @@ class SpecialRecentChanges extends IncludableSpecialPage {
         * @return String
         */
        protected function namespaceFilterForm( FormOptions $opts ) {
-               $nsSelect = Xml::namespaceSelector( $opts['namespace'], '' );
+               $nsSelect = Html::namespaceSelector(
+                       array( 'selected' => $opts['namespace'], 'all' => '' ),
+                       array( 'name' => 'namespace', 'id' => 'namespace' )
+               );
                $nsLabel = Xml::label( wfMsg( 'namespace' ), 'namespace' );
                $invert = Xml::checkLabel(
                        wfMsg( 'invert' ), 'invert', 'nsinvert',