Priyanka Dhanda [Wed, 15 Dec 2010 23:00:11 +0000 (23:00 +0000)]
Make these tests run again. I think this is the right fix. At least they run now.
Sam Reed [Wed, 15 Dec 2010 22:41:06 +0000 (22:41 +0000)]
Change old php4 style constructor
Happy-melon [Wed, 15 Dec 2010 21:37:50 +0000 (21:37 +0000)]
Follow-up r78445: don't spam a useless edit token into the URL for GET requests.
Happy-melon [Wed, 15 Dec 2010 21:14:36 +0000 (21:14 +0000)]
Clean up the running mess that is r64866, r65040, and then r67277. Implement and document consistent behaviour for all types of fields: if the 'name' parameter is specified, use it exactly as is, otherwise use "wp{$fieldname}". For hidden fields added with addHiddenField(), continue to use either $attrib['name'] or $name, both unaltered.
Raimond Spekking [Wed, 15 Dec 2010 21:12:17 +0000 (21:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-15 20:54:00 UTC)
Aaron Schulz [Wed, 15 Dec 2010 20:59:29 +0000 (20:59 +0000)]
Changed doQuery() -> query()
Happy-melon [Wed, 15 Dec 2010 20:10:16 +0000 (20:10 +0000)]
Follow-up r78445: validation errors would never be shown on a GET form
Chad Horohoe [Wed, 15 Dec 2010 19:55:08 +0000 (19:55 +0000)]
When using safe_mode, mail() cannot take the 5th parameter. Rather than (needlessly) disabling e-mail confirmation as a result, just disregard the parameter. Pointed out by Kunda on IRC.
Shinjiman [Wed, 15 Dec 2010 19:41:51 +0000 (19:41 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Happy-melon [Wed, 15 Dec 2010 19:33:03 +0000 (19:33 +0000)]
Allow HTMLForms to be submitted by GET requests.
Chad Horohoe [Wed, 15 Dec 2010 16:26:26 +0000 (16:26 +0000)]
Followup r78383: deny tests from web
Happy-melon [Wed, 15 Dec 2010 13:33:47 +0000 (13:33 +0000)]
Better regexes for r78246.
Raimond Spekking [Wed, 15 Dec 2010 13:07:21 +0000 (13:07 +0000)]
Follow-up r78426: Tweak messages for consistency. Remove sentence about "API documenation" because I think it is not helpful for normal users.
Add new messages to maintenance file
Sam Reed [Wed, 15 Dec 2010 11:30:54 +0000 (11:30 +0000)]
Remove public from interface defintion, as decleration in an interface is not valid
Neil Kandalgaonkar [Wed, 15 Dec 2010 01:21:11 +0000 (01:21 +0000)]
added a page to list all stashed files, and clear them if necessary -- helpful while debugging some concurrency issues, also gets us closer to keeping the UploadWizard state on the server
Neil Kandalgaonkar [Wed, 15 Dec 2010 01:17:28 +0000 (01:17 +0000)]
refactored HTMLForm show() into three methods, in case you want to process a form in some way separate from showing it.
Happy-melon [Wed, 15 Dec 2010 01:03:44 +0000 (01:03 +0000)]
Follow-up r77796: a couple of typos in the comment, and break more consistently at 90 cols.
Sam Reed [Tue, 14 Dec 2010 23:43:03 +0000 (23:43 +0000)]
Access modifiers aren't valid on interfaces
Happy-melon [Tue, 14 Dec 2010 22:45:25 +0000 (22:45 +0000)]
In the vein of r75313, get groups from the $wg(Add|Remove)Groups and $wgGroups(AddTo|RemoveFrom)Self variables as well.
Platonides [Tue, 14 Dec 2010 21:57:13 +0000 (21:57 +0000)]
Remove the word global from the messages itselves, per r78230 CR.
Sam Reed [Tue, 14 Dec 2010 21:40:14 +0000 (21:40 +0000)]
* (bug 26339) Throw warning when truncating an overlarge API result
Raimond Spekking [Tue, 14 Dec 2010 21:19:18 +0000 (21:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-14 20:54:00 UTC)
Alexandre Emsenhuber [Tue, 14 Dec 2010 19:40:27 +0000 (19:40 +0000)]
Checking permissions for $wgUser while doing an edit with another user is not a good idea
Sam Reed [Tue, 14 Dec 2010 18:17:42 +0000 (18:17 +0000)]
Fixup fixme on r76844
Only "known issue", is the bottom limit thing posts, and won't override the top one, if it's set one in the URL, which is a PITA. 2 clicks does it. Hopefully this can be fixed, and uncommented when VVV sorts out our queryparameters? :)
Platonides [Tue, 14 Dec 2010 17:49:01 +0000 (17:49 +0000)]
Do not access to mTouched internals of Article from a different module per r70783#c12039
Krinkle [Tue, 14 Dec 2010 17:21:40 +0000 (17:21 +0000)]
* Removing wfSupportsAjax() call. We don't use legacy sajax_ anymore, jQuery takes care of this
* Thus also removing the dependency on mediawiki.legacy.ajax in mediawiki.action.watch.ajax
* Moving the show() call further down in jsMessage. Before this commit the box shows for a split second (empty) and then it suddenly grows with content. Now moved it down so that it comes into view, filled already. Also made it possible to bring back the slideDown effect without ugly flashes.
Roan Kattouw [Tue, 14 Dec 2010 16:56:56 +0000 (16:56 +0000)]
Use $.getJSON()'s middle parameter rather than DIY URL building in AJAX watch JS
Chad Horohoe [Tue, 14 Dec 2010 16:48:44 +0000 (16:48 +0000)]
Fix a few more paths, restore a few files lost in the move
Chad Horohoe [Tue, 14 Dec 2010 16:33:06 +0000 (16:33 +0000)]
Fix path changes from move in r78383
Chad Horohoe [Tue, 14 Dec 2010 16:31:25 +0000 (16:31 +0000)]
Missed another comment in r78381
Chad Horohoe [Tue, 14 Dec 2010 16:28:52 +0000 (16:28 +0000)]
svn ci'd from the wrong directory, missed the deletes in r78383
Chad Horohoe [Tue, 14 Dec 2010 16:26:35 +0000 (16:26 +0000)]
Per wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this.
Chad Horohoe [Tue, 14 Dec 2010 15:49:41 +0000 (15:49 +0000)]
Remove big commented list of URLs (added in r61078) that this class will never be testing. Core tests shouldn't depend on extensions and they were confusing my grepping too.
Sam Reed [Tue, 14 Dec 2010 15:44:16 +0000 (15:44 +0000)]
Fix up few remaining fixme things from r69910
Roan Kattouw [Tue, 14 Dec 2010 15:33:14 +0000 (15:33 +0000)]
Followup r77354: it's page_touched, with an underscore
Chad Horohoe [Tue, 14 Dec 2010 13:37:53 +0000 (13:37 +0000)]
Cleanup for r63578: Use Maintenance::error(), that's what its for
Chad Horohoe [Tue, 14 Dec 2010 13:20:10 +0000 (13:20 +0000)]
Revert r74978 per CR, no followup for nearly 2 months
Chad Horohoe [Tue, 14 Dec 2010 12:59:17 +0000 (12:59 +0000)]
Per r76225 CR: Get rid of Autoloader::loadAllExtensions() "Anything that needs it is badly written and needs to use the AutoLoader properly."
Chad Horohoe [Tue, 14 Dec 2010 12:51:59 +0000 (12:51 +0000)]
Style fix for r76220
Chad Horohoe [Tue, 14 Dec 2010 12:47:37 +0000 (12:47 +0000)]
rm double comment
Chad Horohoe [Tue, 14 Dec 2010 12:47:07 +0000 (12:47 +0000)]
Fix for r78322, check $result not $value
Alexandre Emsenhuber [Tue, 14 Dec 2010 12:25:34 +0000 (12:25 +0000)]
Changed $wgArticle to local variable, not needed
Alexandre Emsenhuber [Tue, 14 Dec 2010 12:15:55 +0000 (12:15 +0000)]
Article::insertNewArticle() -> Article::doEdit()
Roan Kattouw [Tue, 14 Dec 2010 11:47:13 +0000 (11:47 +0000)]
Improve some of the descriptions added in r68482
Tim Starling [Tue, 14 Dec 2010 11:11:38 +0000 (11:11 +0000)]
Cleaned up r70342 and r70343: removed commented-out code.
Roan Kattouw [Tue, 14 Dec 2010 11:09:30 +0000 (11:09 +0000)]
Followup r78104: set the cookie unconditionally, so its expiry is renewed every time sessionId() is called
Tim Starling [Tue, 14 Dec 2010 10:57:41 +0000 (10:57 +0000)]
Update references for wfEscapeShellArg() for r69732 etc. The very useful mailing list post that I cited has disappeared from the web!
Tim Starling [Tue, 14 Dec 2010 09:01:48 +0000 (09:01 +0000)]
Fixed comments and indenting style from r68491.
Rotem Liss [Tue, 14 Dec 2010 08:44:09 +0000 (08:44 +0000)]
Localization update for he.
Tim Starling [Tue, 14 Dec 2010 08:14:55 +0000 (08:14 +0000)]
Fixed typos in file names from r65967
Krinkle [Tue, 14 Dec 2010 00:08:54 +0000 (00:08 +0000)]
merging the two addModules() calls into one, (they take an array, so might as well me together); + using mw instead of mediaWiki in mediawiki.util.js
Trevor Parscal [Tue, 14 Dec 2010 00:08:07 +0000 (00:08 +0000)]
Added comment about why you should not be depending on mediaWiki.user.sessionId before mediaWiki.loader.go is called.
Trevor Parscal [Tue, 14 Dec 2010 00:02:21 +0000 (00:02 +0000)]
Fixes r78104 much better than r78344 did. By adding jquery.cookie to the loading queue just after declaring mediaWiki we can ensure it's in the first batch of modules that are fetched - essentially adding it to the initial payload.
Krinkle [Mon, 13 Dec 2010 23:52:45 +0000 (23:52 +0000)]
added compareObject function to mediaWiki core jQuery prototyping utilities
Trevor Parscal [Mon, 13 Dec 2010 23:51:29 +0000 (23:51 +0000)]
Fixed issue in r78104 where jquery.cookie wouldn't load properly. Changed the mediaWiki User object to load jquery.cookie on demand.
Alexandre Emsenhuber [Mon, 13 Dec 2010 22:33:08 +0000 (22:33 +0000)]
Checking namespace restriction with $wgUser while calling Title::getUserPermissionsErrors() with anoter User object is really not a good idea
Raimond Spekking [Mon, 13 Dec 2010 20:58:38 +0000 (20:58 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-13 20:33:00 UTC)
Derk-Jan Hartman [Mon, 13 Dec 2010 20:34:35 +0000 (20:34 +0000)]
Followup to r77836. Update parserTests
Krinkle [Mon, 13 Dec 2010 20:13:39 +0000 (20:13 +0000)]
Make the Map-class publicly available
Bryan Tong Minh [Mon, 13 Dec 2010 20:04:06 +0000 (20:04 +0000)]
Follow-up r66364: wincache fixes
* Return the result of wincache_ucache_get() in get()
* In command line mode $info['ucache_entries'] returned from wincache_ucache_info() is null, so don't iterate over a non-array
Bryan Tong Minh [Mon, 13 Dec 2010 20:00:43 +0000 (20:00 +0000)]
Follow-up r78297: allow the hook to break the execution; added &$term: could be useful for modifying the edit link
Alexandre Emsenhuber [Mon, 13 Dec 2010 19:47:34 +0000 (19:47 +0000)]
Removed trailing whitespaces
Roan Kattouw [Mon, 13 Dec 2010 16:39:48 +0000 (16:39 +0000)]
Followup r64047: pass static callbacks in array form, not string form
Platonides [Mon, 13 Dec 2010 15:49:05 +0000 (15:49 +0000)]
Do not assume that the current working dir is phase3/config
Chad Horohoe [Mon, 13 Dec 2010 15:30:41 +0000 (15:30 +0000)]
Fix for r75858: Move $IP detection further up so it can be used in child constructors
Alexandre Emsenhuber [Mon, 13 Dec 2010 15:16:05 +0000 (15:16 +0000)]
Fix comment: Article::insertNewArticle() -> Article::doEdit() and Article::insertOn()
Alexandre Emsenhuber [Mon, 13 Dec 2010 15:13:06 +0000 (15:13 +0000)]
Changed global variables ($wgTitle and $wgArticle) to local ones
Roan Kattouw [Mon, 13 Dec 2010 13:13:29 +0000 (13:13 +0000)]
Followup r76220: locateExecutableInDefaultPaths() was made static, so use static calls
Roan Kattouw [Mon, 13 Dec 2010 12:44:34 +0000 (12:44 +0000)]
Fix variable name in doc comment added in r78192
Roan Kattouw [Mon, 13 Dec 2010 12:40:08 +0000 (12:40 +0000)]
Fix r78196: readd accidentally removed lines in shared.css
Sam Reed [Mon, 13 Dec 2010 12:38:44 +0000 (12:38 +0000)]
Followup r78295, seems I didn't even bother to rename it last time
Sam Reed [Mon, 13 Dec 2010 11:06:57 +0000 (11:06 +0000)]
Followup r78268, do it as Bryan suggested, not as how I'd interpretted it for some daft reason
Benjamin Lees [Sun, 12 Dec 2010 23:19:24 +0000 (23:19 +0000)]
Follow-up to r77956: instead of making $wgFileExtensions override $wgFileBlacklist, make sure the upload page does not mark blacklisted extensions as "Permitted file types". I've updated the MediaWiki.org pages to explain how to remove items from the blacklist.
Krinkle [Sun, 12 Dec 2010 22:30:02 +0000 (22:30 +0000)]
(mw.util.test) Escape the 'does return, the same way as the 'should return' (mw.html.escape() and spaces to non-breaking)
Alexandre Emsenhuber [Sun, 12 Dec 2010 20:45:32 +0000 (20:45 +0000)]
Fix fatal error from r78264
Raimond Spekking [Sun, 12 Dec 2010 20:34:19 +0000 (20:34 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-12 20:19:00 UTC)
Sam Reed [Sun, 12 Dec 2010 18:57:10 +0000 (18:57 +0000)]
Followup r65114 (per CR cabal), remove SpecialSearchGomatch, replace with SpecialSearchGo in SearchEngine::getNearMatch
Alexandre Emsenhuber [Sun, 12 Dec 2010 18:54:33 +0000 (18:54 +0000)]
Moved the check for the "printable" parameter to performRequestForTitle() instead of checkInitialQueries(), I don't know why we need to do this check that early
Alexandre Emsenhuber [Sun, 12 Dec 2010 18:47:04 +0000 (18:47 +0000)]
It's easier to use addWikiMsgArray()
Sam Reed [Sun, 12 Dec 2010 18:35:19 +0000 (18:35 +0000)]
Followup r75763, fixup wrong change of deprecated method
No need to do separate htmlspecialchars et al, Xml::expandAttributes
Sam Reed [Sun, 12 Dec 2010 18:17:33 +0000 (18:17 +0000)]
Fix typo in hooks.txt
Chad Horohoe [Sun, 12 Dec 2010 17:50:35 +0000 (17:50 +0000)]
&& not and, || not or
Chad Horohoe [Sun, 12 Dec 2010 17:25:56 +0000 (17:25 +0000)]
Remove bogus session_path checks. Reverts r67465, r63813, r75256, r64717.
Roan Kattouw [Sun, 12 Dec 2010 16:18:08 +0000 (16:18 +0000)]
Redo r78254 without the syntax error
Platonides [Sun, 12 Dec 2010 16:15:35 +0000 (16:15 +0000)]
This is not an array, but a parameter. Revert r78254. Is the precommit hook not working?
PHP Parse error: syntax error, unexpected T_DOUBLE_ARROW in includes/Title.php on line 3752
Roan Kattouw [Sun, 12 Dec 2010 15:55:03 +0000 (15:55 +0000)]
Folllowup r72866: use array syntax for rev_page = foo condition
Bryan Tong Minh [Sun, 12 Dec 2010 15:50:25 +0000 (15:50 +0000)]
Follow-up r65652: Do not double-slash the path if it came from PATH_INFO
Happy-melon [Sun, 12 Dec 2010 15:40:41 +0000 (15:40 +0000)]
Follow-up r64903: rm leftover debugging code.
Happy-melon [Sun, 12 Dec 2010 15:38:54 +0000 (15:38 +0000)]
Follow-up r78246: clean several integer preferences before saving. It's not dangerous to not do this, here or elsewhere, because it is done implicitly whenever the value is treated as a number; but it keeps the database tidier.
Happy-melon [Sun, 12 Dec 2010 15:32:29 +0000 (15:32 +0000)]
Follow-up to r64866: follow the HTML5 spec when validating floats and ints, and support 'required' attribute universally (apart from type=hidden).
Chad Horohoe [Sun, 12 Dec 2010 15:29:47 +0000 (15:29 +0000)]
Per CR on r71359: Fix DB_MASTER where it should be __METHOD__
Aryeh Gregor [Sun, 12 Dec 2010 00:30:06 +0000 (00:30 +0000)]
Make ul.gallery block, not inline-block
As suggested by fomafix at
<https://bugzilla.wikimedia.org/show_bug.cgi?id=3276#c33>. This makes
it play nicer with floats, at least in Firefox 4, and doesn't seem to
otherwise break stuff (but I haven't tested in many browsers).
Platonides [Sat, 11 Dec 2010 22:54:41 +0000 (22:54 +0000)]
Remove that ugly unset( $vars['_lsExists'] );
Shouldn't the second file_exists() also need a wfSuppressWarnings?
Follow up to r78118.
Platonides [Sat, 11 Dec 2010 22:44:42 +0000 (22:44 +0000)]
Follow up r77981,r77982. Rename the new globalcsspreview/globaljspreview to sitecsspreview/sitejspreview per CodeReview.
Raimond Spekking [Sat, 11 Dec 2010 22:05:32 +0000 (22:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-11 22:46:00 UTC)
Alexandre Emsenhuber [Sat, 11 Dec 2010 20:26:14 +0000 (20:26 +0000)]
Fix whitespaces
Alexandre Emsenhuber [Sat, 11 Dec 2010 20:07:49 +0000 (20:07 +0000)]
* Per Ilmari Karonen, fix for r78224: make it work correctly with API
* Renamed $mName to $mUsername since it was conflicting with a member variable of SpecialPage
Alexandre Emsenhuber [Sat, 11 Dec 2010 17:44:57 +0000 (17:44 +0000)]
* Converted Special:Userlogin to subclass SpecialPage
* Removed useless calls to $wgOut->setArticleRelated() and $wgOut->setRobotPolicy(), they are already handled by SpecialPage::setHeaders()
Aaron Schulz [Sat, 11 Dec 2010 05:32:48 +0000 (05:32 +0000)]
* Removed redundant revdelete msg above content
* Show bottom patrol link even if hook replaces preview content
* Hook doc tweaks
* Assorted minor cleanups
Mark A. Hershberger [Sat, 11 Dec 2010 03:53:22 +0000 (03:53 +0000)]
* Add FIXME about the bug I found during testing
* Make the only instance of the ParserOptions::getMaxIncludeSize() that doesn't match its method signature match.