From: umherirrender <umherirrender_de.wp@web.de>
Date: Wed, 17 Jun 2015 20:12:47 +0000 (+0200)
Subject: Avoid assignment in return in TemplateParser.php
X-Git-Tag: 1.31.0-rc.0~11041^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/recherche.php?a=commitdiff_plain;h=2ce8768495da33228653b28343a5365afa4282e0;p=lhc%2Fweb%2Fwiklou.git

Avoid assignment in return in TemplateParser.php

Hard to read and may misread as boolean return

Change-Id: If6bfdbed7e647dde51db62ae6901874a83682d9e
---

diff --git a/includes/TemplateParser.php b/includes/TemplateParser.php
index 3de70fa2a2..d53d593f77 100644
--- a/includes/TemplateParser.php
+++ b/includes/TemplateParser.php
@@ -130,7 +130,8 @@ class TemplateParser {
 		if ( !is_callable( $renderer ) ) {
 			throw new RuntimeException( "Requested template, {$templateName}, is not callable" );
 		}
-		return $this->renderers[$templateName] = $renderer;
+		$this->renderers[$templateName] = $renderer;
+		return $renderer;
 	}
 
 	/**