X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/?a=blobdiff_plain;f=resources%2Fsrc%2Fmediawiki.rcfilters%2Fdm%2Fmw.rcfilters.dm.FiltersViewModel.js;h=5013c086214cbc6ad1deec00bad071eb87bdcc7e;hb=f58546ef6e55342ff2d54bdf9e421102aed7aa76;hp=62627e66617033876f5cbe8ad0cd4ab187d42e4a;hpb=c7b6b598ca248c520888affdefd429061ebc4302;p=lhc%2Fweb%2Fwiklou.git

diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
index 62627e6661..5013c08621 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
@@ -1051,12 +1051,14 @@
 		enable = enable === undefined ? !this.highlightEnabled : enable;
 
 		if ( this.highlightEnabled !== enable ) {
-			this.highlightEnabled = enable;
-
+			// HACK make sure highlights are disabled globally while we toggle on the items,
+			// otherwise we'll call clearHighlight() and applyHighlight() many many times
+			this.highlightEnabled = false;
 			this.getItems().forEach( function ( filterItem ) {
-				filterItem.toggleHighlight( this.highlightEnabled );
-			}.bind( this ) );
+				filterItem.toggleHighlight( enable );
+			} );
 
+			this.highlightEnabled = enable;
 			this.emit( 'highlightChange', this.highlightEnabled );
 		}
 	};