dépôts
/
lhc
/
web
/
wiklou.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Merge "RCFilters: Convert saved queries from filters to parameters"
[lhc/web/wiklou.git]
/
resources
/
src
/
mediawiki.rcfilters
/
dm
/
mw.rcfilters.dm.FiltersViewModel.js
diff --git
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
index
62627e6
..
5013c08
100644
(file)
--- a/
resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
+++ b/
resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
@@
-1051,12
+1051,14
@@
enable = enable === undefined ? !this.highlightEnabled : enable;
if ( this.highlightEnabled !== enable ) {
enable = enable === undefined ? !this.highlightEnabled : enable;
if ( this.highlightEnabled !== enable ) {
- this.highlightEnabled = enable;
-
+ // HACK make sure highlights are disabled globally while we toggle on the items,
+ // otherwise we'll call clearHighlight() and applyHighlight() many many times
+ this.highlightEnabled = false;
this.getItems().forEach( function ( filterItem ) {
this.getItems().forEach( function ( filterItem ) {
- filterItem.toggleHighlight(
this.highlightEnabled
);
- }
.bind( this )
);
+ filterItem.toggleHighlight(
enable
);
+ } );
+ this.highlightEnabled = enable;
this.emit( 'highlightChange', this.highlightEnabled );
}
};
this.emit( 'highlightChange', this.highlightEnabled );
}
};