From b3dd0fb560aa1a3a0d3c1cd75eacb055e56222b8 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Thu, 18 Sep 2014 23:10:03 -0700 Subject: [PATCH] Improve test coverage of Title::isValidMoveOperation Change-Id: Ifd81b0a894714ca94ab3e627ba83c881d96c3377 --- tests/phpunit/includes/TitleTest.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/phpunit/includes/TitleTest.php b/tests/phpunit/includes/TitleTest.php index 53c22b4cf2..fb58381f69 100644 --- a/tests/phpunit/includes/TitleTest.php +++ b/tests/phpunit/includes/TitleTest.php @@ -273,8 +273,10 @@ class TitleTest extends MediaWikiTestCase { * @param array|string|bool $expected Required error * @dataProvider provideTestIsValidMoveOperation * @covers Title::isValidMoveOperation + * @covers Title::validateFileMoveOperation */ public function testIsValidMoveOperation( $source, $target, $expected ) { + $this->setMwGlobals( 'wgContentHandlerUseDB', false ); $title = Title::newFromText( $source ); $nt = Title::newFromText( $target ); $errors = $title->isValidMoveOperation( $nt, false ); @@ -290,8 +292,15 @@ class TitleTest extends MediaWikiTestCase { public static function provideTestIsValidMoveOperation() { return array( + // for Title::isValidMoveOperation + array( 'Some page', '', 'badtitletext' ), array( 'Test', 'Test', 'selfmove' ), - array( 'File:Test.jpg', 'Page', 'imagenocrossnamespace' ) + array( 'Special:FooBar', 'Test', 'immobile-source-namespace' ), + array( 'Test', 'Special:FooBar', 'immobile-target-namespace' ), + array( 'MediaWiki:Common.js', 'Help:Some wikitext page', 'bad-target-model' ), + array( 'Page', 'File:Test.jpg', 'nonfile-cannot-move-to-file' ), + // for Title::validateFileMoveOperation + array( 'File:Test.jpg', 'Page', 'imagenocrossnamespace' ), ); } -- 2.20.1