Raimond Spekking [Wed, 28 Jul 2010 18:56:42 +0000 (18:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-28 18:32:00 UTC)
Bryan Tong Minh [Wed, 28 Jul 2010 17:31:32 +0000 (17:31 +0000)]
Refactor some code out of execute into selectUploadModule. Fixed an undefined variable.
Bryan Tong Minh [Wed, 28 Jul 2010 17:14:51 +0000 (17:14 +0000)]
Restructured upload-by-url:
* In ApiUpload: moved stuff that is checking instead of actual uploading out of performUpload method
* Made UploadFromUrl conform to standards:
** In initialize* do only initialization, no actual work
** Moved file fetching to fetchFile
** Consistent use of tempnam()
** Perform the uploading in performUpload, don't define our own doUpload method
* Moved almost all job magic to the UploadFromUrlJob class. This way the job is almost a regular client, and we don't need many special cases to deal with async uploading.
* Made leaving a message optional; results will be stored in the session otherwise
I did not actually test the async uploading, because I first wanted to commit a properly working synchronous upload-by-url system.
Platonides [Wed, 28 Jul 2010 13:51:42 +0000 (13:51 +0000)]
It's very nice having a fallback iconv() function, but we should take into account that Language.php calls it with the //IGNORE making the fallback a nop.
This fixes the two phpunit tests of Revision of Legacy encoding when native iconv is not available in php.
Allow js_unescape to take advantage of our wrapper, too. (although that function seems completely unused...)
Bryan Tong Minh [Wed, 28 Jul 2010 13:43:38 +0000 (13:43 +0000)]
Style fixes on UploadFromUrl.php
Platonides [Wed, 28 Jul 2010 12:11:46 +0000 (12:11 +0000)]
Remove unused global $IP
Platonides [Wed, 28 Jul 2010 12:07:53 +0000 (12:07 +0000)]
From globals to parameters: $columns, $exceptions, $verbose
New line after the error messages.
Platonides [Wed, 28 Jul 2010 11:46:33 +0000 (11:46 +0000)]
Remove the $wg since this is not a global.
Bryan Tong Minh [Wed, 28 Jul 2010 11:30:14 +0000 (11:30 +0000)]
(bug 24564) Fix fatal errors when using list=deletedrevs, prop=revisions or one of the backlinks generators with limit=max.
Ævar Arnfjörð Bjarmason [Wed, 28 Jul 2010 07:17:54 +0000 (07:17 +0000)]
installer: Fix grammar error in r70053 pointed out by github.com/wlangstroth
The comment was at http://github.com/mediawiki/mediawiki-trunk-phase3/commit/
89cc046998c41895dc9199e5ecb06efba5aee8ab
OverlordQ [Wed, 28 Jul 2010 05:08:21 +0000 (05:08 +0000)]
Followup to r69961, update PG schema
Tim Starling [Wed, 28 Jul 2010 04:12:36 +0000 (04:12 +0000)]
Reintroduced the extractRequestParams() memoization as in r69782, but respecting $parseLimit. Fixes bug 24564 (fatal error due to duplicate calls to addValue()).
Chad Horohoe [Tue, 27 Jul 2010 22:35:05 +0000 (22:35 +0000)]
Be more firm in telling users to download LocalSettings. I'm sure somebody's still going to complain...someone always does
Bryan Tong Minh [Tue, 27 Jul 2010 21:53:52 +0000 (21:53 +0000)]
Follow-up r70037: Fix ApiUpload by passing a WebRequestUpload to the the initializer
Follow-up r64403 and r69911: Fix broken upload from stash in Api.
Please tests your commits, even if the change seems totally harmless. You can use <http://mwclient.svn.sourceforge.net/viewvc/mwclient/tests/upload_api_test.py?revision=HEAD&view=markup> to automatically test uploading via the Api.
Bryan Tong Minh [Tue, 27 Jul 2010 20:54:34 +0000 (20:54 +0000)]
Follow-up r70037: Move isIniSizeOverflow magic to WebRequestUpload
Rotem Liss [Tue, 27 Jul 2010 20:47:16 +0000 (20:47 +0000)]
Localization update for he.
Platonides [Tue, 27 Jul 2010 20:44:42 +0000 (20:44 +0000)]
Commit some renderDump improvements
Platonides [Tue, 27 Jul 2010 20:39:09 +0000 (20:39 +0000)]
Actually use the global.
Bryan Tong Minh [Tue, 27 Jul 2010 20:38:36 +0000 (20:38 +0000)]
(bug 23380) Uploaded files that are larger than allowed by PHP now show a useful error message.
Introduced a WebRequestUpload class which is a wrapper around $_FILES and contains all getUpload* and getFile* methods. This has as advantage that the upload can be passed along without $wgRequest. Also because I like objects.
Aryeh Gregor [Tue, 27 Jul 2010 19:55:47 +0000 (19:55 +0000)]
Remove dead code added in r36814
None of the constructors will set $this->mTitle but not $this->mName,
and those are both private member variables. r69813 demonstrates that
no one had ever hit this code since it was first added in June 2008,
because it would have resulted in a fatal.
Siebrand Mazeland [Tue, 27 Jul 2010 19:36:07 +0000 (19:36 +0000)]
Localisation updates for core messages from translatewiki.net. Adding several new localisations:
* Moroccan Spoken Arabic (ary)
* Banjar (bjn)
* Kabardian (kdb)
* Kabardian (Cyrillic) (kbd-cyrl)
* Dutch (informal) (nl-informal)
Siebrand Mazeland [Tue, 27 Jul 2010 19:07:39 +0000 (19:07 +0000)]
Localisation updates for core messages from translatewiki.net
Platonides [Tue, 27 Jul 2010 18:52:19 +0000 (18:52 +0000)]
$wgMemc at line 563 was only the global if $wgPasswordAttemptThrottle was an array
Aren't globals funny?
Platonides [Tue, 27 Jul 2010 18:47:30 +0000 (18:47 +0000)]
Finish fixing r69883
Siebrand Mazeland [Tue, 27 Jul 2010 18:34:37 +0000 (18:34 +0000)]
Update single quotes to double quotes for consistency.
Platonides [Tue, 27 Jul 2010 18:33:04 +0000 (18:33 +0000)]
Use the canonical names for classes.
Siebrand Mazeland [Tue, 27 Jul 2010 17:23:06 +0000 (17:23 +0000)]
Partial revert of r69883. Broke page deletion because of missing global.
Nikerabbit suggested complete revert of r69883.
Daniel Kinzler [Tue, 27 Jul 2010 15:35:24 +0000 (15:35 +0000)]
vector accessibility: make a:focus like a:hover
Platonides [Tue, 27 Jul 2010 13:19:52 +0000 (13:19 +0000)]
Remove double global.
Platonides [Tue, 27 Jul 2010 13:19:16 +0000 (13:19 +0000)]
There's no longer a $wgLoadBalancer global. Replace with wfGetLB().
At least the isset() ensured do_templatelinks_update() didn't die.
Platonides [Tue, 27 Jul 2010 13:07:24 +0000 (13:07 +0000)]
Do not complain that the main namespace is not translated to other languages.
Platonides [Tue, 27 Jul 2010 12:30:19 +0000 (12:30 +0000)]
Use MediaWiki wfTempDir() and tempnam() instead of global $tmpPath and rand()
Platonides [Tue, 27 Jul 2010 12:20:22 +0000 (12:20 +0000)]
Unused global.
Platonides [Tue, 27 Jul 2010 12:19:08 +0000 (12:19 +0000)]
Followup r69961. Remove now unused global.
Danny B [Tue, 27 Jul 2010 11:27:28 +0000 (11:27 +0000)]
* (bug 19858) Removed obsolete <big> in interface messages.
Sam Reed [Tue, 27 Jul 2010 11:13:53 +0000 (11:13 +0000)]
r70000 !
Give Translator CREDITS to Translatewiki.net Users :)
Bryan Tong Minh [Tue, 27 Jul 2010 10:31:30 +0000 (10:31 +0000)]
Fixes for (bug 18885), r60593, r60979: The upload link for missing files can now be set separately from the navigation link with $wgUploadMissingFileUrl.
Sam Reed [Tue, 27 Jul 2010 10:30:07 +0000 (10:30 +0000)]
Make EditPage::spamPage() static
Add braces
Tim Starling [Tue, 27 Jul 2010 02:39:32 +0000 (02:39 +0000)]
* Rewrote r69952, profileinfo.php XSS fix. It was probably safe, but it seemed very confused about the order of escaping operations. The whole MediaWiki framework is available, including wfArrayToCGI(), there's no need for unconventional code.
* Renamed makeurl() to something more descriptive and less likely to conflict with extensions.
Platonides [Mon, 26 Jul 2010 22:29:20 +0000 (22:29 +0000)]
Insert a new line in between when adding </td><td> in tables.
This is html neutral, but helps the parser to realise that things should be broken there.
Fixes the tag nesting issues of the [ftp://|x||]] parser test.
Parser16 test still has its own tag bug.
Platonides [Mon, 26 Jul 2010 22:09:58 +0000 (22:09 +0000)]
Move up to date the parser test expectation.
The ftp://|x|| url has been recognised as ftp://|x since r14350.
Aryeh Gregor [Mon, 26 Jul 2010 22:04:19 +0000 (22:04 +0000)]
Fix bug in prefixing scheme
As Bawolff pointed out at [[mw:User talk:Simetrical/Collation]], the
prefixing scheme I was using meant that the page "Z" with sort key of
"F" would sort after a page named "A" with a sort key of "FF", since the
first one's raw sort key would compute to "FZ", and the second's would
compute to "FFA". I've fixed this by separating the prefix from the
unprefixed part by a null byte (cl_sortkey is eventually going to be
totally binary anyway, may as well start now).
Aryeh Gregor [Mon, 26 Jul 2010 21:27:07 +0000 (21:27 +0000)]
Paginate the three category sections separately
This fully fixes bug 1211. It might be buggy, and
$wgExperimentalCategorySort sure makes it hackish. I should definitely
have gone with some kind of branch here. More testing would be good.
Also, the UI could use improvement (extra ugly next/previous 200 links
in various places).
Platonides [Mon, 26 Jul 2010 21:01:34 +0000 (21:01 +0000)]
From global to parameter.
Platonides [Mon, 26 Jul 2010 20:55:44 +0000 (20:55 +0000)]
Followup r69909. This.. is.. no.. longer... a global!
Platonides [Mon, 26 Jul 2010 20:51:33 +0000 (20:51 +0000)]
Follow up r21799. Fix usage of $this in static method.
Siebrand Mazeland [Mon, 26 Jul 2010 20:29:55 +0000 (20:29 +0000)]
Revert r69841, r69882, r69892, r69896, r69910 in phase3/maintenance/language because rebuildLanguage.php was broken.
This prevented message updates by Raymond from translatewiki.net.
Reported issues:
* Warning: in_array() expects parameter 2 to be array, null given in maintenance\language\languages.inc on line 173
* Warning: in_array() expects parameter 2 to be array, null given in maintenance\language\languages.inc on line 175
* Warning: in_array(): Wrong datatype for second argument in phase3\maintenance\language\languages.inc on line 175
Raimond Spekking [Mon, 26 Jul 2010 20:16:35 +0000 (20:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-26 20:10:00 UTC)
Aryeh Gregor [Mon, 26 Jul 2010 19:27:13 +0000 (19:27 +0000)]
Reconcept cl_raw_sortkey as cl_sortkey_prefix
In response to feedback by Phillipe Verdy on bug 164. Now if a bunch of
pages have [[Category:Foo| ]], they'll sort amongst themselves according
to page name, instead of in basically random order as it is currently.
This also makes storage more elegant and intuitive: instead of giving
NULL a magic meaning when there's no custom sortkey specified, we just
store an empty string, since there's no prefix.
This means {{defaultsort:}} really now means {{defaultsortprefix:}},
which is slightly confusing, and a lot of code is now slightly
misleading or poorly named. But it should all work fine.
Also, while I was at it, I made updateCollation.php work as a transition
script, so you can apply the SQL patch and then run updateCollation.php
and things will work. However, with the new schema it's not trivial to
reverse this -- you'd have to recover the raw sort keys with some PHP.
Conversion goes at about a thousand rows a second for me, and seems to
be CPU-bound. Could probably be optimized.
I also adjusted the transition script so it will fix rows with collation
versions *greater* than the current one, as well as less. Thus if some
site wants to use their own collation, they can call it 137 or
something, and if they later want to switch back to MediaWiki stock
collation 7, it will work.
Also fixed a silly bug in updateCollation.php where it would say "1000
done" if it did nothing, and changed $res->numRows() >= self::BATCH_SIZE
to == so people don't wonder how it could be bigger (since it can't, I
hope).
Platonides [Mon, 26 Jul 2010 17:41:14 +0000 (17:41 +0000)]
Close the web page when it is disabled.
Fix XSS in filter parameter. Normal setups (with $wgEnableProfileInfo = false) are not affected.
Jeroen De Dauw [Mon, 26 Jul 2010 17:31:38 +0000 (17:31 +0000)]
Style improvements
Philip Tzou [Mon, 26 Jul 2010 16:09:06 +0000 (16:09 +0000)]
Follow up r69874. Fix the separation markup.
Platonides [Mon, 26 Jul 2010 12:39:44 +0000 (12:39 +0000)]
Moved globals $utfCombiningClass, $utfCanonicalComp, $utfCanonicalDecomp, $utfCheckNFC and utfCompatibilityDecomp into UtfNormal class
Regenerated unicode tables
All tests successful
Platonides [Mon, 26 Jul 2010 09:40:40 +0000 (09:40 +0000)]
RELEASE NOTES for r69918
Tim Starling [Mon, 26 Jul 2010 07:35:30 +0000 (07:35 +0000)]
Fix for r69776: remove unused variable ApiMain::$mVaryCookie
Sam Reed [Mon, 26 Jul 2010 06:57:58 +0000 (06:57 +0000)]
Followup r69921
PHP Parse error: syntax error, unexpected T_OBJECT_OPERATOR, expecting T_PAAMAYIM_NEKUDOTAYIM in includes/db/DatabasePostgres.php on line 1157
Tim Starling [Mon, 26 Jul 2010 06:20:29 +0000 (06:20 +0000)]
Partial revert of r69782: reverted the cache feature, it does not correctly respect $parseLimit.
Platonides [Sun, 25 Jul 2010 22:29:05 +0000 (22:29 +0000)]
Move getValidNamespaces() to Namespace.php
Platonides [Sun, 25 Jul 2010 22:09:34 +0000 (22:09 +0000)]
Kill $wgDBversion
Sam Reed [Sun, 25 Jul 2010 21:44:29 +0000 (21:44 +0000)]
More unused variables, whitespace
Sam Reed [Sun, 25 Jul 2010 21:43:44 +0000 (21:43 +0000)]
1 more dynamic used as static
Platonides [Sun, 25 Jul 2010 21:43:11 +0000 (21:43 +0000)]
Kill $wgDBport_db2
Platonides [Sun, 25 Jul 2010 21:37:03 +0000 (21:37 +0000)]
Kill $wgUseRootUser variable.
Chad Horohoe [Sun, 25 Jul 2010 21:26:28 +0000 (21:26 +0000)]
Remove useless ext installation script. All this stuff is being redone as part of GSoC and nothing here is useful at all
Platonides [Sun, 25 Jul 2010 21:25:42 +0000 (21:25 +0000)]
Add $wgLicenseTerms to DefaultSettings
Sam Reed [Sun, 25 Jul 2010 21:15:27 +0000 (21:15 +0000)]
A few more wrong static things
Remove some =& from LanguageKk_cyrl
Platonides [Sun, 25 Jul 2010 21:11:38 +0000 (21:11 +0000)]
Follow up r53497. $wgExternalAuthConfig -> $wgExternalAuthConf
Only DefaultSettings calls it like that. All the classes use $wgExternalAuthConf
Sam Reed [Sun, 25 Jul 2010 21:08:34 +0000 (21:08 +0000)]
Fixup some more wrong static usages
Sam Reed [Sun, 25 Jul 2010 21:02:56 +0000 (21:02 +0000)]
Change some more to parent::
Platonides [Sun, 25 Jul 2010 21:02:42 +0000 (21:02 +0000)]
Kill $wgDBsuperuser
Sam Reed [Sun, 25 Jul 2010 20:56:22 +0000 (20:56 +0000)]
File:: to parent::
Sam Reed [Sun, 25 Jul 2010 20:55:51 +0000 (20:55 +0000)]
Pass $this->getName() to getLocalUrl
Sam Reed [Sun, 25 Jul 2010 20:52:30 +0000 (20:52 +0000)]
Article:: to self::
Sam Reed [Sun, 25 Jul 2010 20:51:16 +0000 (20:51 +0000)]
Followup r69904 $self to self
Sam Reed [Sun, 25 Jul 2010 20:44:40 +0000 (20:44 +0000)]
Make getRandomString static as per comment
Fix usage in top of Parser (changed by me earlier)
Raimond Spekking [Sun, 25 Jul 2010 20:08:31 +0000 (20:08 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-25 19:47:00 UTC)
Platonides [Sun, 25 Jul 2010 19:45:52 +0000 (19:45 +0000)]
Remove double globals.
Platonides [Sun, 25 Jul 2010 19:36:35 +0000 (19:36 +0000)]
Remove unused globals.
Platonides [Sun, 25 Jul 2010 18:39:41 +0000 (18:39 +0000)]
Add a few globals.
Platonides [Sun, 25 Jul 2010 18:26:44 +0000 (18:26 +0000)]
Follow up r69643. Remove unused global.
Platonides [Sun, 25 Jul 2010 18:24:29 +0000 (18:24 +0000)]
Move double $wgOut globals to the top, remove $wgLang duplicated global.
Platonides [Sun, 25 Jul 2010 18:20:21 +0000 (18:20 +0000)]
Follow up r68354. $wgUser *is* used in successfulLogin() and mailPasswordInternal().
Platonides [Sun, 25 Jul 2010 18:16:25 +0000 (18:16 +0000)]
Do not use a global $action to get the action.
Sam Reed [Sun, 25 Jul 2010 18:13:56 +0000 (18:13 +0000)]
More self:: to $this->
Platonides [Sun, 25 Jul 2010 18:04:41 +0000 (18:04 +0000)]
I don't think you wanted to assign $IP as a local variable...
Sam Reed [Sun, 25 Jul 2010 18:03:11 +0000 (18:03 +0000)]
Many self:: to $this-> in HttpTest
Sam Reed [Sun, 25 Jul 2010 18:00:32 +0000 (18:00 +0000)]
Fix some wrong usages of static method calls (actually belong to class instance)
Platonides [Sun, 25 Jul 2010 17:56:23 +0000 (17:56 +0000)]
Mark used $wgUser as global.
$wgLang of 2917 already marked as global in 2889. Ditto for $wgDeleteRevisionsLimit of 2927.
$wgContLangmarked as global twice in getAutosummary
Are you able to catch the global declared twice left?
Sam Reed [Sun, 25 Jul 2010 17:53:16 +0000 (17:53 +0000)]
Add some more missing globals
Platonides [Sun, 25 Jul 2010 17:48:48 +0000 (17:48 +0000)]
$wgLang is already marked as global at the top.
Sam Reed [Sun, 25 Jul 2010 17:47:41 +0000 (17:47 +0000)]
More unused globals
Platonides [Sun, 25 Jul 2010 17:46:15 +0000 (17:46 +0000)]
Remove unused global faster than Reedy.
Platonides [Sun, 25 Jul 2010 17:45:04 +0000 (17:45 +0000)]
Add used global $wgOut.
Philip Tzou [Sun, 25 Jul 2010 16:59:32 +0000 (16:59 +0000)]
follow up r69874. use string instead of object .
Philip Tzou [Sun, 25 Jul 2010 16:53:55 +0000 (16:53 +0000)]
Performance improvement: in doVariants(), concatenate a bulk of titles to a single string, thus we just need to call convertLinkToAllVariants() once.
Jack Phoenix [Sun, 25 Jul 2010 15:53:22 +0000 (15:53 +0000)]
coding style tweaks to Title.php
Jack Phoenix [Sun, 25 Jul 2010 15:50:23 +0000 (15:50 +0000)]
coding style tweaks to Interwiki.php
Philip Tzou [Sun, 25 Jul 2010 12:01:13 +0000 (12:01 +0000)]
Update the Chinese conversion tables.
Philip Tzou [Sun, 25 Jul 2010 11:52:04 +0000 (11:52 +0000)]
Update the Chinese conversion tables.
Alexandre Emsenhuber [Sun, 25 Jul 2010 11:40:52 +0000 (11:40 +0000)]
* (bug 24517) LocalFile::newFromKey() and OldLocalFile::newFromKey() no longer throw fatal errors