From: Kunal Mehta <legoktm@gmail.com>
Date: Fri, 19 Sep 2014 06:10:03 +0000 (-0700)
Subject: Improve test coverage of Title::isValidMoveOperation
X-Git-Tag: 1.31.0-rc.0~13928
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/supprimer.php?a=commitdiff_plain;h=b3dd0fb560aa1a3a0d3c1cd75eacb055e56222b8;p=lhc%2Fweb%2Fwiklou.git

Improve test coverage of Title::isValidMoveOperation

Change-Id: Ifd81b0a894714ca94ab3e627ba83c881d96c3377
---

diff --git a/tests/phpunit/includes/TitleTest.php b/tests/phpunit/includes/TitleTest.php
index 53c22b4cf2..fb58381f69 100644
--- a/tests/phpunit/includes/TitleTest.php
+++ b/tests/phpunit/includes/TitleTest.php
@@ -273,8 +273,10 @@ class TitleTest extends MediaWikiTestCase {
 	 * @param array|string|bool $expected Required error
 	 * @dataProvider provideTestIsValidMoveOperation
 	 * @covers Title::isValidMoveOperation
+	 * @covers Title::validateFileMoveOperation
 	 */
 	public function testIsValidMoveOperation( $source, $target, $expected ) {
+		$this->setMwGlobals( 'wgContentHandlerUseDB', false );
 		$title = Title::newFromText( $source );
 		$nt = Title::newFromText( $target );
 		$errors = $title->isValidMoveOperation( $nt, false );
@@ -290,8 +292,15 @@ class TitleTest extends MediaWikiTestCase {
 
 	public static function provideTestIsValidMoveOperation() {
 		return array(
+			// for Title::isValidMoveOperation
+			array( 'Some page', '', 'badtitletext' ),
 			array( 'Test', 'Test', 'selfmove' ),
-			array( 'File:Test.jpg', 'Page', 'imagenocrossnamespace' )
+			array( 'Special:FooBar', 'Test', 'immobile-source-namespace' ),
+			array( 'Test', 'Special:FooBar', 'immobile-target-namespace' ),
+			array( 'MediaWiki:Common.js', 'Help:Some wikitext page', 'bad-target-model' ),
+			array( 'Page', 'File:Test.jpg', 'nonfile-cannot-move-to-file' ),
+			// for Title::validateFileMoveOperation
+			array( 'File:Test.jpg', 'Page', 'imagenocrossnamespace' ),
 		);
 	}