Brad Jorsch [Wed, 15 Apr 2015 18:38:32 +0000 (14:38 -0400)]
CREDITS for This, That, and the other
After I77f476c, I37275e0f, and I7d3ef92, you deserve it.
Change-Id: Ie14c97587ada080f4e935e4d2e971ea36111d029
Brad Jorsch [Wed, 15 Apr 2015 18:35:07 +0000 (14:35 -0400)]
RELEASE-NOTES for change tagging changes
See I37275e0f and I7d3ef92.
Change-Id: I4ed12a2551241f3224d9994b66e3f1675c51d236
This, that and the other [Wed, 15 Apr 2015 01:31:53 +0000 (11:31 +1000)]
UI for adding and removing change tags on revisions and log entries
There is a new special page, Special:EditTags, which is very similar to
Special:RevisionDelete in a lot of ways. In fact, the SpecialEditTags class
started off as a copy-paste of SpecialRevisiondelete.
You invoke this special page by going to an article history page, checking
some revisions, and clicking "Edit tags of selected revisions". Then you
pick the modifications you want to make and click "Apply". Very much like
the revision deletion workflow.
I had to restructure some of the Action routing code, which was only
designed to handle revision deletion. Also removing some code from
SpecialRevisiondelete which didn't work as advertised in the first place,
and definitely doesn't work now.
Change-Id: I7d3ef927b5686f6211bc5817776286ead19d916b
This, that and the other [Wed, 15 Apr 2015 01:33:08 +0000 (11:33 +1000)]
Allow users to add, remove and apply change tags using the API
You can add tags at the same time as performing action=edit, as long as you
have the "applychangetags" right. Also, you can add or remove tags after
the fact from revisions and log entries using the API action=tags.
No UI is provided for either of these changes. The target audience is user
scripts, gadgets and similar tools.
Includes a new log parameter format type: "list", for a comma-separated
list of values.
Logging of change tag events is limited to those that do not accompany an
edit (i.e. those done after the fact), and is hidden from Special:Log by
default, similar to the patrol log.
Bug: T20670
Change-Id: I37275e0f73fa3127f55da0c320b892551b61ee80
jenkins-bot [Wed, 15 Apr 2015 16:51:38 +0000 (16:51 +0000)]
Merge "Add namespace aliases for Luri (lrc)"
Aaron Schulz [Wed, 15 Apr 2015 15:09:24 +0000 (15:09 +0000)]
Merge "Moved $wgShowUpdatedMarker checks to the right place"
Nikerabbit [Wed, 15 Apr 2015 11:37:40 +0000 (11:37 +0000)]
Merge "Remove zh-tw message "editing""
jenkins-bot [Wed, 15 Apr 2015 08:42:36 +0000 (08:42 +0000)]
Merge "Message::inLanguage() shouldn't unstub StubUserLang"
Aaron Schulz [Wed, 15 Apr 2015 03:02:29 +0000 (03:02 +0000)]
Merge "Avoid deadlocks in User::incEditCount"
Aaron Schulz [Wed, 15 Apr 2015 01:56:39 +0000 (18:56 -0700)]
Moved $wgShowUpdatedMarker checks to the right place
Change-Id: Icee2ec24aac5fe78f7204aabf434640251791cae
Aaron Schulz [Wed, 15 Apr 2015 01:06:04 +0000 (18:06 -0700)]
Removed some code duplication in Title::getNotificationTimestamp
Change-Id: I02114258448c1dec894e51c2d4c84cb2517eccb7
jenkins-bot [Wed, 15 Apr 2015 00:50:31 +0000 (00:50 +0000)]
Merge "Avoid page_restrictions field queries for templates on edit form"
jenkins-bot [Wed, 15 Apr 2015 00:41:05 +0000 (00:41 +0000)]
Merge "Reduce outages due to master DB problems in doViewUpdates"
jenkins-bot [Tue, 14 Apr 2015 22:19:50 +0000 (22:19 +0000)]
Merge "mediawiki.loader: Remove optional params in mw.loader.implement tests"
jenkins-bot [Tue, 14 Apr 2015 22:00:11 +0000 (22:00 +0000)]
Merge "Don't bother buffering a counter update with a delta of zero."
jenkins-bot [Tue, 14 Apr 2015 21:46:31 +0000 (21:46 +0000)]
Merge "Displaying protection expiry date and time in action=info"
Ori Livneh [Tue, 14 Apr 2015 18:51:26 +0000 (11:51 -0700)]
Don't bother buffering a counter update with a delta of zero.
Counter updates with a delta of zero don't do anything, so there's no point in
sending them over the wire.
Change-Id: Iae82ee9c9a8544c94abfcbdf944bd713687dce9d
Alex Monk [Tue, 14 Apr 2015 19:50:12 +0000 (20:50 +0100)]
Fix link to Special:RevisionDelete in newer log revdel logs
Bug: T96049
Change-Id: I6817ac13e776a3e6fa766c3996173b5da02f54de
Follows-up: Ic149960f797d05fd088fa014390d791e3ae08687
Translation updater bot [Tue, 14 Apr 2015 19:40:40 +0000 (21:40 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I29bea8f29d49d43dc501daf22ba6d572be7901b0
jenkins-bot [Tue, 14 Apr 2015 18:57:16 +0000 (18:57 +0000)]
Merge "Clean up handling of 'infinity'"
Mark Holmquist [Tue, 14 Apr 2015 18:23:20 +0000 (11:23 -0700)]
UploadForm: Don't set a null context
Breaking Special:Specialpages on master now.
Bug: T96057
Change-Id: Ieb21b4d07af2dc8ea18016568c98b78e390ac2d5
Aaron Schulz [Mon, 13 Apr 2015 23:50:34 +0000 (16:50 -0700)]
Reduce outages due to master DB problems in doViewUpdates
Change-Id: Ie28e8dcfc3bc402b3119d9cf43612acab2af1004
jenkins-bot [Tue, 14 Apr 2015 15:09:59 +0000 (15:09 +0000)]
Merge "Handle missing returnto on Special:ChangePassword/ConfirmEmail"
Aaron Schulz [Mon, 13 Apr 2015 23:02:16 +0000 (16:02 -0700)]
Avoid deadlocks in User::incEditCount
* This makes concurrent editing less problematic
Change-Id: I930222d5e831bb3729194abbdcb3cab194c70494
jenkins-bot [Tue, 14 Apr 2015 03:56:20 +0000 (03:56 +0000)]
Merge "API: Add license info to API help output"
Aaron Schulz [Tue, 14 Apr 2015 00:34:58 +0000 (00:34 +0000)]
Merge "Avoid edit stash log spam for bots"
Aaron Schulz [Sat, 11 Apr 2015 19:34:48 +0000 (12:34 -0700)]
Avoid page_restrictions field queries for templates on edit form
* Title::newFromRow() will actually load page_restrictions, which
should normally be empty. This avoids queries in getRestrictions().
Those queries could add 100-200ms to edit form views.
* getLinksFrom() has been simplified to use newFromRow(), thus
loading the old restrictions in passing.
Change-Id: I225955589a82e4accbf059d17390a5e28e2fa1ca
Aaron Schulz [Mon, 13 Apr 2015 23:01:53 +0000 (23:01 +0000)]
Merge "Made WatchedItem use Revision::getTimestampFromId"
Aaron Schulz [Mon, 13 Apr 2015 22:32:32 +0000 (22:32 +0000)]
Merge "Avoid using local main page title in JobSpecification"
jenkins-bot [Mon, 13 Apr 2015 22:16:11 +0000 (22:16 +0000)]
Merge "Made job factory() callers use Title::makeTitle"
jenkins-bot [Mon, 13 Apr 2015 22:08:44 +0000 (22:08 +0000)]
Merge "wikibits: Mark importScript/importStylesheet utilities as deprecated"
Aaron Schulz [Mon, 13 Apr 2015 21:50:40 +0000 (14:50 -0700)]
Avoid using local main page title in JobSpecification
* They may not work well on the wiki that runs the jobs
Bug: T92789
Change-Id: I496974b11bd865ede9dd6d2cd534e0abdd7fa3f7
Aaron Schulz [Mon, 13 Apr 2015 19:18:31 +0000 (12:18 -0700)]
Made WatchedItem use Revision::getTimestampFromId
Change-Id: I3a895a69e8f4678b82a4e50f70d6bfc4df932d74
Aaron Schulz [Mon, 13 Apr 2015 21:21:30 +0000 (14:21 -0700)]
Made job factory() callers use Title::makeTitle
* The titles are not from user input and this simplifies the code
Change-Id: I067049cca5661b387076f0c28bc0b71d22162a0f
Translation updater bot [Mon, 13 Apr 2015 20:10:07 +0000 (22:10 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I0ed09090cdcf12ced0fe66f47045795f97a11b0b
umherirrender [Mon, 13 Apr 2015 19:31:49 +0000 (21:31 +0200)]
Handle missing returnto on Special:ChangePassword/ConfirmEmail
A missing returnto results in a null passed to Title::newFromText which
gives a warning:
Notice: Title::newFromText: $text must be a string. This will throw an
InvalidArgumentException in future
Follow-Up: I2b36b7a3b96b37e29fe06f69c13a185b3ec592a7
Change-Id: I95e6023a2630cbae69f25d63611ebafb8b2bd74c
Timo Tijhof [Sat, 11 Apr 2015 12:57:55 +0000 (13:57 +0100)]
specials: Clean up redirect special pages ($subpage can be null)
$subpage being null is clearly documented in SpecialPage::run,
SpecialPage::execute, and most special page subclasses.
But all the redirect subclasses only copied part of the typehint,
making it look like it's always a string.
For SpecialMyLanguage, follows-up
b1853bba0. Don't cast null to
empty string, and don't bother giving Title::newFromText an empty
string only to bail out with null again.
Also:
* Add visibility 'public' where missing.
* Add or correct relevant documentation comments.
* In SpecialMyRedirectPages, handle error first and avoid having
final return inside a conditional; Remove redunant 'else'.
Change-Id: Ie3543f44011832b198bb3d3e32528b6a2868dee1
Schnark [Sat, 11 Apr 2015 08:07:54 +0000 (08:07 +0000)]
wikibits: Mark importScript/importStylesheet utilities as deprecated
The global variable loadedScripts and the import functions from wikibits.js
have been deprecated since 1.17 [1].
The global loadedScripts is used to keep track which scripts have
been loaded through importScriptURI. To do this, it only needs to be
a local variable, not a global.
For scripts using the global to check whether a particular script
has been loaded, here are some possible substitutes:
* Use mw.loader.getState() for scripts loaded through ResourceLoader
(which includes Gadgets).
* Use hooks (mw.hook) to communicate between the scripts.
* Use $( 'script[src="..."]' ).length to check whether a script with
a specific URL has been loaded.
* Use $( 'script[src]' ) for a list of all scripts (excluding inline
scripts), and filter it for whatever you are looking for.
The functions importScriptURI and importStylesheetURI are used to
load scripts and stylesheets resp. from a URI. Use mw.loader.load() instead.
Note that there are minor differences between the deprecated functions
and mw.loader.load(), see [1] for details.
The importScript and importStylesheet shortcuts have been deprecated as well.
[1] https://www.mediawiki.org/wiki/RL/LJS#wikibits.js
Change-Id: Icc87243a8213841bfe46e48a9c074301c241041c
jenkins-bot [Mon, 13 Apr 2015 16:49:36 +0000 (16:49 +0000)]
Merge "Change Language::timeanddate to userTimeAndDate in RevisionList"
Brad Jorsch [Mon, 13 Apr 2015 15:40:30 +0000 (11:40 -0400)]
Message::inLanguage() shouldn't unstub StubUserLang
When a string is passed to Message::inLanguage(), it first checks
whether the message's current language's code is equal to the string, to
avoid a call to Language::factory(). But if the message's current
language is an instance of StubUserLang, it's probably less expensive to
just call Language::factory() than it is to unstub.
This also avoids a possible recursion warning from T56193, particularly
if inLanguage() is being used intentionally in an attempt to avoid that
warning.
Change-Id: Ia09adec05cfbb09c09e07c6be1e2d613435664d9
Tony Thomas [Mon, 13 Apr 2015 04:43:36 +0000 (10:13 +0530)]
Corrected typos in function name unpackMetaData and getMetaData
Bug: T95873
Change-Id: I71dffaaed24c983ce07bc02f806294337ca086e2
Liangent [Mon, 13 Apr 2015 03:47:17 +0000 (03:47 +0000)]
Remove zh-tw message "editing"
The current string is incorrect (written in zh-hans); removing it to
let it fall back to zh-hant. Since zh-tw exporting has been disabled
on translatewiki.net, it's not possible to fix it there. Maybe a full
cleanup is needed for zh-(cn|hk|mo|my|sg|tw).json at some time.
Change-Id: I3cc7bbb2065ecae535986525367d26dfc82c49b1
Translation updater bot [Sun, 12 Apr 2015 19:30:10 +0000 (21:30 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I27277eaf911553a14ed87622ca36a6212829a2b5
jenkins-bot [Sun, 12 Apr 2015 18:32:19 +0000 (18:32 +0000)]
Merge "Add page_restrictions to readlock in lockSearchindex"
jenkins-bot [Sun, 12 Apr 2015 18:29:36 +0000 (18:29 +0000)]
Merge "Only need one check for is_dir"
Timo Tijhof [Sun, 12 Apr 2015 17:25:32 +0000 (18:25 +0100)]
Update OOjs UI to v0.9.8
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.9.8/History.md
Change-Id: I369a24f74c455cd42571718a7b0078fd24c5f25e
Niklas Laxström [Fri, 10 Apr 2015 16:14:38 +0000 (18:14 +0200)]
Add second param to Title::newFromText warning so that called from works correctly
Change-Id: Ib977acb9abfcc6e07019013c6f9fc20ece16245d
mjbmr [Sun, 12 Apr 2015 08:22:32 +0000 (08:22 +0000)]
Add namespace aliases for Luri (lrc)
Change-Id: Ifaf3a58cd5b525305f2d545f8a50751f85579756
umherirrender [Sat, 17 Jan 2015 19:31:18 +0000 (20:31 +0100)]
Change Language::timeanddate to userTimeAndDate in RevisionList
This avois using $wgUser when formatting the timestamp
This was done in the overrides with
I30d88822d8ede5c138dd5403a998dd722f950bbe
The htmlspecialchars was added with
Ie1f16029020f980abba35d6322b89c95326f107b to the overrides.
Change-Id: Iaa12064502b343f0f47178f4848eed72662b422c
jenkins-bot [Sun, 12 Apr 2015 00:02:39 +0000 (00:02 +0000)]
Merge "installer: Clear module_deps cache in updater"
jenkins-bot [Sat, 11 Apr 2015 23:51:59 +0000 (23:51 +0000)]
Merge "Use Language::userTime in Preferences::datetimePreferences"
jenkins-bot [Sat, 11 Apr 2015 23:50:34 +0000 (23:50 +0000)]
Merge "Fix most of IPTest to use data providers"
jenkins-bot [Sat, 11 Apr 2015 23:47:00 +0000 (23:47 +0000)]
Merge "Set context earlier in UploadForm::__construct"
Timo Tijhof [Fri, 10 Apr 2015 19:35:13 +0000 (20:35 +0100)]
installer: Clear module_deps cache in updater
Unless --nopurge is set in update.php, clear module_deps cache
tables.
We already clear the objectcache via purgeCache(), and
msg_resource and msg_resource_links via MessageBlobStore::clear().
The module_deps table should be included as well.
Bug: T37472
Change-Id: I7cb63bb39a62b7f5be3855d022a8c76e175e95b5
jenkins-bot [Sat, 11 Apr 2015 20:58:03 +0000 (20:58 +0000)]
Merge "Enable entity loader and handle errors nicely in WikiImporter constructor"
Translation updater bot [Sat, 11 Apr 2015 19:09:43 +0000 (21:09 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If81891b3a9bd94e4e60979f16798625a32b19640
Tina Johnson [Thu, 19 Mar 2015 15:34:50 +0000 (21:04 +0530)]
Display warning message in Special:ListFiles when invalid username entered
A warning message is to be displayed when an invalid username
is entered in Special:ListFiles. This patch does the same
Bug: T72784
Change-Id: I35fef559db812d347af7a313778e25f775e1bfb6
Aaron Schulz [Sat, 11 Apr 2015 04:06:26 +0000 (21:06 -0700)]
Avoid edit stash log spam for bots
Change-Id: I2f9cc86794f8eee282c5efdbe96d4ff981b1977b
This, that and the other [Tue, 13 Jan 2015 05:57:07 +0000 (16:57 +1100)]
Enable entity loader and handle errors nicely in WikiImporter constructor
Two issues being addressed here:
* Slightly friendlier message (instead of fatal) if libxml is not present
* Need to make sure the entity loader is enabled when opening XML documents
Also provide an error message when XMLReader::open fails, as otherwise,
the user sees cryptic errors from code that tries to use the (unopened)
XMLReader.
Bug: T45868
Bug: T86036
Change-Id: Ibcccce9f09f87b17c3093fd0c3c3ff74d7dc6cb7
Translation updater bot [Fri, 10 Apr 2015 19:24:10 +0000 (21:24 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib5c98b70064d107f2299169a33cc1f4d43e35953
jenkins-bot [Fri, 10 Apr 2015 18:21:01 +0000 (18:21 +0000)]
Merge "debug: Add missing "use DateTimeZone" in LegacyLogger.php"
jenkins-bot [Fri, 10 Apr 2015 18:04:19 +0000 (18:04 +0000)]
Merge "Reorder backlinks indexes"
Kunal Mehta [Fri, 10 Apr 2015 17:57:01 +0000 (10:57 -0700)]
debug: Add missing "use DateTimeZone" in LegacyLogger.php
Seen in fatal.log in production: ErrorException from line 264 of
/srv/mediawiki/php-1.26wmf1/includes/exception/MWExceptionHandler.php:
Fatal Error: Class undefined: MediaWiki\Logger\DateTimeZone
Bug: T95727
Change-Id: Icb303314caaef47ac767fbf593e92d09e818f147
umherirrender [Thu, 29 Jan 2015 16:13:04 +0000 (17:13 +0100)]
Use Language::userTime in Preferences::datetimePreferences
This avoids the indirect use of $wgUser
Change-Id: I951f5c4399dff6bb17c04e20dd9a7f763027b873
Kunal Mehta [Mon, 16 Mar 2015 07:30:41 +0000 (00:30 -0700)]
Remove unused "swap" global function
Deprecated in
26e1e083e8bfd4, unused since r12411.
Change-Id: If328f09114ac5a5d23a300d9b0bbcd7d67e051c8
Timo Tijhof [Tue, 9 Dec 2014 02:15:28 +0000 (02:15 +0000)]
mediawiki.loader: Remove optional params in mw.loader.implement tests
Follows-up
1f393b6da8736c. Done in a separate change to ensure
those tests work both ways.
Change-Id: I7e185db56e36fdfbb88c2d0938cdf55881e8c313
jenkins-bot [Fri, 10 Apr 2015 16:48:57 +0000 (16:48 +0000)]
Merge "Switched RevDelList to using start/endAtomic()"
jenkins-bot [Fri, 10 Apr 2015 16:48:54 +0000 (16:48 +0000)]
Merge "Made deleteTagEverywhere use start/endAtomic()"
jenkins-bot [Fri, 10 Apr 2015 16:48:51 +0000 (16:48 +0000)]
Merge "Made QueryPage::preprocessResults also use the vslow group"
jenkins-bot [Fri, 10 Apr 2015 16:48:46 +0000 (16:48 +0000)]
Merge "Made JobRunner avoid slave lag more aggressively"
Chad Horohoe [Fri, 10 Apr 2015 16:03:58 +0000 (09:03 -0700)]
Fix most of IPTest to use data providers
Change-Id: I7a41af445549f6688c559adbc5f16bdb428dae60
Bryan Davis [Fri, 10 Apr 2015 15:58:43 +0000 (09:58 -0600)]
phpdoc: make references to \MediaWiki\Logger\Spi fully qualified
Change-Id: I4a5dbc3894ea175053e1238e7fc5de4c4cf085ca
jenkins-bot [Fri, 10 Apr 2015 14:51:14 +0000 (14:51 +0000)]
Merge "Replace use of assertType with assertInternalType and assertInstanceOf"
jenkins-bot [Fri, 10 Apr 2015 14:15:52 +0000 (14:15 +0000)]
Merge "Removed SpecialStatistics query group; vslow is enough"
Aaron Schulz [Fri, 10 Apr 2015 09:31:35 +0000 (02:31 -0700)]
Made QueryPage::preprocessResults also use the vslow group
Change-Id: If5893ef9e2a18684c8cd1ce1b6149742b392a3c3
jenkins-bot [Fri, 10 Apr 2015 07:41:04 +0000 (07:41 +0000)]
Merge "Update namespaces for Luri (lrc) from translatewiki"
jenkins-bot [Fri, 10 Apr 2015 07:27:10 +0000 (07:27 +0000)]
Merge "Add fallback language for Luri (lrc) to Persian (fa)"
Aaron Schulz [Fri, 10 Apr 2015 04:35:06 +0000 (21:35 -0700)]
Made JobRunner avoid slave lag more aggressively
Bug: T95501
Change-Id: Ibba6d2947638a17c86edcdaadf484c7aa45cd1c6
mjbmr [Sun, 5 Apr 2015 23:44:01 +0000 (23:44 +0000)]
Add fallback language for Luri (lrc) to Persian (fa)
It's an Iranian language and fallback was not added I think back in 2008.
It's required for the creation of the Luri Wikipedia.
All Iranian languages speakers are also native Persian.
It's already added for languages such as Baluchi (bgn), Bakhtiari (bqi),
Gilaki (glk) and Mazanderani (mzn).
I discussed this with the community as well.
Change-Id: Idf3ec73f9115343fde2e8240db867877122864de
mjbmr [Fri, 10 Apr 2015 02:31:55 +0000 (02:31 +0000)]
Update namespaces for Luri (lrc) from translatewiki
Change-Id: I241af41f278e6e117bcabd74d114a546ca69fb87
Aaron Schulz [Thu, 9 Apr 2015 22:49:15 +0000 (15:49 -0700)]
Reduce begin/commit activity in startAtomic with DBO_TRX
Change-Id: I6c1334967aeff54fb18091c23749fcb0b49624b9
jenkins-bot [Thu, 9 Apr 2015 19:00:42 +0000 (19:00 +0000)]
Merge "Set time and date formats for ce"
jenkins-bot [Thu, 9 Apr 2015 18:58:15 +0000 (18:58 +0000)]
Merge "Update special pages aliases for Westerm Baluchi (bgn) from translatewiki"
Niklas Laxström [Tue, 7 Apr 2015 13:42:19 +0000 (15:42 +0200)]
Set time and date formats for ce
Bug: T94665
Change-Id: I29b23d523785f49280c9d7add590340c31835e4d
Aaron Schulz [Thu, 9 Apr 2015 18:39:15 +0000 (11:39 -0700)]
Removed SpecialStatistics query group; vslow is enough
Change-Id: I1841f5c64ebeeed7c3e54a11216add5c104ad69d
Aaron Schulz [Thu, 9 Apr 2015 18:05:07 +0000 (11:05 -0700)]
Switched RevDelList to using start/endAtomic()
Change-Id: I2c950b558390e3fd9917414998f576e4e3b0593d
Aaron Schulz [Thu, 9 Apr 2015 18:11:31 +0000 (11:11 -0700)]
Made deleteTagEverywhere use start/endAtomic()
Change-Id: I54b697bc8c0f84d49bfcc20ec2753e18d24bf988
Translation updater bot [Thu, 9 Apr 2015 17:49:40 +0000 (19:49 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie915e0ffc24328785764b98bb47a5164162a2320
jenkins-bot [Thu, 9 Apr 2015 15:28:23 +0000 (15:28 +0000)]
Merge "Add @group Database tags to tests that need it"
jenkins-bot [Thu, 9 Apr 2015 14:54:47 +0000 (14:54 +0000)]
Merge "Fixed ApiQueryBase::selectNamedDb() return value"
Marius Hoch [Thu, 9 Apr 2015 08:32:59 +0000 (10:32 +0200)]
Have phpunit.php exit with 1 in case it couldn't run the tests
Just makes more sense not to claim we could complete everything
if we actually couldn't.
Change-Id: I4ec3a2da8913ca546782919813eb18a05a5cca0a
umherirrender [Thu, 9 Apr 2015 07:21:33 +0000 (09:21 +0200)]
Set context earlier in UploadForm::__construct
The parent constructor sets the $context for the form, but
getSourceSection is using getUser before the call, which results in a
warning for using RequestContext::getMain().
Just set the context before use.
Change-Id: I88af41b22cf05ce18d3d2852325bc97cd2544556
Yuri Astrakhan [Thu, 9 Apr 2015 05:20:56 +0000 (01:20 -0400)]
Fixed ApiQueryBase::selectNamedDb() return value
The doc specifies that this func should return
named database connection, but it does not. Fixed.
Change-Id: Ibe62ff4275201382243c4861cc4fd15cf0316e43
aude [Thu, 9 Apr 2015 04:53:37 +0000 (00:53 -0400)]
Replace use of assertType with assertInternalType and assertInstanceOf
These are available in phpunit since 3.5.0, which I think
is reasonable to expect people to have at this point,
especially when we actually require 3.7.0 or higher in phpunit.php:
Use assertSame instead of assertArrayEquals in UIDGeneratorTest.
assertSame (and assertEqual) care about sortorder of the array,
and is perfectly sufficient in this case to check they array is correct.
if ( $puVersion !== '@package_version@' && version_compare( $puVersion, '3.7.0', '<' ) ) {
die( "PHPUnit 3.7.0 or later required; you have {$puVersion}.\n" );
}
Change-Id: Ic32ab45110e4c4304ef046ae8d0e98c741255559
jenkins-bot [Thu, 9 Apr 2015 00:46:24 +0000 (00:46 +0000)]
Merge "Use XML localName when importing"
jenkins-bot [Thu, 9 Apr 2015 00:45:08 +0000 (00:45 +0000)]
Merge "Set context earlier in ImageListPager::__construct"
jenkins-bot [Thu, 9 Apr 2015 00:45:04 +0000 (00:45 +0000)]
Merge "Skip file count on Special:Statistics when no files and no upload"
jenkins-bot [Thu, 9 Apr 2015 00:44:21 +0000 (00:44 +0000)]
Merge "PLURAL support for list lengths in default-skin-not-found"
jenkins-bot [Thu, 9 Apr 2015 00:41:20 +0000 (00:41 +0000)]
Merge "Add help link to three rather important pages"
jenkins-bot [Thu, 9 Apr 2015 00:32:46 +0000 (00:32 +0000)]
Merge "Added LogEntryBase::extractParams/makeParamBlob"