From: jdlrobson <jdlrobson@gmail.com>
Date: Wed, 20 Jun 2018 00:08:51 +0000 (-0700)
Subject: Checkboxes should be styled on non-JS browsers
X-Git-Tag: 1.34.0-rc.0~4958^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/modifier.php?a=commitdiff_plain;h=91fb4977bcb9137cc8e379d773600f606068cec0;p=lhc%2Fweb%2Fwiklou.git

Checkboxes should be styled on non-JS browsers

Previously we didn't do this so that checkboxes worked on older
versions of Opera Mini.

This was added 3 years ago
(https://trello.com/c/D2FnYlmf/21-bug-fix-broken-settings-page-on-opera-mini)
https://imgur.com/a/DL6ASy4

This no longer seems to be a problem on more modern versions of
Opera Mini and given how this degrades the experience of more modern
browsers I propose we restore this styling.

Bug: T196947
Change-Id: I5f646b5c939e498eda9bec249658a969f3f91c5d
---

diff --git a/resources/src/mediawiki.ui/components/checkbox.less b/resources/src/mediawiki.ui/components/checkbox.less
index 0c13daf8b1..a1646a81ce 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -35,10 +35,8 @@
 }
 
 // We use the `:not` selector to cancel out styling on IE 8 and below
-// We also disable this styling on JavaScript disabled devices. This fixes the issue with
-// Opera Mini where checking/unchecking doesn't apply styling but potentially leaves other
-// more capable browsers with unstyled checkboxes.
-.client-js .mw-ui-checkbox:not( #noop ) {
+// Note: This may be broken on older Opera Mini devices.
+.mw-ui-checkbox:not( #noop ) {
 	display: table;
 	// Position relatively so we can make use of absolute pseudo elements
 	position: relative;